[Git][ghc/ghc][master] notes: Fix references to HPT space leak note

Marge Bot (@marge-bot) gitlab at gitlab.haskell.org
Thu Nov 24 03:02:18 UTC 2022



Marge Bot pushed to branch master at Glasgow Haskell Compiler / GHC


Commits:
11627c42 by Matthew Pickering at 2022-11-23T22:00:15-05:00
notes: Fix references to HPT space leak note

Updating this note was missed when updating the HPT to the HUG.

Fixes #22477

- - - - -


1 changed file:

- compiler/GHC/Iface/Load.hs


Changes:

=====================================
compiler/GHC/Iface/Load.hs
=====================================
@@ -602,8 +602,11 @@ This really happens in practice.  The module "GHC.Hs.Expr" gets
 This is a mess.
 
 
-Note [HPT space leak] (#15111)
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+Note [Home Unit Graph space leak]
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Ticket: #15111
+
 In IfL, we defer some work until it is demanded using forkM, such
 as building TyThings from IfaceDecls. These thunks are stored in
 the ExternalPackageState, and they might never be poked.  If we're
@@ -614,14 +617,15 @@ for ever.
 Therefore, when loading a package interface file , we use a "clean"
 version of the HscEnv with all the data about the currently loaded
 program stripped out. Most of the fields can be panics because
-we'll never read them, but hsc_HPT needs to be empty because this
+we'll never read them, but hsc_HUG needs to be empty because this
 interface will cause other interfaces to be loaded recursively, and
-when looking up those interfaces we use the HPT in loadInterface.
+when looking up those interfaces we use the HUG in loadInterface.
 We know that none of the interfaces below here can refer to
-home-package modules however, so it's safe for the HPT to be empty.
+home-package modules however, so it's safe for the HUG to be empty.
 -}
 
 -- Note [GHC Heap Invariants]
+-- Note [Home Unit Graph space leak]
 dontLeakTheHUG :: IfL a -> IfL a
 dontLeakTheHUG thing_inside = do
   env <- getTopEnv



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/11627c422cfba5e1d84afb08f427007dbc801f10

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/11627c422cfba5e1d84afb08f427007dbc801f10
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20221123/ba44f656/attachment-0001.html>


More information about the ghc-commits mailing list