[Git][ghc/ghc][wip/tsan/codegen] Deleted 22 commits: rts/Messages: Refactor

Ben Gamari (@bgamari) gitlab at gitlab.haskell.org
Sun Nov 20 01:25:59 UTC 2022



Ben Gamari pushed to branch wip/tsan/codegen at Glasgow Haskell Compiler / GHC


WARNING: The push did not contain any new commits, but force pushed to delete the commits and changes below.


Deleted commits:
63f8bdc9 by Ben Gamari at 2022-11-19T20:15:18-05:00
rts/Messages: Refactor

This doesn't change behavior but makes the code a bit easier to follow.

- - - - -
15a39d7b by Ben Gamari at 2022-11-19T20:15:18-05:00
rts/ThreadPaused: Ordering fixes

- - - - -
80b26557 by Ben Gamari at 2022-11-19T20:15:19-05:00
eventlog: Silence spurious data race

- - - - -
d59d6c19 by Ben Gamari at 2022-11-19T20:15:19-05:00
Introduce SET_INFO_RELEASE for Cmm

- - - - -
522a7f86 by Ben Gamari at 2022-11-19T20:15:19-05:00
rts: Use fences instead of explicit barriers

- - - - -
3bd090ce by Ben Gamari at 2022-11-19T20:15:19-05:00
rts/stm: Fix memory ordering in readTVarIO#

See #22421.

- - - - -
baa7e036 by Ben Gamari at 2022-11-19T20:15:19-05:00
Improve heap memory barrier Note

Also introduce MUT_FIELD marker in Closures.h to document mutable
fields.

- - - - -
90ba2853 by Ben Gamari at 2022-11-19T20:15:19-05:00
rts: Introduce getNumCapabilities

And ensure accesses to n_capabilities are atomic (although with relaxed
ordering). This is necessary as RTS API callers may concurrently call
into the RTS without holding a capability.

- - - - -
ba40302f by Ben Gamari at 2022-11-19T20:15:19-05:00
ghc: Fix data race in dump file handling

Previously the dump filename cache would use a non-atomic update which
could potentially result in lost dump contents. Note that this is still
a bit racy since the first writer may lag behind a later appending
writer.

- - - - -
4bc26b41 by Ben Gamari at 2022-11-19T20:15:19-05:00
rts: Always use atomics for context_switch and interrupt

Since these are modified by the timer handler.

- - - - -
4efe18f8 by Ben Gamari at 2022-11-19T20:15:19-05:00
rts/Timer: Always use atomic operations

As noted in #22447, the existence of the pthread-based ITimer
implementation means that we cannot assume that the program is
single-threaded.

- - - - -
0ed0929f by Ben Gamari at 2022-11-19T20:15:19-05:00
rts: Encapsulate recent_activity access

This makes it easier to ensure that it is accessed using the necessary
atomic operations.

- - - - -
e6c8486c by Ben Gamari at 2022-11-19T20:15:19-05:00
rts: Encapsulate access to capabilities array

- - - - -
2f3ee5e1 by Ben Gamari at 2022-11-19T20:15:19-05:00
rts: Encapsulate sched_state

- - - - -
11b63adb by Ben Gamari at 2022-11-19T20:15:19-05:00
PrimOps: Fix benign MutVar race

Relaxed ordering is fine here since the later CAS implies a release.

- - - - -
13d9a1fe by Ben Gamari at 2022-11-19T20:15:19-05:00
rts: Style fix

- - - - -
32519676 by Ben Gamari at 2022-11-19T20:15:19-05:00
compiler: Use release store in eager blackholing

- - - - -
bbb05912 by Ben Gamari at 2022-11-19T20:15:19-05:00
rts: Fix ordering of makeStableName

- - - - -
a7cf462e by Ben Gamari at 2022-11-19T20:15:19-05:00
rts: Use ordered accesses instead of explicit barriers

- - - - -
8461d88c by Ben Gamari at 2022-11-19T20:15:19-05:00
rts: Statically allocate capabilities

This is a rather simplistic way of solving #17289.

- - - - -
41c87b34 by Ben Gamari at 2022-11-19T20:15:19-05:00
rts: Ensure that all accesses to pending_sync are atomic

- - - - -
06c8fefb by Ben Gamari at 2022-11-19T20:15:19-05:00
rts: Note race with wakeBlockingQueue

- - - - -


30 changed files:

- compiler/GHC/StgToCmm/Bind.hs
- compiler/GHC/Utils/Logger.hs
- rts/Apply.cmm
- rts/Capability.c
- rts/Capability.h
- rts/HeapStackCheck.cmm
- rts/IOManager.c
- rts/Messages.c
- rts/Messages.h
- rts/PrimOps.cmm
- rts/Printer.c
- rts/ProfHeap.c
- rts/ProfilerReport.c
- rts/ProfilerReportJson.c
- rts/Profiling.c
- rts/Proftimer.c
- rts/RetainerProfile.c
- rts/RtsAPI.c
- rts/RtsStartup.c
- rts/SMPClosureOps.h
- rts/STM.c
- rts/Schedule.c
- rts/Schedule.h
- rts/Stats.c
- rts/StgMiscClosures.cmm
- rts/Task.c
- rts/ThreadPaused.c
- rts/Threads.c
- rts/Timer.c
- rts/TraverseHeap.c


The diff was not included because it is too large.


View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/69567ec07c1cf0eef430ec247dd4ca3308c73dea...06c8fefbd9f9b18fc3586b4c63f1629d9c41b57e

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/69567ec07c1cf0eef430ec247dd4ca3308c73dea...06c8fefbd9f9b18fc3586b4c63f1629d9c41b57e
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20221119/503867ce/attachment-0001.html>


More information about the ghc-commits mailing list