[Git][ghc/ghc][wip/T22476] 7 commits: Give better errors for code corrupted by Unicode smart quotes (#21843)

Simon Peyton Jones (@simonpj) gitlab at gitlab.haskell.org
Sat Nov 19 22:12:55 UTC 2022



Simon Peyton Jones pushed to branch wip/T22476 at Glasgow Haskell Compiler / GHC


Commits:
b0ac3813 by Lawton Nichols at 2022-11-19T03:22:14-05:00
Give better errors for code corrupted by Unicode smart quotes (#21843)

Previously, we emitted a generic and potentially confusing error during lexical
analysis on programs containing smart quotes (“/”/‘/’). This commit adds
smart quote-aware lexer errors.

- - - - -
cb8430f8 by Sebastian Graf at 2022-11-19T03:22:49-05:00
Make OpaqueNo* tests less noisy to unrelated changes

- - - - -
b1a8af69 by Sebastian Graf at 2022-11-19T03:22:49-05:00
Simplifier: Consider `seq` as a `BoringCtxt` (#22317)

See `Note [Seq is boring]` for the rationale.

Fixes #22317.

- - - - -
9fd11585 by Sebastian Graf at 2022-11-19T03:22:49-05:00
Make T21839c's ghc/max threshold more forgiving

- - - - -
4b6251ab by Simon Peyton Jones at 2022-11-19T03:23:24-05:00
Be more careful when reporting unbound RULE binders

See Note [Variables unbound on the LHS] in GHC.HsToCore.Binds.

Fixes #22471.

- - - - -
e8f2b80d by Peter Trommler at 2022-11-19T03:23:59-05:00
PPC NCG: Fix generating assembler code

Fixes #22479

- - - - -
458ba4b2 by Simon Peyton Jones at 2022-11-19T22:12:38+00:00
Buglet in GHC.Tc.Module.checkBootTyCon

This lurking bug used the wrong function to compare two
types in GHC.Tc.Module.checkBootTyCon

It's hard to trigger the bug, which only came up during
!9343, so there's no regression test in this MR.

- - - - -


30 changed files:

- compiler/GHC/CmmToAsm/PPC/Ppr.hs
- compiler/GHC/Core/FVs.hs
- compiler/GHC/Core/Opt/Simplify/Utils.hs
- compiler/GHC/Core/Subst.hs
- compiler/GHC/Core/Unfold.hs
- compiler/GHC/HsToCore.hs
- compiler/GHC/HsToCore/Binds.hs
- compiler/GHC/Parser/Errors/Ppr.hs
- compiler/GHC/Parser/Errors/Types.hs
- compiler/GHC/Parser/Lexer.x
- compiler/GHC/Tc/Gen/Rule.hs
- compiler/GHC/Tc/Module.hs
- compiler/GHC/Types/Error/Codes.hs
- + testsuite/tests/parser/should_fail/T21843a.hs
- + testsuite/tests/parser/should_fail/T21843a.stderr
- + testsuite/tests/parser/should_fail/T21843b.hs
- + testsuite/tests/parser/should_fail/T21843b.stderr
- + testsuite/tests/parser/should_fail/T21843c.hs
- + testsuite/tests/parser/should_fail/T21843c.stderr
- + testsuite/tests/parser/should_fail/T21843d.hs
- + testsuite/tests/parser/should_fail/T21843d.stderr
- + testsuite/tests/parser/should_fail/T21843e.hs
- + testsuite/tests/parser/should_fail/T21843e.stderr
- + testsuite/tests/parser/should_fail/T21843f.hs
- + testsuite/tests/parser/should_fail/T21843f.stderr
- testsuite/tests/parser/should_fail/all.T
- testsuite/tests/perf/compiler/all.T
- + testsuite/tests/simplCore/should_compile/T22317.hs
- + testsuite/tests/simplCore/should_compile/T22317.stderr
- testsuite/tests/simplCore/should_compile/T22375.stderr


The diff was not included because it is too large.


View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/551eece828991b319666270f745604dd0041ab23...458ba4b2934c82adeefdb75d6922d4563e8f4399

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/551eece828991b319666270f745604dd0041ab23...458ba4b2934c82adeefdb75d6922d4563e8f4399
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20221119/e9cbf15a/attachment.html>


More information about the ghc-commits mailing list