[Git][ghc/ghc][wip/marge_bot_batch_merge_job] 5 commits: testsuite: Add tests for T22347

Marge Bot (@marge-bot) gitlab at gitlab.haskell.org
Mon Nov 14 22:19:39 UTC 2022



Marge Bot pushed to branch wip/marge_bot_batch_merge_job at Glasgow Haskell Compiler / GHC


Commits:
d91db679 by Matthew Pickering at 2022-11-14T16:48:10-05:00
testsuite: Add tests for T22347

These are fixed in recent versions but might as well add regression
tests.

See #22347

- - - - -
8f6c576b by Matthew Pickering at 2022-11-14T16:48:45-05:00
testsuite: Improve output from tests which have failing pre_cmd

There are two changes:

* If a pre_cmd fails, then don't attempt to run the test.
* If a pre_cmd fails, then print the stdout and stderr from running that
  command (which hopefully has a nice error message).

For example:

```
=====> 1 of 1 [0, 0, 0]
*** framework failure for test-defaulting-plugin(normal) pre_cmd failed: 2
** pre_cmd was "$MAKE -s --no-print-directory -C defaulting-plugin package.test-defaulting-plugin TOP={top}".
stdout:
stderr:
DefaultLifted.hs:19:13: error: [GHC-76037]
    Not in scope: type constructor or class ‘Typ’
    Suggested fix:
      Perhaps use one of these:
        ‘Type’ (imported from GHC.Tc.Utils.TcType),
        data constructor ‘Type’ (imported from GHC.Plugins)
   |
19 | instance Eq Typ where
   |             ^^^
make: *** [Makefile:17: package.test-defaulting-plugin] Error 1

Performance Metrics (test environment: local):
```

Fixes #22329

- - - - -
16ca92cf by Madeline Haraj at 2022-11-14T17:19:30-05:00
Implement UNPACK support for sum types.

This is based on osa's unpack_sums PR from ages past.

The meat of the patch is implemented in dataConArgUnpackSum
and described in Note [UNPACK for sum types].

- - - - -
f5f850b9 by Andreas Klebinger at 2022-11-14T17:19:31-05:00
Expand on the need to clone local binders.

Fixes #22402.

- - - - -
dbefb3f6 by Krzysztof Gogolewski at 2022-11-14T17:19:32-05:00
Fix :i Constraint printing "type Constraint = Constraint"

Since Constraint became a synonym for CONSTRAINT 'LiftedRep,
we need the same code for handling printing as for the synonym
Type = TYPE 'LiftedRep.
This addresses the same bug as #18594, so I'm reusing the test.

- - - - -


30 changed files:

- compiler/GHC/Core/Make.hs
- compiler/GHC/Core/Opt/ConstantFold.hs
- compiler/GHC/CoreToStg/Prep.hs
- compiler/GHC/HsToCore/Expr.hs
- compiler/GHC/Iface/Syntax.hs
- compiler/GHC/Iface/Type.hs
- compiler/GHC/Stg/Subst.hs
- compiler/GHC/Types/Id/Make.hs
- docs/users_guide/exts/pragmas.rst
- testsuite/driver/testlib.py
- testsuite/tests/ghci/should_run/T18594.script
- testsuite/tests/ghci/should_run/T18594.stdout
- + testsuite/tests/simplCore/should_compile/T22347.hs
- + testsuite/tests/simplCore/should_compile/T22347a.hs
- testsuite/tests/simplCore/should_compile/all.T
- + testsuite/tests/unboxedsums/Makefile
- testsuite/tests/unboxedsums/all.T
- + testsuite/tests/unboxedsums/unpack_sums_1.hs
- + testsuite/tests/unboxedsums/unpack_sums_1.stdout
- + testsuite/tests/unboxedsums/unpack_sums_2.hs
- + testsuite/tests/unboxedsums/unpack_sums_3.hs
- + testsuite/tests/unboxedsums/unpack_sums_4.hs
- + testsuite/tests/unboxedsums/unpack_sums_4.stdout
- + testsuite/tests/unboxedsums/unpack_sums_5.hs
- + testsuite/tests/unboxedsums/unpack_sums_5.stderr
- + testsuite/tests/unboxedsums/unpack_sums_6.hs
- + testsuite/tests/unboxedsums/unpack_sums_6.stdout
- + testsuite/tests/unboxedsums/unpack_sums_7.hs
- + testsuite/tests/unboxedsums/unpack_sums_7.stderr
- + testsuite/tests/unboxedsums/unpack_sums_8.hs


The diff was not included because it is too large.


View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/eda1aa2803a5aa16955cc28f71240792b6466e3f...dbefb3f64f262987e9a77432fa946198f221d2ca

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/eda1aa2803a5aa16955cc28f71240792b6466e3f...dbefb3f64f262987e9a77432fa946198f221d2ca
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20221114/ce03eb77/attachment.html>


More information about the ghc-commits mailing list