[Git][ghc/ghc][wip/marge_bot_batch_merge_job] 11 commits: Start the deprecation process for GHC.Pack

Tue Nov 1 14:37:22 UTC 2022

Marge Bot pushed to branch wip/marge_bot_batch_merge_job at Glasgow Haskell Compiler / GHC

Commits:
270037fa by Hécate Moonlight at 2022-10-28T19:46:12-04:00
Start the deprecation process for GHC.Pack

- - - - -
9cec68d1 by M Farkas-Dyck at 2022-11-01T10:37:01-04:00
Drop a kludge for binutils<2.17, which is now over 10 years old.

- - - - -
5235def9 by Nicolas Trangez at 2022-11-01T10:37:02-04:00
rts: `name` argument of `createOSThread` can be `const`

Since we don't intend to ever change the incoming string, declare this
to be true.

Also, in the POSIX implementation, the argument is no longer `STG_UNUSED`
(since ee0deb8054da2a597fc5624469b4c44fd769ada2) in any code path.

See: https://gitlab.haskell.org/ghc/ghc/-/commit/ee0deb8054da2a597fc5624469b4c44fd769ada2#note_460080

- - - - -
2589e69e by Nicolas Trangez at 2022-11-01T10:37:02-04:00
rts: fix lifetime of `start_thread`s `name` value

Since, unlike the code in ee0deb8054da2^, usage of the `name` value
passed to `createOSThread` now outlives said function's lifetime, and
could hence be released by the caller by the time the new thread runs
`start_thread`, it needs to be copied.

See: https://gitlab.haskell.org/ghc/ghc/-/commit/ee0deb8054da2a597fc5624469b4c44fd769ada2#note_460080
See: https://gitlab.haskell.org/ghc/ghc/-/merge_requests/9066

- - - - -
2220718e by Nicolas Trangez at 2022-11-01T10:37:02-04:00
rts: fix OS thread naming in ticker

Since ee0deb805, the use of `pthread_setname_np` on Darwin was fixed
when invoking `createOSThread`. However, the 'ticker' has some
thread-creation code which doesn't rely on `createOSThread`, yet also
uses `pthread_setname_np`.

This patch enforces all thread creation to go through a single
function, which uses the (correct) thread-naming code introduced in
ee0deb805.

See: https://gitlab.haskell.org/ghc/ghc/-/commit/ee0deb8054da2a597fc5624469b4c44fd769ada2
See: https://gitlab.haskell.org/ghc/ghc/-/issues/22206
See: https://gitlab.haskell.org/ghc/ghc/-/merge_requests/9066

- - - - -
b5d17d3c by Krzysztof Gogolewski at 2022-11-01T10:37:03-04:00
Typo: rename -fwrite-if-simplfied-core to -fwrite-if-simplified-core

- - - - -
c5f96f15 by Vladislav Zavialov at 2022-11-01T10:37:03-04:00
ThToHs: fix overzealous parenthesization

Before this patch, when converting from TH.Exp to LHsExpr GhcPs,
the compiler inserted more parentheses than required:

	((f a) (b + c)) d

This was happening because the LHS of the function application was
parenthesized as if it was the RHS.

Now we use funPrec and appPrec appropriately and produce sensibly
parenthesized expressions:

	f a (b + c) d

I also took the opportunity to remove the special case for LamE,
which was not special at all and simply duplicated code.

- - - - -
bd4031b2 by Simon Peyton Jones at 2022-11-01T10:37:04-04:00
Add accurate skolem info when quantifying

Ticket #22379 revealed that skolemiseQuantifiedTyVar was
dropping the passed-in skol_info on the floor when it encountered
a SkolemTv.  Bad!  Several TyCons thereby share a single SkolemInfo
on their binders, which lead to bogus error reports.

- - - - -
8a675f48 by Fendor at 2022-11-01T10:37:08-04:00
Expose UnitEnvGraphKey for user-code

- - - - -
1070bf07 by Simon Peyton Jones at 2022-11-01T10:37:08-04:00
Shrink test case for #22357

Ryan Scott offered a cut-down repro case
(60 lines instead of more than 700 lines)

- - - - -
963c17b7 by Simon Peyton Jones at 2022-11-01T10:37:08-04:00
Add two tests for #17366

- - - - -

30 changed files:

- compiler/GHC/CmmToAsm/X86/CodeGen.hs
- compiler/GHC/CmmToAsm/X86/Ppr.hs
- compiler/GHC/Driver/Main.hs
- compiler/GHC/Driver/Session.hs
- compiler/GHC/Tc/Gen/HsType.hs
- compiler/GHC/Tc/TyCl.hs
- compiler/GHC/Tc/Utils/TcMType.hs
- compiler/GHC/Tc/Utils/TcType.hs
- compiler/GHC/ThToHs.hs
- compiler/GHC/Unit/Env.hs
- compiler/GHC/Unit/Module/WholeCoreBindings.hs
- docs/users_guide/phases.rst
- libraries/base/GHC/Pack.hs
- rts/include/rts/OSThreads.h
- rts/posix/OSThreads.c
- rts/posix/ticker/Pthread.c
- rts/win32/OSThreads.c
- testsuite/tests/deriving/should_fail/T21871.stderr
- testsuite/tests/driver/fat-iface/Makefile
- testsuite/tests/indexed-types/should_fail/T15870.stderr
- + testsuite/tests/polykinds/T22379a.hs
- + testsuite/tests/polykinds/T22379b.hs
- testsuite/tests/polykinds/all.T
- + testsuite/tests/simplCore/should_compile/T17366.hs
- + testsuite/tests/simplCore/should_compile/T17366.stderr
- + testsuite/tests/simplCore/should_compile/T17366_AR.hs
- + testsuite/tests/simplCore/should_compile/T17366_AR.stderr
- + testsuite/tests/simplCore/should_compile/T17366_ARa.hs
- + testsuite/tests/simplCore/should_compile/T17366a.hs
- testsuite/tests/simplCore/should_compile/T22357.hs

The diff was not included because it is too large.

View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/454b824409fefc8ccaeb05d52d2bc97d52ae94ca...963c17b77bd89c026e937405582e6b669f2ec414

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/454b824409fefc8ccaeb05d52d2bc97d52ae94ca...963c17b77bd89c026e937405582e6b669f2ec414
You're receiving this email because of your account on gitlab.haskell.org.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20221101/86bd08a1/attachment.html>