[Git][ghc/ghc][wip/marge_bot_batch_merge_job] 16 commits: hadrian: Don't enable TSAN in stage0 build

Thu Dec 15 04:54:02 UTC 2022

Marge Bot pushed to branch wip/marge_bot_batch_merge_job at Glasgow Haskell Compiler / GHC

Commits:
286607a4 by Ben Gamari at 2022-12-14T23:53:52-05:00
hadrian: Don't enable TSAN in stage0 build

- - - - -
f16b5e05 by Ben Gamari at 2022-12-14T23:53:52-05:00
cmm: Introduce blockConcat

- - - - -
4689f25b by Ben Gamari at 2022-12-14T23:53:52-05:00
cmm: Introduce MemoryOrderings

- - - - -
6e369553 by Ben Gamari at 2022-12-14T23:53:52-05:00
llvm: Respect memory specified orderings

- - - - -
eab018d6 by Ben Gamari at 2022-12-14T23:53:52-05:00
Codegen/x86: Eliminate barrier for relaxed accesses

- - - - -
c069fb53 by Ben Gamari at 2022-12-14T23:53:52-05:00
cmm/Parser: Reduce some repetition

- - - - -
12b08543 by Ben Gamari at 2022-12-14T23:53:52-05:00
cmm/Parser: Add syntax for ordered loads and stores

- - - - -
a6422e88 by Ben Gamari at 2022-12-14T23:53:52-05:00
cmm/Parser: Atomic load syntax

Originally I had thought I would just use the `prim` call syntax instead
of introducing new syntax for atomic loads. However, it turns out that
`prim` call syntax tends to make things quite unreadable. This new
syntax seems quite natural.

- - - - -
5731e5b3 by Ben Gamari at 2022-12-14T23:53:52-05:00
codeGen: Introduce ThreadSanitizer instrumentation

This introduces a new Cmm pass which instruments the program with
ThreadSanitizer annotations, allowing full tracking of mutator memory
accesses via TSAN.

- - - - -
b5f29ee4 by Ben Gamari at 2022-12-14T23:53:52-05:00
Hadrian: Drop TSAN_ENABLED define from flavour

This is redundant since the TSANUtils.h already defines it.

- - - - -
266d8012 by Ben Gamari at 2022-12-14T23:53:52-05:00
hadrian: Enable Cmm instrumentation in TSAN flavour

- - - - -
5db5a1dd by Ben Gamari at 2022-12-14T23:53:53-05:00
rts: Ensure that global regs are never passed as fun call args

This is in general unsafe as they may be clobbered if they are mapped to
caller-saved machine registers. See Note [Register parameter passing].

- - - - -
c9dc7676 by Matthew Pickering at 2022-12-14T23:53:53-05:00
Package Imports: Get candidate packages also from re-exported modules

Previously we were just looking at the direct imports to try and work
out what a package qualifier could apply to but #22333 pointed out we
also needed to look for reexported modules.

Fixes #22333

- - - - -
93e6c644 by Ben Gamari at 2022-12-14T23:53:54-05:00
compiler: Ensure that MutVar operations have necessary barriers

Here we add acquire and release barriers in readMutVar# and
writeMutVar#, which are necessary for soundness.

Fixes #22468.

- - - - -
659a55b4 by Simon Peyton Jones at 2022-12-14T23:53:54-05:00
Fix bogus test in Lint

The Lint check for branch compatiblity within an axiom, in
GHC.Core.Lint.compatible_branches was subtly different to the
check made when contructing an axiom, in
GHC.Core.FamInstEnv.compatibleBranches.

The latter is correct, so I killed the former and am now using the
latter.

On the way I did some improvements to pretty-printing and documentation.

- - - - -
ee45fd95 by Ryan Scott at 2022-12-14T23:53:55-05:00
checkValidInst: Don't expand synonyms when splitting sigma types

Previously, the `checkValidInst` function (used when checking that an instance
declaration is headed by an actual type class, not a type synonym) was using
`tcSplitSigmaTy` to split apart the `forall`s and instance context. This is
incorrect, however, as `tcSplitSigmaTy` expands type synonyms, which can cause
instances headed by quantified constraint type synonyms to be accepted
erroneously.

This patch introduces `splitInstTyForValidity`, a variant of `tcSplitSigmaTy`
specialized for validity checking that does _not_ expand type synonyms, and
uses it in `checkValidInst`.

Fixes #22570.

- - - - -

30 changed files:

- compiler/GHC/Cmm/Config.hs
- compiler/GHC/Cmm/ContFlowOpt.hs
- compiler/GHC/Cmm/Dataflow/Block.hs
- compiler/GHC/Cmm/Lexer.x
- compiler/GHC/Cmm/MachOp.hs
- compiler/GHC/Cmm/Parser.y
- compiler/GHC/Cmm/Pipeline.hs
- + compiler/GHC/Cmm/ThreadSanitizer.hs
- compiler/GHC/CmmToAsm/AArch64/CodeGen.hs
- compiler/GHC/CmmToAsm/PPC/CodeGen.hs
- compiler/GHC/CmmToAsm/Wasm/FromCmm.hs
- compiler/GHC/CmmToAsm/X86/CodeGen.hs
- compiler/GHC/CmmToC.hs
- compiler/GHC/CmmToLlvm/CodeGen.hs
- compiler/GHC/Core/Coercion.hs
- compiler/GHC/Core/Coercion/Axiom.hs
- compiler/GHC/Core/FamInstEnv.hs
- compiler/GHC/Core/Lint.hs
- compiler/GHC/Driver/Config/Cmm.hs
- compiler/GHC/Driver/Flags.hs
- compiler/GHC/Driver/Session.hs
- compiler/GHC/StgToCmm/ExtCode.hs
- compiler/GHC/StgToCmm/Prim.hs
- compiler/GHC/Tc/Validity.hs
- compiler/GHC/Unit/Finder.hs
- compiler/GHC/Unit/State.hs
- compiler/ghc.cabal.in
- docs/users_guide/debugging.rst
- hadrian/src/Flavour.hs
- rts/HeapStackCheck.cmm

The diff was not included because it is too large.

View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/6787d12f98487a07ac0e0f5ae8b4023844b158eb...ee45fd9521be13104be1dc752f1474794a8585fe

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/6787d12f98487a07ac0e0f5ae8b4023844b158eb...ee45fd9521be13104be1dc752f1474794a8585fe
You're receiving this email because of your account on gitlab.haskell.org.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20221214/a94c270e/attachment-0001.html>