[Git][ghc/ghc][wip/primop-naming-consistency] Cleanup number primop conversion names

John Ericson gitlab at gitlab.haskell.org
Sat Nov 28 16:54:24 UTC 2020



John Ericson pushed to branch wip/primop-naming-consistency at Glasgow Haskell Compiler / GHC


Commits:
98a3e441 by John Ericson at 2020-11-28T16:53:31+00:00
Cleanup number primop conversion names

Don't use "extend" or "narrow" in some of the user-facing primops
names for conversions.

  - Names like `narrowInt32#` are misleading when `Int` is 32-bits.

  - Names like `extendInt64#` are flat-out wrong when `Int is
    32-bits.

  - `narrow{Int,Word}<N>#` however map a type to itself, and so don't
    suffer from this problem. They are left as-is.

- - - - -


30 changed files:

- compiler/GHC/Builtin/primops.txt.pp
- compiler/GHC/CmmToAsm/Ppr.hs
- compiler/GHC/Core/Opt/ConstantFold.hs
- compiler/GHC/StgToCmm/Prim.hs
- compiler/GHC/Tc/Deriv/Generate.hs
- libraries/base/GHC/IO/Encoding/CodePage.hs
- libraries/base/GHC/IO/Encoding/UTF16.hs
- libraries/base/GHC/IO/Encoding/UTF32.hs
- libraries/base/GHC/IO/Encoding/UTF8.hs
- libraries/base/GHC/Int.hs
- libraries/base/GHC/Storable.hs
- libraries/base/GHC/Word.hs
- libraries/binary
- libraries/bytestring
- libraries/ghci/GHCi/BreakArray.hs
- testsuite/tests/array/should_run/arr020.hs
- testsuite/tests/cmm/opt/T18141.hs
- testsuite/tests/codeGen/should_compile/T18614.hs
- testsuite/tests/codeGen/should_run/cgrun070.hs
- testsuite/tests/codeGen/should_run/cgrun072.hs
- testsuite/tests/codeGen/should_run/cgrun075.hs
- testsuite/tests/codeGen/should_run/cgrun076.hs
- testsuite/tests/codeGen/should_run/compareByteArrays.hs
- testsuite/tests/ffi/should_run/PrimFFIInt16.hs
- testsuite/tests/ffi/should_run/PrimFFIInt8.hs
- testsuite/tests/ffi/should_run/PrimFFIWord16.hs
- testsuite/tests/ffi/should_run/PrimFFIWord8.hs
- testsuite/tests/ffi/should_run/T16650a.hs
- testsuite/tests/ffi/should_run/T16650b.hs
- testsuite/tests/ffi/should_run/UnliftedNewtypesByteArrayOffset.hs


The diff was not included because it is too large.


View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/98a3e44192a957a650bf1eeb9790e53efbdb65a1

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/98a3e44192a957a650bf1eeb9790e53efbdb65a1
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20201128/e2c78cbe/attachment.html>


More information about the ghc-commits mailing list