[Git][ghc/ghc][wip/facebook/ghc-8.8-unloading] 2 commits: rts: Introduce highMemDynamic

Ben Gamari gitlab at gitlab.haskell.org
Fri Nov 27 17:26:11 UTC 2020



Ben Gamari pushed to branch wip/facebook/ghc-8.8-unloading at Glasgow Haskell Compiler / GHC


Commits:
7fa83863 by GHC GitLab CI at 2020-11-27T12:26:00-05:00
rts: Introduce highMemDynamic

- - - - -
68d227d5 by GHC GitLab CI at 2020-11-27T12:26:00-05:00
Introduce test for dynamic library unloading

This uses the highMemDynamic flag introduced earlier to verify that
dynamic objects are properly unloaded.

- - - - -


26 changed files:

- includes/rts/storage/GC.h
- libffi-tarballs
- libraries/Cabal
- libraries/Win32
- libraries/array
- libraries/binary
- libraries/bytestring
- libraries/containers
- libraries/deepseq
- libraries/directory
- libraries/filepath
- libraries/haskeline
- libraries/hpc
- libraries/parsec
- libraries/process
- libraries/stm
- libraries/terminfo
- libraries/text
- libraries/time
- libraries/unix
- nofib
- rts/sm/Storage.c
- + testsuite/tests/rts/linker/Makefile
- + testsuite/tests/rts/linker/all.T
- + testsuite/tests/rts/linker_unload_native.c
- + testsuite/tests/rts/linker_unload_native.stdout


Changes:

=====================================
includes/rts/storage/GC.h
=====================================
@@ -227,6 +227,10 @@ void revertCAFs (void);
 // (preferably use RtsConfig.keep_cafs instead)
 void setKeepCAFs (void);
 
+// Let the runtime know that all the CAFs in high mem are not
+// to be retained. Useful in conjunction with loadNativeObj
+void setHighMemDynamic (void);
+
 /* -----------------------------------------------------------------------------
    This is the write barrier for MUT_VARs, a.k.a. IORefs.  A
    MUT_VAR_CLEAN object is not on the mutable list; a MUT_VAR_DIRTY


=====================================
libffi-tarballs
=====================================
@@ -1 +1 @@
-Subproject commit 96d02800759dcedb9c98a18a5797b86eb3b6e7c2
+Subproject commit 14c0d0caed5ffbcd4407a5eb1c27b744ef15b510


=====================================
libraries/Cabal
=====================================
@@ -1 +1 @@
-Subproject commit 8199c3f838a15fb9b7c8d3527603084b2474d877
+Subproject commit d30b8f3ec0b0873b9d2eb245afdd53fabacdb884


=====================================
libraries/Win32
=====================================
@@ -1 +1 @@
-Subproject commit ca5fbc12851b98a52f96a43ea19c54c9ecf0f9e3
+Subproject commit d68374423fa3d3edd6b776e412e4093cc69b5f64


=====================================
libraries/array
=====================================
@@ -1 +1 @@
-Subproject commit ba4d0dedd156009fbbe12a1ab8c96d537226a529
+Subproject commit 10e6c7e0522367677e4c33cc1c56eb852ef13420


=====================================
libraries/binary
=====================================
@@ -1 +1 @@
-Subproject commit fcd9d3cb2a942c54347d28bcb80a1b46d2d7d673
+Subproject commit dfaf780596328c9184758452b78288e8f405fcc1


=====================================
libraries/bytestring
=====================================
@@ -1 +1 @@
-Subproject commit 95fe6bdf13c9cc86c1c880164f7844d61d989574
+Subproject commit e043aacfc4202a59ccae8b8c8cf0e1ad83a3f209


=====================================
libraries/containers
=====================================
@@ -1 +1 @@
-Subproject commit aaeda192b34a66b1c5359a85271adf8fed26dd12
+Subproject commit 648fdb95cb4cf406ed7364533de6314069e3ffa5


=====================================
libraries/deepseq
=====================================
@@ -1 +1 @@
-Subproject commit a2d507af21a8f538b7c2fa129f0ce7ab6a7667dc
+Subproject commit 0fd7fc88aded7d7a7a1c1250fd3dcd9152edba34


=====================================
libraries/directory
=====================================
@@ -1 +1 @@
-Subproject commit 36bd1921258b759724a95ce56c5e880edf0972a2
+Subproject commit 0633b48b010093f64f98ee494265436e96456aed


=====================================
libraries/filepath
=====================================
@@ -1 +1 @@
-Subproject commit 39035d6433fff2356cf65747649666ed9b6e83e1
+Subproject commit e60969e693ffea59725cc3ebcae415343ddd0692


=====================================
libraries/haskeline
=====================================
@@ -1 +1 @@
-Subproject commit fdc6c2cced525b8f8a95f38bfc45d9362785e9ae
+Subproject commit 28ee26ad5b4ae1c0584f2ec11ac53be9671bf878


=====================================
libraries/hpc
=====================================
@@ -1 +1 @@
-Subproject commit 42bb0059dc535948ce87b846611968c1c01ae049
+Subproject commit 59e6ba02f3fa5c8f4901b4ce21777c4a9beb14b6


=====================================
libraries/parsec
=====================================
@@ -1 +1 @@
-Subproject commit 60dfb0cb6a711f141e5d8728af37de894e33795e
+Subproject commit 905bc2e3e1c374934d49e16dc5b7c49bf2c3c815


=====================================
libraries/process
=====================================
@@ -1 +1 @@
-Subproject commit 26ea79ceb2193a86f76a302a126be3319f22700d
+Subproject commit 102f5ca98661d3a6118e6610e59579c715a8ffd1


=====================================
libraries/stm
=====================================
@@ -1 +1 @@
-Subproject commit f9979c926ca539362b5a2412359750e8b498e53a
+Subproject commit a439b76a645a903757d2410dd70fe44538f45759


=====================================
libraries/terminfo
=====================================
@@ -1 +1 @@
-Subproject commit 6065302a4f75649f14397833766e82c8182935bf
+Subproject commit 9add7edcc04a9a86aa84a7faea203b654da447d1


=====================================
libraries/text
=====================================
@@ -1 +1 @@
-Subproject commit ebb98f3929360f3abb681dfca4caa8a190f9c5a8
+Subproject commit 80cb9ee2eb7141171171318bbd6760fe80012524


=====================================
libraries/time
=====================================
@@ -1 +1 @@
-Subproject commit 5319bed3b14c21de5410ead88ec8aaa838d7339c
+Subproject commit c25d6a76702b454426e149fb590da5cb69f3bd0a


=====================================
libraries/unix
=====================================
@@ -1 +1 @@
-Subproject commit bd2631b375f8c2e1d9f6c778065d0ef699cf853a
+Subproject commit e079823775066bcab56b22842be6cce6e060fb9f


=====================================
nofib
=====================================
@@ -1 +1 @@
-Subproject commit f87d446b4e361cc82f219cf78917db9681af69b3
+Subproject commit cef118de79b16fc2dddc147393a46c20f126e4a3


=====================================
rts/sm/Storage.c
=====================================
@@ -44,6 +44,7 @@ StgIndStatic  *dyn_caf_list        = NULL;
 StgIndStatic  *debug_caf_list      = NULL;
 StgIndStatic  *revertible_caf_list = NULL;
 bool           keepCAFs;
+bool           highMemDynamic;
 
 W_ large_alloc_lim;    /* GC if n_large_blocks in any nursery
                         * reaches this. */
@@ -427,7 +428,7 @@ newCAF(StgRegTable *reg, StgIndStatic *caf)
     bh = lockCAF(reg, caf);
     if (!bh) return NULL;
 
-    if(keepCAFs)
+    if(keepCAFs && !(highMemDynamic && (void*) caf > (void*) 0x80000000))
     {
         // Note [dyn_caf_list]
         // If we are in GHCi _and_ we are using dynamic libraries,
@@ -479,6 +480,12 @@ setKeepCAFs (void)
     keepCAFs = 1;
 }
 
+void
+setHighMemDynamic (void)
+{
+    highMemDynamic = 1;
+}
+
 // An alternate version of newCAF which is used for dynamically loaded
 // object code in GHCi.  In this case we want to retain *all* CAFs in
 // the object code, because they might be demanded at any time from an


=====================================
testsuite/tests/rts/linker/Makefile
=====================================
@@ -0,0 +1,121 @@
+TOP=../../..
+include $(TOP)/mk/boilerplate.mk
+include $(TOP)/mk/test.mk
+
+unsigned_reloc_macho_x64:
+	as -o unsigned_reloc_macho_x64.o unsigned_reloc_macho_x64.s
+	'$(TEST_HC)' $(TEST_HC_OPTS_NO_RTSOPTS) -v0 --make -no-rtsopts-suggestions -no-hs-main -o runner runner.c
+	./runner unsigned_reloc_macho_x64.o getAnswer
+
+section_alignment:
+	cc -c -o section_alignment.o section_alignment.c
+	'$(TEST_HC)' $(TEST_HC_OPTS_NO_RTSOPTS) -v0 --make -no-rtsopts-suggestions -no-hs-main -o runner runner.c
+	./runner section_alignment.o isAligned
+
+T2615-prep:
+	$(RM) libfoo_T2615.so
+	'$(TEST_HC)' $(TEST_HC_OPTS) -fPIC -c libfoo_T2615.c -o libfoo_T2615.o
+	'$(TEST_HC)' $(filter-out -rtsopts, $(TEST_HC_OPTS)) -shared -no-auto-link-packages libfoo_T2615.o -o libfoo_T2615.so
+
+#--------------------------------------------------------------------
+define run_T5435_v
+$(RM) T5435_load_v_$(1) T5435_v_$(1)$(exeext)
+'$(TEST_HC)' $(TEST_HC_OPTS) -optc-D$(HostOS)_HOST_OS -optc-DLOAD_CONSTR=$(2) -v0 -c T5435_$(1).c -o T5435_load_v_$(1).o
+'$(TEST_HC)' $(TEST_HC_OPTS) -v0 T5435.hs -osuf main_v_$(1)_o -o T5435_v_$(1)$(exeext)
+./T5435_v_$(1) v ./T5435_load_v_$(1).o
+endef
+
+define run_T5435_dyn
+$(RM) T5435_load_dyn_$(1) T5435_dyn_$(1)$(exeext)
+'$(TEST_HC)' $(filter-out -rtsopts, $(TEST_HC_OPTS)) -optc-D$(HostOS)_HOST_OS -v0 -fPIC -shared -c T5435_$(1).c -osuf dyn_$(1)_o -o T5435_load_dyn_$(1)$(dllext)
+'$(TEST_HC)' $(TEST_HC_OPTS) -v0 T5435.hs -osuf main_dyn_$(1)_o -o T5435_dyn_$(1)$(exeext)
+./T5435_dyn_$(1) dyn ./T5435_load_dyn_$(1)$(dllext)
+endef
+
+.PHONY: T5435_v_gcc
+T5435_v_gcc :
+	$(call run_T5435_v,gcc,0)
+
+.PHONY: T5435_v_asm_a T5435_v_asm_b
+T5435_v_asm_a :
+	$(call run_T5435_v,asm,0)
+T5435_v_asm_b :
+	$(call run_T5435_v,asm,1)
+
+.PHONY: T5435_dyn_gcc
+T5435_dyn_gcc :
+	$(call run_T5435_dyn,gcc)
+
+.PHONY: T5435_dyn_asm
+T5435_dyn_asm :
+	$(call run_T5435_dyn,asm)
+
+#--------------------------------------------------------------------
+.PHONY: linker_unload
+linker_unload:
+	$(RM) Test.o Test.hi
+	"$(TEST_HC)" $(TEST_HC_OPTS) -c Test.hs -v0
+	# -rtsopts causes a warning
+	"$(TEST_HC)" LinkerUnload.hs -package ghc $(filter-out -rtsopts, $(TEST_HC_OPTS)) linker_unload.c -o linker_unload -no-hs-main -optc-Werror
+	./linker_unload "`'$(TEST_HC)' $(TEST_HC_OPTS) --print-libdir | tr -d '\r'`"
+
+.PHONY: linker_unload_native
+linker_unload_native:
+	$(RM) Test.o Test.hi Test.a Test.so Test2.so
+	"$(TEST_HC)" $(TEST_HC_OPTS) -c Test.hs -v0 -dynamic -fPIC -o Test.a
+	# only libraries without DT_NEEDED are supported
+	"$(CC)" -shared -Wl,-Bsymbolic -nostdlib -o Test.so -Wl,-nostdlib \
+		-Wl,--whole-archive Test.a
+	cp Test.so Test2.so
+
+	# -rtsopts causes a warning
+	"$(TEST_HC)" LinkerUnload.hs -optl-Wl,--export-dynamic -package ghc \
+		$(filter-out -rtsopts, $(TEST_HC_OPTS)) linker_unload_native.c \
+		-o linker_unload_native -no-hs-main -optc-Werror
+	./linker_unload_native \
+		"`'$(TEST_HC)' $(TEST_HC_OPTS) --print-libdir | tr -d '\r'`"
+
+# -----------------------------------------------------------------------------
+# Testing failures in the RTS linker.  We should be able to repeatedly
+# load bogus object files of various kinds without crashing and
+# without any memory leaks.
+#
+# Check for memory leaks manually by running e.g.
+#
+# make linker_error1
+# valgrind --leak-check=full --show-reachable=yes ./linker_error1 linker_error1_o.o
+
+# linker_error1: not a valid object file
+
+.PHONY: linker_error1
+linker_error1:
+	"$(TEST_HC)" -c linker_error.c -o linker_error1.o
+	"$(TEST_HC)" linker_error1.o -o linker_error1 -no-hs-main -optc-g -debug -threaded
+	./linker_error1 linker_error.c
+
+# linker_error2: the object file has an unknown symbol (fails in
+# resolveObjs())
+
+.PHONY: linker_error2
+linker_error2:
+	"$(TEST_HC)" -c linker_error.c -o linker_error2.o
+	"$(TEST_HC)" -c linker_error2.c -o linker_error2_o.o
+	"$(TEST_HC)" linker_error2.o -o linker_error2 -no-hs-main -optc-g -debug -threaded
+	./linker_error2 linker_error2_o.o
+
+# linker_error3: the object file duplicates an existing symbol (fails
+# in loadObj())
+
+.PHONY: linker_error3
+linker_error3:
+	"$(TEST_HC)" -c linker_error.c -o linker_error3.o
+	"$(TEST_HC)" -c linker_error3.c -o linker_error3_o.o
+	"$(TEST_HC)" linker_error3.o -o linker_error3 -no-hs-main -optc-g -debug -threaded
+	./linker_error3 linker_error3_o.o
+
+.PHONY: T7072
+T7072:
+	"$(TEST_HC)" -c T7072-obj.c -o T7072-obj.o
+	"$(TEST_HC)" -c T7072-main.c -o T7072-main.o
+	"$(TEST_HC)" T7072-main.c -o T7072-main -no-hs-main -debug
+	./T7072-main T7072-obj.o


=====================================
testsuite/tests/rts/linker/all.T
=====================================
@@ -0,0 +1,116 @@
+# -*-: mode: python -*-
+
+test('unsigned_reloc_macho_x64',
+     [
+         extra_files(['runner.c', 'unsigned_reloc_macho_x64.s']),
+         unless(opsys('darwin'), skip),
+         unless(arch('x86_64'), skip)
+     ],
+     run_command, ['$MAKE -s --no-print-directory unsigned_reloc_macho_x64'])
+
+######################################
+test('section_alignment',
+     [
+         extra_files(['runner.c', 'section_alignment.c']),
+         unless(opsys('darwin') and arch('x86_64'), expect_broken(13624))
+     ],
+     run_command, ['$MAKE -s --no-print-directory section_alignment'])
+
+######################################
+# Test to see if linker scripts link properly to real ELF files
+test('T2615',
+     [extra_files(['libfoo_T2615.c', 'libfoo_script_T2615.so']),
+       when(opsys('mingw32'), skip),
+       # OS X doesn't seem to support linker scripts
+       when(opsys('darwin'), skip),
+       # Solaris' linker does not support GNUish linker scripts
+       when(opsys('solaris2'), skip),
+       pre_cmd('$MAKE -s --no-print-directory T2615-prep'),
+       # Add current directory to dlopen search path
+       cmd_prefix('LD_LIBRARY_PATH=$LD_LIBRARY_PATH:. '),
+       extra_clean(['libfoo_T2615.so', 'libfoo_T2615.o'])],
+     compile_and_run,
+     ['-package ghc'])
+
+######################################
+# Workaround bug #8458: old dlopen opens sections in the wrong order,
+# so we just accept both orders.
+def checkDynAsm(actual_file, normaliser):
+    actual_raw = read_no_crs(actual_file)
+    actual_str = normaliser(actual_raw)
+    actual = actual_str.split()
+    if actual == ['initArray1', 'initArray2', 'success']:
+        return True
+    elif opsys('darwin') and actual == ['modInitFunc1', 'modInitFunc2', 'success']:
+        return True
+    elif opsys('mingw32') and actual == ['ctors1', 'ctors2', 'success']:
+        return True
+    else:
+        if_verbose(1, 'T5435_dyn_asm failed with %s, see all.T for details' % actual)
+        return False
+
+# T5435_v_asm got split into two tests because depending
+# on the linker, .init_array and .ctors sections are loaded
+# in a different order (but all entries within a section
+# do get loaded in a deterministic order). So we test each
+# separately now.
+# These should have extra_clean() arguments, but I need
+# to somehow extract out the name of DLLs to do that
+test('T5435_v_asm_a',
+     [extra_files(['T5435.hs', 'T5435_asm.c']),
+      req_rts_linker,
+      when(arch('arm'), expect_broken(17559))],
+     makefile_test, ['T5435_v_asm_a'])
+# this one just needs to run on linux, as darwin/mingw32 are covered
+# by the _a test already.
+test('T5435_v_asm_b',
+     [extra_files(['T5435.hs', 'T5435_asm.c']),
+      req_rts_linker,
+      when(arch('arm'), expect_broken(17559)),
+      when(opsys('darwin') or opsys('mingw32'), skip)],
+     makefile_test, ['T5435_v_asm_b'])
+test('T5435_v_gcc',
+     [extra_files(['T5435.hs', 'T5435_gcc.c']),
+      req_rts_linker,
+      when(arch('arm'), expect_broken(17559))],
+     makefile_test, ['T5435_v_gcc'])
+test('T5435_dyn_asm',
+     [extra_files(['T5435.hs', 'T5435_asm.c']),
+      check_stdout(checkDynAsm)],
+     makefile_test, ['T5435_dyn_asm'])
+test('T5435_dyn_gcc', extra_files(['T5435.hs', 'T5435_gcc.c']) , makefile_test, ['T5435_dyn_gcc'])
+
+######################################
+test('linker_unload',
+     [extra_files(['LinkerUnload.hs', 'Test.hs']), req_rts_linker],
+     makefile_test, ['linker_unload'])
+
+test('linker_unload_native',
+     [extra_files(['LinkerUnload.hs', 'Test.hs']), req_rts_linker,
+      when(opsys('darwin') or opsys('mingw32'), skip)],
+     makefile_test, ['linker_unload_native'])
+
+######################################
+test('linker_error1', [extra_files(['linker_error.c']),
+                       ignore_stderr], makefile_test, ['linker_error1'])
+
+test('linker_error2', [extra_files(['linker_error.c']),
+                       ignore_stderr], makefile_test, ['linker_error2'])
+
+test('linker_error3', [extra_files(['linker_error.c']),
+                       ignore_stderr], makefile_test, ['linker_error3'])
+
+######################################
+test('rdynamic', [ unless(opsys('linux') or opsys('mingw32'), skip)
+                 # this needs runtime infrastructure to do in ghci:
+                 #  '-rdynamic' ghc, load modules only via dlopen(RTLD_BLOBAL) and more.
+                 , omit_ways(['ghci'])
+                 ],
+     compile_and_run, ['-rdynamic -package ghc'])
+
+
+test('T7072', 
+	[extra_files(['T7072-main.c', 'T7072-obj.c']), 
+		unless(opsys('linux'), skip), 
+		req_rts_linker], 
+	makefile_test, ['T7072'])


=====================================
testsuite/tests/rts/linker_unload_native.c
=====================================
@@ -0,0 +1,93 @@
+#include "ghcconfig.h"
+#include <stdio.h>
+#include <stdlib.h>
+#include "Rts.h"
+#include <string.h>
+#include <dlfcn.h>
+
+// poke into linker internals
+extern void *objects;
+
+#define ITERATIONS 1000
+
+#if defined(mingw32_HOST_OS)
+#define OBJPATH L"Test.so"
+#define OBJPATH2 L"Test2.so"
+#else
+#define OBJPATH "./Test.so"
+#define OBJPATH2 "./Test2.so"
+#endif
+
+typedef int testfun(int);
+
+extern void loadPackages(void);
+
+int main (int argc, char *argv[])
+{
+    testfun *f, *f2;
+    int i, r;
+
+    RtsConfig conf = defaultRtsConfig;
+    conf.rts_opts_enabled = RtsOptsAll;
+    // we want to preserve static CAFs and unload dynamic CAFs
+    conf.keep_cafs = true;
+    setHighMemDynamic();
+    hs_init_ghc(&argc, &argv, conf);
+
+    initLinker_(0);
+
+    loadPackages();
+
+    for (i=0; i < ITERATIONS; i++) {
+        char* errmsg;
+        // load 2 libraries at once
+        void* handle = loadNativeObj(OBJPATH, &errmsg);
+        if (!handle) {
+            errorBelch("loadNativeObj(%s) failed: %s", OBJPATH, errmsg);
+            free(errmsg);
+            exit(1);
+        }
+
+        void* handle2 = loadNativeObj(OBJPATH2, &errmsg);
+        if (!handle2) {
+            errorBelch("loadNativeObj(%s) failed: %s", OBJPATH2, errmsg);
+            free(errmsg);
+            exit(1);
+        }
+#if LEADING_UNDERSCORE
+        f = dlsym(handle, "_f");
+        f2 = dlsym(handle2, "_f");
+#else
+        f = dlsym(handle, "f");
+        f2 = dlsym(handle2, "f");
+#endif
+        if (!f) {
+            errorBelch("dlsym failed");
+            exit(1);
+        }
+        r = f(3);
+        if (r != 4) {
+            errorBelch("call failed; %d", r);
+            exit(1);
+        }
+        if (!f2) {
+            errorBelch("dlsym failed");
+            exit(1);
+        }
+        r = f2(3);
+        if (r != 4) {
+            errorBelch("call failed; %d", r);
+            exit(1);
+        }
+        unloadNativeObj(handle);
+        unloadNativeObj(handle2);
+        performMajorGC();
+        printf("%d ", i);
+        fflush(stdout);
+    }
+
+    // Verify that Test.so isn't still loaded.
+    int res = getObjectLoadStatus("Test.so") != OBJECT_NOT_LOADED;
+    hs_exit();
+    exit(res);
+}


=====================================
testsuite/tests/rts/linker_unload_native.stdout
=====================================
@@ -0,0 +1,3 @@
+[1 of 1] Compiling LinkerUnload     ( LinkerUnload.hs, LinkerUnload.o )
+Linking linker_unload_native ...
+0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 
\ No newline at end of file



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/958aba5ae6b579646c3c8055b1c9d3c17c3bbb03...68d227d5da4028fbb1e79cf8d743d25bfd47605b

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/958aba5ae6b579646c3c8055b1c9d3c17c3bbb03...68d227d5da4028fbb1e79cf8d743d25bfd47605b
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20201127/b79d7f55/attachment-0001.html>


More information about the ghc-commits mailing list