[Git][ghc/ghc][wip/andreask/ci_validate] 3 commits: Use correct format specifier in rts/linker/Elf.c

Andreas Klebinger gitlab at gitlab.haskell.org
Mon Nov 23 15:19:06 UTC 2020



Andreas Klebinger pushed to branch wip/andreask/ci_validate at Glasgow Haskell Compiler / GHC


Commits:
32e2a769 by Andreas Klebinger at 2020-11-23T16:18:49+01:00
Use correct format specifier in rts/linker/Elf.c

- - - - -
8feeccc7 by Andreas Klebinger at 2020-11-23T16:18:49+01:00
OSMem.c: Use proper type for mbinds mask argument.

StgWord has different widths on 32/64bit. So use the proper type
instead.

- - - - -
1966559b by Andreas Klebinger at 2020-11-23T16:18:49+01:00
Use validate flavour for all CI builds.

This also means we compile GHC with -O1 instead of -O2 for some
platforms for CI. As a result a lot of test metrics
got worse which we now have to accept.

-------------------------
Metric Increase:
    ManyAlternatives
    ManyConstructors
    MultiLayerModules
    Naperian
    T10421
    T12150
    T12227
    T12234
    T12425
    T12545
    T12707
    T13035
    T13253
    T13253-spj
    T13379
    T13719
    T14697
    T18282
    T18698a
    T18698b
    T1969
    T3064
    T3294
    T4801
    T5321FD
    T5321Fun
    T5631
    T6048
    T783
    T9020
    T9203
    T9233
    T9872a
    T9872b
    T9872c
    T9872d
    T9961
    haddock.Cabal
    haddock.base
    parsing001
-------------------------

- - - - -


3 changed files:

- .gitlab-ci.yml
- rts/linker/Elf.c
- rts/posix/OSMem.c


Changes:

=====================================
.gitlab-ci.yml
=====================================
@@ -442,7 +442,7 @@ validate-x86_64-darwin:
     LANG: "en_US.UTF-8"
     CONFIGURE_ARGS: "--with-intree-gmp"
     TEST_ENV: "x86_64-darwin"
-    BUILD_FLAVOUR: "perf"
+    BUILD_FLAVOUR: "validate"
   after_script:
     - cp -Rf $HOME/.cabal cabal-cache
     - .gitlab/ci.sh clean
@@ -493,7 +493,7 @@ validate-x86_64-darwin:
   tags:
     - x86_64-linux
   variables:
-    BUILD_FLAVOUR: "perf"
+    BUILD_FLAVOUR: "validate"
   before_script:
       # Build hyperlinked sources for documentation when building releases
     - |


=====================================
rts/linker/Elf.c
=====================================
@@ -904,7 +904,7 @@ ocGetNames_ELF ( ObjectCode* oc )
                    ASSERT(common_used <= common_size);
 
                    IF_DEBUG(linker,
-                            debugBelch("COMMON symbol, size %ld name %s allocated at %p\n",
+                            debugBelch("COMMON symbol, size %lu name %s allocated at %p\n",
                                        symbol->elf_sym->st_size, nm, symbol->addr));
 
                    /* Pointless to do addProddableBlock() for this area,


=====================================
rts/posix/OSMem.c
=====================================
@@ -364,7 +364,7 @@ void osBindMBlocksToNode(
 {
 #if HAVE_LIBNUMA
     int ret;
-    StgWord mask = 0;
+    unsigned long mask = 0;
     mask |= 1 << node;
     if (RtsFlags.GcFlags.numa) {
         ret = mbind(addr, (unsigned long)size,



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/1865c501e540ed6ec3c5f5be6e93d0e185defb83...1966559b15aad7db863dff47f5422aafa7086694

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/1865c501e540ed6ec3c5f5be6e93d0e185defb83...1966559b15aad7db863dff47f5422aafa7086694
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20201123/4ca8e083/attachment-0001.html>


More information about the ghc-commits mailing list