[Git][ghc/ghc][wip/con-info] 3 commits: Docs

[Matthew Pickering]

Matthew Pickering pushed to branch wip/con-info at Glasgow Haskell Compiler / GHC


Commits:
8640e4f0 by Matthew Pickering at 2020-11-04T09:08:27+00:00
Docs

- - - - -
a9a77b1b by Matthew Pickering at 2020-11-04T09:51:49+00:00
fix evenlog dump

- - - - -
d92b1623 by Matthew Pickering at 2020-11-04T10:08:18+00:00
Move trace IPE

- - - - -


5 changed files:

- compiler/GHC/Driver/CodeOutput.hs
- docs/users_guide/debug-info.rst
- rts/IPE.h
- rts/RtsStartup.c
- rts/Trace.h


Changes:

=====================================
compiler/GHC/Driver/CodeOutput.hs
=====================================
@@ -346,6 +346,8 @@ ipInitCode used_info dflags this_mod (InfoTableProvMap dcmap closure_map)
 {-
 Note [Mapping Info Tables to Source Positions]
 
+This note describes what the `-finfo-table-map` flag achieves.
+
 When debugging memory issues it is very useful to be able to map a specific closure
 to a position in the source. The prime example is being able to map a THUNK to
 a specific place in the source program, the mapping is usually quite precise because
@@ -361,17 +363,32 @@ various tools.
 
 -- Giving Source Locations to Closures
 
-### Thunks
-### Constructors
+At the moment thunk and constructor closures are added to the map. This information
+is collected in the `InfoTableProvMap` which provides a mapping from:
+
+1. Data constructors to a list of where they are used.
+2. `Name`s and where they originate from.
+
+During the CoreToStg phase, this map is populated whenever something is turned into
+a StgRhsClosure or an StgConApp. The current source position is recorded
+depending on the location indicated by the surrounding SourceNote.
 
+When the -fdistinct-constructor-tables` flag is turned on then every
+usage of a data constructor gets its own distinct info table. This is orchestrated
+in `coreToStgExpr` where an incrementing number is used to distinguish each
+occurrence of a data constructor.
 
+-- StgToCmm
 
+The info tables which are actually used in the generated program are recorded during the
+conversion from STG to Cmm. The used info tables are recorded in the `emitProc` function.
 
 -- Code Generation
 
 After the mapping has been collected during compilation, a C stub is generated which
 creates the static map from info table pointer to the information about where that
-info table was created from.
+info table was created from. This is created by `ipInitCode` in the same manner as a
+C stub is generated for cost centres.
 
 This information can be consumed in two ways.
 
@@ -384,7 +401,7 @@ Note [Distinct Info Tables for Constructors]
 
 In the old times, each usage of a data constructor used the same info table.
 This made it impossible to distinguish which actual usuage of a data constructor was
-contributing primarily to the allocation in a program. Using the TODO flag you
+contributing primarily to the allocation in a program. Using the `-fdistinct-info-tables` flag you
 can cause code generation to generate a distinct info table for each usage of
 a constructor. Then, when inspecting the heap you can see precisely which usage of a constructor
 was responsible for each allocation.


=====================================
docs/users_guide/debug-info.rst
=====================================
@@ -334,10 +334,11 @@ Analysis and Implementation* <http://etheses.whiterose.ac.uk/8321/>`__.
 
 
 Direct Mapping
-==============
+--------------
 
 In addition to the DWARF debug information, which can be used by many
-standard tools, using the ``-finfo-table-map`` flag
+standard tools, there is also a GHC specific way to map info table pointers
+to a source location. This lookup table is generated by using the ``-finfo-table-map`` flag.
 
 
 .. ghc-flag:: -finfo-table-map


=====================================
rts/IPE.h
=====================================
@@ -9,5 +9,10 @@
 #pragma once
 
 #include <stdio.h>
+#include "Rts.h"
 
-void dumpIPEToEventlog(void);
+#include "BeginPrivate.h"
+
+void dumpIPEToEventLog (void);
+
+#include "EndPrivate.h"


=====================================
rts/RtsStartup.c
=====================================
@@ -364,7 +364,7 @@ hs_init_ghc(int *argc, char **argv[], RtsConfig rts_config)
 #if defined(PROFILING)
     initProfiling();
 #endif
-    //dumpIPEToEventlog();
+    dumpIPEToEventLog();
     initHeapProfiling();
 
     /* start the virtual timer 'subsystem'. */


=====================================
rts/Trace.h
=====================================
@@ -302,12 +302,6 @@ void traceHeapProfCostCentre(StgWord32 ccID,
                              const char *module,
                              const char *srcloc,
                              StgBool is_caf);
-void traceIPE(StgInfoTable *info,
-               const char *table_name,
-               const char *closure_desc,
-               const char *label,
-               const char *module,
-               const char *srcloc );
 void traceHeapProfSampleCostCentre(StgWord8 profile_id,
                                    CostCentreStack *stack, StgWord residency);
 
@@ -326,6 +320,12 @@ void traceConcUpdRemSetFlush(Capability *cap);
 void traceNonmovingHeapCensus(uint32_t log_blk_size,
                               const struct NonmovingAllocCensus *census);
 
+void traceIPE(StgInfoTable *info,
+               const char *table_name,
+               const char *closure_desc,
+               const char *label,
+               const char *module,
+               const char *srcloc );
 void flushTrace(void);
 
 #else /* !TRACING */



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/fb288e2950e3644cf4978aab6d8a3c7f2722d0ae...d92b162377ac683780ba565afdc4830d11904e5d

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/fb288e2950e3644cf4978aab6d8a3c7f2722d0ae...d92b162377ac683780ba565afdc4830d11904e5d
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20201104/4338068d/attachment-0001.html>