[Git][ghc/ghc][wip/marge_bot_batch_merge_job] 22 commits: Cleanup OVERWRITING_CLOSURE logic

Marge Bot gitlab at gitlab.haskell.org
Sun May 31 12:04:01 UTC 2020 


 Marge Bot pushed to branch wip/marge_bot_batch_merge_job at Glasgow Haskell Compiler / GHC


Commits:
c51d3bd5 by Daniel Gröber at 2020-05-31T08:03:36-04:00
Cleanup OVERWRITING_CLOSURE logic

The code is just more confusing than it needs to be. We don't need to mix
the threaded check with the ldv profiling check since ldv's init already
checks for this. Hence they can be two separate checks. Taking the sanity
checking into account is also cleaner via DebugFlags.sanity. No need for
checking the DEBUG define.

The ZERO_SLOP_FOR_LDV_PROF and ZERO_SLOP_FOR_SANITY_CHECK definitions the
old code had also make things a lot more opaque IMO so I removed those.

- - - - -
49ae34bb by Daniel Gröber at 2020-05-31T08:03:36-04:00
Fix OVERWRITING_CLOSURE assuming closures are not inherently used

The new ASSERT in LDV_recordDead() was being tripped up by MVars when
removeFromMVarBlockedQueue() calls OVERWRITING_CLOSURE() via
OVERWRITE_INFO().

- - - - -
ba9529e5 by Daniel Gröber at 2020-05-31T08:03:36-04:00
Always zero shrunk mutable array slop when profiling

When shrinking arrays in the profiling way we currently don't always zero
the leftover slop. This means we can't traverse such closures in the heap
profiler. The old Note [zeroing slop] and #8402 have some rationale for why
this is so but I belive the reasoning doesn't apply to mutable
closures. There users already have to ensure multiple threads don't step on
each other's toes so zeroing should be safe.

- - - - -
23d26bbd by Ben Gamari at 2020-05-31T08:03:37-04:00
testsuite: Add test for #18151

- - - - -
6667b4f2 by Ben Gamari at 2020-05-31T08:03:37-04:00
testsuite: Add test for desugaring of PostfixOperators

- - - - -
a1d5df6a by Ben Gamari at 2020-05-31T08:03:37-04:00
HsToCore: Eta expand left sections

Strangely, the comment next to this code already alluded to the fact
that even simply eta-expanding will sacrifice laziness. It's quite
unclear how we regressed so far.

See #18151.

- - - - -
f56120dc by Kirill Elagin at 2020-05-31T08:03:46-04:00
Winferred-safe-imports: Do not exit with error

Currently, when -Winferred-safe-imports is enabled, even when it is not
turned into an error, the compiler will still exit with exit code 1 if
this warning was emitted.

Make sure it is really treated as a warning.

- - - - -
ba7882bd by Ben Gamari at 2020-05-31T08:03:46-04:00
nonmoving: Optimise log2_ceil

- - - - -
ba8fc926 by Bodigrim at 2020-05-31T08:03:47-04:00
Clarify description of fromListN
- - - - -
5375b1cf by Bodigrim at 2020-05-31T08:03:47-04:00
Apply suggestion to libraries/base/GHC/Exts.hs
- - - - -
e4824962 by fendor at 2020-05-31T08:03:48-04:00
Add `isInScope` check to `lintCoercion`

Mirrors the behaviour of `lintType`.

- - - - -
2b727245 by fendor at 2020-05-31T08:03:48-04:00
Lint rhs of IfaceRule

- - - - -
50b2ceef by Jeremy Schlatter at 2020-05-31T08:03:50-04:00
Fix wording in documentation

The duplicate "orphan instance" phrase here doesn't make sense, and was
probably an accident.

- - - - -
d43e9448 by Takenobu Tani at 2020-05-31T08:03:51-04:00
configure: Modify aclocal.m4 according to new module hierarchy

This patch updates file paths according to new module hierarchy [1]:

* Rename:
  * compiler/GHC/Parser.hs       <= compiler/parser/Parser.hs
  * compiler/GHC/Parser/Lexer.hs <= compiler/Parser/Lexer.hs

* Add:
  * compiler/GHC/Cmm/Lexer.hs

[1]: https://gitlab.haskell.org/ghc/ghc/-/wikis/Make-GHC-codebase-more-modular

- - - - -
6481c390 by Ben Gamari at 2020-05-31T08:03:52-04:00
testsuite: Don't fail if we can't unlink __symlink_test

Afterall, it's possible we were unable to create it due to lack of
symlink permission.

- - - - -
0d64a28a by Ben Gamari at 2020-05-31T08:03:52-04:00
testsuite: Refactor ghostscript detection

Tamar reported that he saw crashes due to unhandled exceptions.

- - - - -
54591739 by Ben Gamari at 2020-05-31T08:03:52-04:00
testsuite/perf_notes: Fix ill-typed assignments

- - - - -
eb4df111 by Ben Gamari at 2020-05-31T08:03:52-04:00
testsuite/testutil: Fix bytes/str mismatch

- - - - -
b37aacf5 by Ben Gamari at 2020-05-31T08:03:52-04:00
testsuite: Work around spurious mypy failure

- - - - -
9d9d193e by Takenobu Tani at 2020-05-31T08:03:54-04:00
Clean up file paths for new module hierarchy

This updates comments only.
This patch replaces file references according to new module hierarchy.

See also:
* https://gitlab.haskell.org/ghc/ghc/-/wikis/Make-GHC-codebase-more-modular
* https://gitlab.haskell.org/ghc/ghc/issues/13009

- - - - -
acd9032c by Takenobu Tani at 2020-05-31T08:03:54-04:00
Modify file paths to module paths for new module hierarchy

This updates comments only.

This patch replaces module references according to new module
hierarchy [1][2].

For files under the `compiler/` directory, I replace them as
module paths instead of file paths. For instance,
`GHC.Unit.State` instead of `compiler/GHC/Unit/State.hs` [3].

For current and future haddock's markup, this patch encloses
the module name with "" [4].

[1]: https://gitlab.haskell.org/ghc/ghc/-/wikis/Make-GHC-codebase-more-modular
[2]: https://gitlab.haskell.org/ghc/ghc/issues/13009
[3]: https://gitlab.haskell.org/ghc/ghc/-/merge_requests/3375#note_276613
[4]: https://haskell-haddock.readthedocs.io/en/latest/markup.html#linking-to-modules

- - - - -
61d992af by Sylvain Henry at 2020-05-31T08:03:56-04:00
Hadrian: fix binary-dist target for cross-compilation

- - - - -


30 changed files:

- aclocal.m4
- compiler/GHC.hs
- compiler/GHC/Cmm/Utils.hs
- compiler/GHC/CmmToAsm/SPARC/Base.hs
- compiler/GHC/Core/Coercion/Opt.hs
- compiler/GHC/Core/InstEnv.hs
- compiler/GHC/Core/Lint.hs
- compiler/GHC/Core/Opt/ConstantFold.hs
- compiler/GHC/Core/TyCo/Tidy.hs
- compiler/GHC/Core/TyCon.hs
- compiler/GHC/Core/Unfold.hs
- compiler/GHC/Driver/Main.hs
- compiler/GHC/HsToCore/Expr.hs
- compiler/GHC/HsToCore/PmCheck/Oracle.hs
- compiler/GHC/HsToCore/PmCheck/Types.hs
- compiler/GHC/Iface/Ext/Ast.hs
- compiler/GHC/Iface/Type.hs
- compiler/GHC/IfaceToCore.hs
- compiler/GHC/Parser/Lexer.x
- compiler/GHC/Runtime/Interpreter.hs
- compiler/GHC/StgToCmm/Expr.hs
- compiler/GHC/StgToCmm/Utils.hs
- compiler/GHC/SysTools/ExtraObj.hs
- compiler/GHC/Tc/Deriv.hs
- compiler/GHC/ThToHs.hs
- compiler/GHC/Utils/Outputable.hs
- compiler/GHC/Utils/Ppr.hs
- compiler/ghc.mk
- docs/users_guide/separate_compilation.rst
- hadrian/src/Rules/BinaryDist.hs


The diff was not included because it is too large.


View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/c3e9088d557c27f7d4da518fe184d3cde2f7755d...61d992af80acb5578852f844430aee1fa5a843fb

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/c3e9088d557c27f7d4da518fe184d3cde2f7755d...61d992af80acb5578852f844430aee1fa5a843fb
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20200531/dbedb849/attachment.html>

More information about the ghc-commits mailing list