[Git][ghc/ghc][wip/marge_bot_batch_merge_job] 20 commits: Cleanup OVERWRITING_CLOSURE logic

Sat May 30 15:50:28 UTC 2020

 Marge Bot pushed to branch wip/marge_bot_batch_merge_job at Glasgow Haskell Compiler / GHC

Commits:
f178557d by Daniel Gröber at 2020-05-30T11:49:40-04:00
Cleanup OVERWRITING_CLOSURE logic

The code is just more confusing than it needs to be. We don't need to mix
the threaded check with the ldv profiling check since ldv's init already
checks for this. Hence they can be two separate checks. Taking the sanity
checking into account is also cleaner via DebugFlags.sanity. No need for
checking the DEBUG define.

The ZERO_SLOP_FOR_LDV_PROF and ZERO_SLOP_FOR_SANITY_CHECK definitions the
old code had also make things a lot more opaque IMO so I removed those.

- - - - -
c5c5ed2c by Daniel Gröber at 2020-05-30T11:49:40-04:00
Fix OVERWRITING_CLOSURE assuming closures are not inherently used

The new ASSERT in LDV_recordDead() was being tripped up by MVars when
removeFromMVarBlockedQueue() calls OVERWRITING_CLOSURE() via
OVERWRITE_INFO().

- - - - -
9ca9bb94 by Daniel Gröber at 2020-05-30T11:49:40-04:00
Always zero shrunk mutable array slop when profiling

When shrinking arrays in the profiling way we currently don't always zero
the leftover slop. This means we can't traverse such closures in the heap
profiler. The old Note [zeroing slop] and #8402 have some rationale for why
this is so but I belive the reasoning doesn't apply to mutable
closures. There users already have to ensure multiple threads don't step on
each other's toes so zeroing should be safe.

- - - - -
8682beae by Ben Gamari at 2020-05-30T11:49:40-04:00
testsuite: Add test for #18151

- - - - -
34db6a0b by Ben Gamari at 2020-05-30T11:49:40-04:00
testsuite: Add test for desugaring of PostfixOperators

- - - - -
2f054f65 by Ben Gamari at 2020-05-30T11:49:40-04:00
HsToCore: Eta expand left sections

Strangely, the comment next to this code already alluded to the fact
that even simply eta-expanding will sacrifice laziness. It's quite
unclear how we regressed so far.

See #18151.

- - - - -
fb21b586 by Kirill Elagin at 2020-05-30T11:49:50-04:00
Winferred-safe-imports: Do not exit with error

Currently, when -Winferred-safe-imports is enabled, even when it is not
turned into an error, the compiler will still exit with exit code 1 if
this warning was emitted.

Make sure it is really treated as a warning.

- - - - -
2b915b25 by Ben Gamari at 2020-05-30T11:49:51-04:00
nonmoving: Optimise log2_ceil

- - - - -
cbd16b60 by Bodigrim at 2020-05-30T11:49:51-04:00
Clarify description of fromListN
- - - - -
7fa0a9d8 by Bodigrim at 2020-05-30T11:49:51-04:00
Apply suggestion to libraries/base/GHC/Exts.hs
- - - - -
86428f6b by Jeremy Schlatter at 2020-05-30T11:49:54-04:00
Fix wording in documentation

The duplicate "orphan instance" phrase here doesn't make sense, and was
probably an accident.

- - - - -
0ec612ed by Takenobu Tani at 2020-05-30T11:50:04-04:00
configure: Modify aclocal.m4 according to new module hierarchy

This patch updates file paths according to new module hierarchy [1]:

* Rename:
  * compiler/GHC/Parser.hs       <= compiler/parser/Parser.hs
  * compiler/GHC/Parser/Lexer.hs <= compiler/Parser/Lexer.hs

* Add:
  * compiler/GHC/Cmm/Lexer.hs

[1]: https://gitlab.haskell.org/ghc/ghc/-/wikis/Make-GHC-codebase-more-modular

- - - - -
38b188ab by Ben Gamari at 2020-05-30T11:50:04-04:00
testsuite: Don't fail if we can't unlink __symlink_test

Afterall, it's possible we were unable to create it due to lack of
symlink permission.

- - - - -
b36dbe16 by Ben Gamari at 2020-05-30T11:50:04-04:00
testsuite: Refactor ghostscript detection

Tamar reported that he saw crashes due to unhandled exceptions.

- - - - -
b6de960b by Ben Gamari at 2020-05-30T11:50:04-04:00
testsuite/perf_notes: Fix ill-typed assignments

- - - - -
3e3de1af by Ben Gamari at 2020-05-30T11:50:04-04:00
testsuite/testutil: Fix bytes/str mismatch

- - - - -
f117ffc5 by Ben Gamari at 2020-05-30T11:50:04-04:00
testsuite: Work around spurious mypy failure

- - - - -
9b3e71bd by Takenobu Tani at 2020-05-30T11:50:07-04:00
Clean up file paths for new module hierarchy

This updates comments only.
This patch replaces file references according to new module hierarchy.

See also:
* https://gitlab.haskell.org/ghc/ghc/-/wikis/Make-GHC-codebase-more-modular
* https://gitlab.haskell.org/ghc/ghc/issues/13009

- - - - -
56f5309b by Takenobu Tani at 2020-05-30T11:50:07-04:00
Modify file paths to module paths for new module hierarchy

This updates comments only.

This patch replaces module references according to new module
hierarchy [1][2].

For files under the `compiler/` directory, I replace them as
module paths instead of file paths. For instance,
`GHC.Unit.State` instead of `compiler/GHC/Unit/State.hs` [3].

For current and future haddock's markup, this patch encloses
the module name with "" [4].

[1]: https://gitlab.haskell.org/ghc/ghc/-/wikis/Make-GHC-codebase-more-modular
[2]: https://gitlab.haskell.org/ghc/ghc/issues/13009
[3]: https://gitlab.haskell.org/ghc/ghc/-/merge_requests/3375#note_276613
[4]: https://haskell-haddock.readthedocs.io/en/latest/markup.html#linking-to-modules

- - - - -
83e3ffc7 by Sylvain Henry at 2020-05-30T11:50:18-04:00
Hadrian: fix binary-dist target for cross-compilation

- - - - -

30 changed files:

- aclocal.m4
- compiler/GHC.hs
- compiler/GHC/Cmm/Utils.hs
- compiler/GHC/CmmToAsm/SPARC/Base.hs
- compiler/GHC/Core/Coercion/Opt.hs
- compiler/GHC/Core/InstEnv.hs
- compiler/GHC/Core/Opt/ConstantFold.hs
- compiler/GHC/Core/TyCo/Tidy.hs
- compiler/GHC/Core/TyCon.hs
- compiler/GHC/Core/Unfold.hs
- compiler/GHC/Driver/Main.hs
- compiler/GHC/HsToCore/Expr.hs
- compiler/GHC/HsToCore/PmCheck/Oracle.hs
- compiler/GHC/HsToCore/PmCheck/Types.hs
- compiler/GHC/Iface/Ext/Ast.hs
- compiler/GHC/Iface/Type.hs
- compiler/GHC/Parser/Lexer.x
- compiler/GHC/Runtime/Interpreter.hs
- compiler/GHC/StgToCmm/Expr.hs
- compiler/GHC/StgToCmm/Utils.hs
- compiler/GHC/SysTools/ExtraObj.hs
- compiler/GHC/Tc/Deriv.hs
- compiler/GHC/ThToHs.hs
- compiler/GHC/Utils/Outputable.hs
- compiler/GHC/Utils/Ppr.hs
- compiler/ghc.mk
- docs/users_guide/separate_compilation.rst
- hadrian/src/Rules/BinaryDist.hs
- hadrian/src/Way.hs
- includes/Cmm.h

The diff was not included because it is too large.

View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/ae9f06bac738415f38080b759690229ea802e328...83e3ffc7f732060a42d69d47648415e563f04e5e

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/ae9f06bac738415f38080b759690229ea802e328...83e3ffc7f732060a42d69d47648415e563f04e5e
You're receiving this email because of your account on gitlab.haskell.org.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20200530/eced004b/attachment.html>