[Git][ghc/ghc][master] MR template should ask for key part

Marge Bot gitlab at gitlab.haskell.org
Thu May 21 16:18:56 UTC 2020



 Marge Bot pushed to branch master at Glasgow Haskell Compiler / GHC


Commits:
2b363ebb by Richard Eisenberg at 2020-05-21T12:18:45-04:00
MR template should ask for key part
- - - - -


1 changed file:

- .gitlab/merge_request_templates/merge-request.md


Changes:

=====================================
.gitlab/merge_request_templates/merge-request.md
=====================================
@@ -1,5 +1,10 @@
 Thank you for your contribution to GHC!
 
+**Please read the checklist below to make sure your contribution fulfills these
+expectations. Also please answer the following question in your MR description:**
+
+**Where is the key part of this patch? That is, what should reviewers look at first?**
+
 Please take a few moments to verify that your commits fulfill the following:
 
  * [ ] are either individually buildable or squashed
@@ -10,7 +15,7 @@ Please take a few moments to verify that your commits fulfill the following:
    likely should add a [Note][notes] and cross-reference it from the relevant
    places.
  * [ ] add a [testcase to the testsuite](https://gitlab.haskell.org/ghc/ghc/wikis/building/running-tests/adding).
- * [ ] if your MR affects library interfaces (e.g. changes `base`) please add
+ * [ ] if your MR affects library interfaces (e.g. changes `base`) or affects whether GHC will accept user-written code, please add
    the ~"user facing" label.
  * [ ] updates the users guide if applicable
  * [ ] mentions new features in the release notes for the next release



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/2b363ebb988cbf8c92df24eef5366293a80ecb19

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/2b363ebb988cbf8c92df24eef5366293a80ecb19
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20200521/624fd020/attachment.html>


More information about the ghc-commits mailing list