[Git][ghc/ghc][wip/marge_bot_batch_merge_job] 12 commits: rts/CNF: Fix fixup comparison function

Marge Bot gitlab at gitlab.haskell.org
Tue May 12 22:32:15 UTC 2020



 Marge Bot pushed to branch wip/marge_bot_batch_merge_job at Glasgow Haskell Compiler / GHC


Commits:
b57594c3 by Ben Gamari at 2020-05-12T18:32:00-04:00
rts/CNF: Fix fixup comparison function

Previously we would implicitly convert the difference between two words
to an int, resulting in an integer overflow on 64-bit machines.

Fixes #16992

- - - - -
ea1264db by Ömer Sinan Ağacan at 2020-05-12T18:32:02-04:00
Pack some of IdInfo fields into a bit field

This reduces residency of compiler quite a bit on some programs.
Example stats when building T10370:

Before:

   2,871,242,832 bytes allocated in the heap
   4,693,328,008 bytes copied during GC
      33,941,448 bytes maximum residency (276 sample(s))
         375,976 bytes maximum slop
              83 MiB total memory in use (0 MB lost due to fragmentation)

After:

   2,858,897,344 bytes allocated in the heap
   4,629,255,440 bytes copied during GC
      32,616,624 bytes maximum residency (278 sample(s))
         314,400 bytes maximum slop
              80 MiB total memory in use (0 MB lost due to fragmentation)

So -3.9% residency, -1.3% bytes copied and -0.4% allocations.

Fixes #17497

Metric Decrease:
    T9233
    T9675

- - - - -
460a60cf by Ben Gamari at 2020-05-12T18:32:03-04:00
get-win32-tarballs: Fix base URL

Revert a change previously made for testing purposes.

- - - - -
767796fa by Ben Gamari at 2020-05-12T18:32:03-04:00
get-win32-tarballs: Improve diagnostics output

- - - - -
59587dee by Simon Jakobi at 2020-05-12T18:32:04-04:00
docs: Add examples for Data.Semigroup.Arg{Min,Max}

Context: #17153

- - - - -
9d690898 by Ben Gamari at 2020-05-12T18:32:05-04:00
Add few cleanups of the CAF logic

Give the NameSet of non-CAFfy names a proper newtype to distinguish it
from all of the other NameSets floating about.

- - - - -
61e16cbc by Emeka Nkurumeh at 2020-05-12T18:32:08-04:00
fix printf warning when using with ghc with clang on mingw
- - - - -
b1704686 by Sebastian Graf at 2020-05-12T18:32:08-04:00
CprAnal: Don't attach CPR sigs to expandable bindings (#18154)

Instead, look through expandable unfoldings in `cprTransform`.
See the new Note [CPR for expandable unfoldings]:

```
Long static data structures (whether top-level or not) like

  xs = x1 : xs1
  xs1 = x2 : xs2
  xs2 = x3 : xs3

should not get CPR signatures, because they

  * Never get WW'd, so their CPR signature should be irrelevant after analysis
    (in fact the signature might even be harmful for that reason)
  * Would need to be inlined/expanded to see their constructed product
  * Recording CPR on them blows up interface file sizes and is redundant with
    their unfolding. In case of Nested CPR, this blow-up can be quadratic!

But we can't just stop giving DataCon application bindings the CPR property,
for example

  fac 0 = 1
  fac n = n * fac (n-1)

fac certainly has the CPR property and should be WW'd! But FloatOut will
transform the first clause to

  lvl = 1
  fac 0 = lvl

If lvl doesn't have the CPR property, fac won't either. But lvl doesn't have a
CPR signature to extrapolate into a CPR transformer ('cprTransform'). So
instead we keep on cprAnal'ing through *expandable* unfoldings for these arity
0 bindings via 'cprExpandUnfolding_maybe'.

In practice, GHC generates a lot of (nested) TyCon and KindRep bindings, one
for each data declaration. It's wasteful to attach CPR signatures to each of
them (and intractable in case of Nested CPR).
```

Fixes #18154.

- - - - -
8a2e894d by Ben Gamari at 2020-05-12T18:32:09-04:00
users-guide: Add discussion of shared object naming

Fixes #18074.

- - - - -
4e04d525 by Ben Gamari at 2020-05-12T18:32:09-04:00
testsuite: Print sign of performance changes

Executes the minor formatting change in the tabulated performance
changes suggested in #18135.

- - - - -
710edf96 by Ben Gamari at 2020-05-12T18:32:09-04:00
testsuite: Add testcase for #18129

- - - - -
bef5dc3e by Ivan-Yudin at 2020-05-12T18:32:11-04:00
doc: Reformulate the opening paragraph of Ch. 4 in User's guide

Removes mentioning of Hugs
(it is not helpful for new users anymore).

Changes the wording for the rest of the paragraph.

Fixes #18132.

- - - - -


30 changed files:

- compiler/GHC/Cmm/Info/Build.hs
- compiler/GHC/Core/Opt/CprAnal.hs
- compiler/GHC/Driver/Main.hs
- compiler/GHC/Iface/Make.hs
- compiler/GHC/Iface/UpdateCafInfos.hs
- compiler/GHC/Types/Id/Info.hs
- compiler/GHC/Types/Name/Set.hs
- docs/users_guide/ghci.rst
- docs/users_guide/packages.rst
- docs/users_guide/phases.rst
- includes/rts/Messages.h
- libraries/base/Data/Semigroup.hs
- + libraries/ghc-compact/tests/T16992.hs
- + libraries/ghc-compact/tests/T16992.stdout
- libraries/ghc-compact/tests/all.T
- mk/get-win32-tarballs.py
- rts/sm/CNF.c
- testsuite/driver/runtests.py
- testsuite/tests/numeric/should_compile/T14170.stdout
- testsuite/tests/numeric/should_compile/T14465.stdout
- testsuite/tests/numeric/should_compile/T7116.stdout
- testsuite/tests/simplCore/should_compile/T13143.stderr
- testsuite/tests/simplCore/should_compile/T13543.stderr
- testsuite/tests/simplCore/should_compile/T18013.stderr
- testsuite/tests/simplCore/should_compile/T3717.stderr
- testsuite/tests/simplCore/should_compile/T3772.stdout
- testsuite/tests/simplCore/should_compile/T4908.stderr
- testsuite/tests/simplCore/should_compile/T4930.stderr
- testsuite/tests/simplCore/should_compile/T7360.stderr
- testsuite/tests/simplCore/should_compile/noinline01.stderr


The diff was not included because it is too large.


View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/2523ce32679761361e0313b85aece7e66f0b0b75...bef5dc3e525f80612206eb792833a54566f688ad

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/2523ce32679761361e0313b85aece7e66f0b0b75...bef5dc3e525f80612206eb792833a54566f688ad
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20200512/6c3863c2/attachment.html>


More information about the ghc-commits mailing list