[Git][ghc/ghc][wip/T16806] Remove comments

[Simon Jakobi]

Simon Jakobi pushed to branch wip/T16806 at Glasgow Haskell Compiler / GHC


Commits:
7cd4c63b by Simon Jakobi at 2020-03-31T18:04:53+02:00
Remove comments

- - - - -


1 changed file:

- compiler/GHC/Stg/Lift/Analysis.hs


Changes:

=====================================
compiler/GHC/Stg/Lift/Analysis.hs
=====================================
@@ -538,14 +538,14 @@ closureGrowth expander sizer group abs_ids = go
       -- the closure growth of its RHS.
       | otherwise   = mkIntWithInf cost + go rhs
       where
-        n_occs = sizeDVarSet (clo_fvs' `dVarSetIntersectVarSet` group) -- TODO: Try disjoint
+        n_occs = sizeDVarSet (clo_fvs' `dVarSetIntersectVarSet` group)
         -- What we close over considering prior lifting decisions
         clo_fvs' = expander clo_fvs
         -- Variables that would additionally occur free in the closure body if
         -- we lift @f@
         newbies = abs_ids `minusDVarSet` clo_fvs'
         -- Lifting @f@ removes @f@ from the closure but adds all @newbies@
-        cost = foldDVarSet (\id size -> sizer id + size) 0 newbies - n_occs -- TODO: Do we  really want a right fold here? Also: no need to do this in deterministic order!
+        cost = foldDVarSet (\id size -> sizer id + size) 0 newbies - n_occs
     go (RhsSk body_dmd body)
       -- The conservative assumption would be that
       --   1. Every RHS with positive growth would be called multiple times,



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/7cd4c63b5007602a664aa9e8c7c3003021100559

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/7cd4c63b5007602a664aa9e8c7c3003021100559
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20200331/e7c213c9/attachment-0001.html>