[Git][ghc/ghc][wip/tycl-group] minor comments

[Vladislav Zavialov]

Vladislav Zavialov pushed to branch wip/tycl-group at Glasgow Haskell Compiler / GHC


Commits:
8c28209b by Vladislav Zavialov at 2020-03-19T14:04:23Z
minor comments

- - - - -


2 changed files:

- compiler/GHC/Driver/Plugins.hs
- compiler/GHC/Hs/Decls.hs


Changes:

=====================================
compiler/GHC/Driver/Plugins.hs
=====================================
@@ -229,7 +229,7 @@ keepRenamedSource _ gbl_env group =
     update_exports Nothing = Just []
     update_exports m = m
 
-    update Nothing = Just (emptyRnGroup :: HsGroup GhcRn)
+    update Nothing = Just emptyRnGroup
     update m       = m
 
 


=====================================
compiler/GHC/Hs/Decls.hs
=====================================
@@ -260,7 +260,7 @@ data HsGroup p
 
 type instance XCHsGroup GhcPs = NoExtField
 type instance XCHsGroup GhcRn = KindedDecls
-type instance XCHsGroup GhcTc = KindedDecls
+type instance XCHsGroup GhcTc = Void
 type instance XXHsGroup (GhcPass _) = NoExtCon
 
 -- | Names of declarations that either have a CUSK or a SAKS.
@@ -275,9 +275,13 @@ instance Monoid KindedDecls where
 isKindedDecl :: KindedDecls -> TyClDecl GhcRn -> Bool
 isKindedDecl (KindedDecls nameSet) d = elemNameSet (tcdName d) nameSet
 
-emptyGroup, emptyRdrGroup, emptyRnGroup :: Monoid (XCHsGroup (GhcPass p)) => HsGroup (GhcPass p)
+emptyGroup :: Monoid (XCHsGroup (GhcPass p)) => HsGroup (GhcPass p)
+
+emptyRdrGroup :: HsGroup GhcPs
 emptyRdrGroup = emptyGroup { hs_valds = emptyValBindsIn }
-emptyRnGroup  = emptyGroup { hs_valds = emptyValBindsOut }
+
+emptyRnGroup :: HsGroup GhcRn
+emptyRnGroup = emptyGroup { hs_valds = emptyValBindsOut }
 
 emptyGroup = HsGroup { hs_ext = mempty,
                        hs_tyclds = [],



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/commit/8c28209b53e324fd56fdc184db3e88ea82009b70

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/commit/8c28209b53e324fd56fdc184db3e88ea82009b70
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20200319/601af53e/attachment-0001.html>