[Git][ghc/ghc][wip/osa1/std_string_thunks] Remove commented-out code, commit perf changes

[Ömer Sinan Ağacan]

Ömer Sinan Ağacan pushed to branch wip/osa1/std_string_thunks at Glasgow Haskell Compiler / GHC


Commits:
c02cf00c by Ömer Sinan Ağacan at 2020-06-01T11:34:26+03:00
Remove commented-out code, commit perf changes

Metric Decrease:
    T11195
    T12150
    T12425

- - - - -


1 changed file:

- compiler/GHC/StgToCmm/Bind.hs


Changes:

=====================================
compiler/GHC/StgToCmm/Bind.hs
=====================================
@@ -248,34 +248,6 @@ mkRhsClosure :: DynFlags -> Id -> CostCentreStack
              -> CgStgExpr
              -> FCode (CgIdInfo, FCode CmmAGraph)
 
-{-
-    TODO: Consider handling this too. Not sure if it's going to save us much to
-          so this needs benchmarking.
-
----------- unpackCString# --------------------
-mkRhsClosure    dflags bndr _cc
-                []         -- No free variables, because this is top-level
-                Updatable  -- Updatable thunk
-                []         -- A thunk
-                expr
-
-  | let expr_no_ticks = stripStgTicksTopE (not . tickishIsCode) expr
-  , StgApp fn [arg] <- expr
-  , idName fn == unpackCStringName
-  = -- TODO: What to do with ticks?
-    -- A non-top-level unpackCString# closure. Most unpackCString# closures are
-    -- floted to the top-level, but sometimes we see simplifier-generated thunks
-    -- like:
-    --
-    --     sat_sK0 [Occ=Once] :: [GHC.Types.Char]
-    --     [LclId] =
-    --         {} \u []
-    --             GHC.CString.unpackCString#
-    --                 "Oops! The program has entered an `absent' argument!\n"#;
-    --
-    pprPanic "mkRhsClosure" (text "unpackCString# closure:" <+> ppr expr)
--}
-
 {- mkRhsClosure looks for two special forms of the right-hand side:
         a) selector thunks
         b) AP thunks



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/c02cf00ca64b658c4e9d57e28cdd87535766e7be

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/c02cf00ca64b658c4e9d57e28cdd87535766e7be
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20200601/57c830d7/attachment-0001.html>