[Git][ghc/ghc][wip/buggymcbugfix/insertArray] address comments

Vilem-Benjamin Liepelt gitlab at gitlab.haskell.org
Mon Aug 31 12:10:53 UTC 2020



Vilem-Benjamin Liepelt pushed to branch wip/buggymcbugfix/insertArray at Glasgow Haskell Compiler / GHC


Commits:
c045d93a by buggymcbugfix at 2020-08-31T14:10:42+02:00
address comments

- - - - -


1 changed file:

- rts/PrimOps.cmm


Changes:

=====================================
rts/PrimOps.cmm
=====================================
@@ -373,15 +373,15 @@ stg_casArrayzh ( gcptr arr, W_ ind, gcptr old, gcptr new )
 
 stg_insertArrayzh( gcptr src, W_ idx, gcptr elemt )
 {
-    return ();
+    ccall barf("stg_insertArrayzh not implemented.");
 }
 stg_updateArrayzh( gcptr src, W_ idx, gcptr elemt )
 {
-    return ();
+    ccall barf("stg_updateArrayzh not implemented.");
 }
 stg_deleteArrayzh( gcptr src, W_ idx )
 {
-    return ();
+    ccall barf("stg_deleteArrayzh not implemented.");
 }
 
 stg_newArrayArrayzh ( W_ n /* words */ )
@@ -590,7 +590,6 @@ stg_insertSmallArrayzh( gcptr src, W_ idx, gcptr elemt )
 
     again: MAYBE_GC(again);
 
-    // ccall barf("argh");
     n = StgSmallMutArrPtrs_ptrs(src) + 1;
 
     words = BYTES_TO_WDS(SIZEOF_StgSmallMutArrPtrs) + n;



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/c045d93ab1d298b9cdb40e950445b9cec64fa37c

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/commit/c045d93ab1d298b9cdb40e950445b9cec64fa37c
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20200831/e312aac4/attachment.html>


More information about the ghc-commits mailing list