[Git][ghc/ghc][wip/az/ghc-9.0-anns] 72 commits: Bignum: add support for negative shifts (fix #18499)

Alan Zimmerman gitlab at gitlab.haskell.org
Thu Aug 20 15:30:46 UTC 2020



Alan Zimmerman pushed to branch wip/az/ghc-9.0-anns at Glasgow Haskell Compiler / GHC


Commits:
32496789 by Sylvain Henry at 2020-08-11T17:43:13+02:00
Bignum: add support for negative shifts (fix #18499)

shiftR/shiftL support negative arguments despite Haskell 2010 report
saying otherwise. We explicitly test for negative values which is bad
(it gets in the way of constant folding, etc.). Anyway, for consistency
we fix Bits instancesof Integer/Natural.

- - - - -
b4cccab3 by Sylvain Henry at 2020-08-11T17:48:05+02:00
Fix bug in Natural multiplication (fix #18509)

A bug was lingering in Natural multiplication (inverting two limbs)
despite QuickCheck tests used during the development leading to wrong
results (independently of the selected backend).

- - - - -
817f94f5 by Sylvain Henry at 2020-08-11T17:48:22+02:00
Bignum: fix powMod for gmp backend (#18515)

Also reenable integerPowMod test which had never been reenabled by
mistake.

- - - - -
eab2511e by Sylvain Henry at 2020-08-12T11:43:42+02:00
Bignum: add backward compat integer-gmp functions

Also enhance bigNatCheck# and isValidNatural test

- - - - -
3745bdb6 by Sylvain Henry at 2020-08-12T11:43:42+02:00
Bignum: add more BigNat compat functions in integer-gmp

- - - - -
7cf007cc by David Binder at 2020-08-13T18:22:38-04:00
Fix dead link to haskell prime discussion

- - - - -
205f168c by BinderDavid at 2020-08-13T18:22:38-04:00
Replace broken links to old haskell-prime site by working links to gitlab instance.
[skip ci]

- - - - -
29794212 by Daniel Gröber at 2020-08-13T18:22:38-04:00
Remove length field from FastString

- - - - -
f8804cd8 by Daniel Gröber at 2020-08-13T18:22:38-04:00
Use ShortByteString for FastString

There are multiple reasons we want this:

- Fewer allocations: ByteString has 3 fields, ShortByteString just has one.
- ByteString memory is pinned:
  - This can cause fragmentation issues (see for example #13110) but also
  - makes using FastStrings in compact regions impossible.

Metric Decrease:
    T5837
    T12150
    T12234
    T12425

- - - - -
5acdf506 by Daniel Gröber at 2020-08-13T18:22:38-04:00
Pass specialised utf8DecodeChar# to utf8DecodeLazy# for performance

Currently we're passing a indexWord8OffAddr# type function to
utf8DecodeLazy# which then passes it on to utf8DecodeChar#. By passing one
of utf8DecodeCharAddr# or utf8DecodeCharByteArray# instead we benefit from
the inlining and specialization already done for those.

- - - - -
a9b46ec3 by Daniel Gröber at 2020-08-13T18:22:38-04:00
Encoding: Add comment about tricky ForeignPtr lifetime

- - - - -
fcb9e94d by Daniel Gröber at 2020-08-13T18:22:38-04:00
Use IO constructor instead of `stToIO . ST`

- - - - -
44b28e97 by Daniel Gröber at 2020-08-13T18:22:38-04:00
Encoding: Remove redundant use of withForeignPtr

- - - - -
f0fe989d by Daniel Gröber at 2020-08-13T18:22:38-04:00
Encoding: Reformat utf8EncodeShortByteString to be more consistent

- - - - -
59cd5cd4 by Daniel Gröber at 2020-08-13T18:22:38-04:00
FastString: Reintroduce character count cache

Metric Increase:
    ManyConstructors

Metric Decrease:
    T4029

- - - - -
0f66e49e by Ben Gamari at 2020-08-13T18:22:38-04:00
get-win32-tarballs: Fix detection of missing tarballs

This fixes the error message given by configure when the user
attempts to configure without first download the win32 tarballs.

- - - - -
3ecac53c by Andreas Klebinger at 2020-08-13T18:22:39-04:00
Enable BangPatterns, ScopedTypeVariables for ghc and hadrian by default.

This is only for their respective codebases.

- - - - -
dbf77b79 by Sylvain Henry at 2020-08-13T18:22:39-04:00
Remove unused "ncg" flag

This flag has been removed in 066b369de2c6f7da03c88206288dca29ab061b31
in 2011.

- - - - -
4e22de2a by Sylvain Henry at 2020-08-13T18:22:39-04:00
Don't panic if the NCG isn't built (it is always built)

- - - - -
e27698ce by Sylvain Henry at 2020-08-13T18:22:39-04:00
Remove unused sGhcWithNativeCodeGen

- - - - -
666acbd4 by Sylvain Henry at 2020-08-13T18:22:39-04:00
Correctly test active backend

Previously we used a platform settings to detect if the native code
generator was used. This was wrong. We need to use the
`DynFlags.hscTarget` field instead.

- - - - -
ce5408c0 by Sylvain Henry at 2020-08-13T18:22:39-04:00
Replace ghcWithNativeCodeGen with a proper Backend datatype

* Represent backends with a `Backend` datatype in GHC.Driver.Backend

* Don't detect the default backend to use for the target platform at
  compile time in Hadrian/make but at runtime. It makes "Settings"
  simpler and it is a step toward making GHC multi-target.

* The latter change also fixes hadrian which has not been updated to
  take into account that the NCG now supports AIX and PPC64 (cf
  df26b95559fd467abc0a3a4151127c95cb5011b9 and
  d3c1dda60d0ec07fc7f593bfd83ec9457dfa7984)

* Also we don't treat iOS specifically anymore (cf
  cb4878ffd18a3c70f98bdbb413cd3c4d1f054e1f)

- - - - -
9751d499 by Tamar Christina at 2020-08-13T18:22:39-04:00
winio: restore console cp on exit

(cherry picked from commit cdd0ff16f20ce920c74f9128a1067cbe1bd378c2)

- - - - -
5438dcec by Tamar Christina at 2020-08-13T18:22:39-04:00
winio: change memory allocation strategy and fix double free errors.

(cherry picked from commit c1f4f81d3a439cd1a8128e4ab11c7caac7cc0ad8)

- - - - -
5544d17a by Stefan Schulze Frielinghaus at 2020-08-13T18:22:39-04:00
Require SMP support in order to build a threaded stage1

Fixes 18266

(cherry picked from commit fc0f6fbcd95f2dc69a8efabbee2d8a485c34cc47)

- - - - -
e66e281d by Matthias Andreas Benkard at 2020-08-13T18:22:39-04:00
Document loadFramework changes. (#18446)

Adds commentary on the rationale for the changes made in merge request
!3689.

(cherry picked from commit a7c4439a407ad85b76aab9301fda61e7c10183ff)

- - - - -
986063cf by Ben Gamari at 2020-08-13T18:22:39-04:00
rts/win32: Exit with EXIT_HEAPOVERFLOW if memory commit fails

Since switching to the two-step allocator, the `outofmem` test fails via
`osCommitMemory` failing to commit. However, this was previously exiting
with `EXIT_FAILURE`, rather than `EXIT_HEAPOVERFLOW`. I think the latter
is a more reasonable exit code for this case and matches the behavior on
POSIX platforms.

(cherry picked from commit da7269a4472856ba701d956a247599f721e9915e)

- - - - -
b2f8c6a7 by Ben Gamari at 2020-08-13T18:22:39-04:00
testsuite: Update win32 output for parseTree

(cherry picked from commit f153a1d0a3351ad4d94cef4cef8e63bab5b47008)

- - - - -
83a0649c by Ben Gamari at 2020-08-13T18:22:39-04:00
testsuite: Normalise WinIO error message differences

Previously the old Windows IO manager threw different errors than WinIO.
We now canonicalise these to the WinIO errors.

(cherry picked from commit e91672f0b7185bbafbe8ed1f2ae2cb775111f950)

- - - - -
97ac5b2a by Ben Gamari at 2020-08-13T18:22:39-04:00
gitlab-ci: Kill ssh-agent after pushing test metrics

Otherwise the Windows builds hang forever waiting for the process to
terminate.

(cherry picked from commit 9cbfe0868418a531da0872b0c477a15aa67f8861)

- - - - -
8f1154d3 by Tamar Christina at 2020-08-13T18:22:39-04:00
winio: remove dead argument to stg_newIOPortzh

(cherry picked from commit 8236925fc8cc2e6e3fed61a0676fa65270a4a538)

- - - - -
39c6fbae by Tamar Christina at 2020-08-13T18:22:39-04:00
winio: fix detection of tty terminals

(cherry picked from commit ce0a1d678fbc8efa5fd384fd0227b7b3dc97cadd)

- - - - -
b784c75a by Tamar Christina at 2020-08-13T18:22:40-04:00
winio: update codeowners

(cherry picked from commit 52685cf7c077c51e3719e3c4dd5ca8257a99c4ea)

- - - - -
8388567e by Ben Gamari at 2020-08-13T18:22:40-04:00
Drop 32-bit Windows support

As noted in #18487, we have reached the end of this road.

(cherry picked from commit aa054d32a8ff69c334293a0d6c9d11b83a236a96)

- - - - -
353521ab by Simon Peyton Jones at 2020-08-13T18:22:40-04:00
Eta-expand the Simplifier monad

This patch eta-expands the Simplifier's monad, using the method
explained in GHC.Core.Unify Note [The one-shot state monad trick].
It's part of the exta-expansion programme in #18202.

It's a tiny patch, but is worth a 1-2% reduction in bytes-allocated
by the compiler.  Here's the list, based on the compiler-performance
tests in perf/compiler:

                    Reduction in bytes allocated
   T10858(normal)      -0.7%
   T12425(optasm)      -1.3%
   T13056(optasm)      -1.8%
   T14683(normal)      -1.1%
   T15164(normal)      -1.3%
   T15630(normal)      -1.4%
   T17516(normal)      -2.3%
   T18282(normal)      -1.6%
   T18304(normal)      -0.8%
   T1969(normal)       -0.6%
   T4801(normal)       -0.8%
   T5321FD(normal)     -0.7%
   T5321Fun(normal)    -0.5%
   T5642(normal)       -0.9%
   T6048(optasm)       -1.1%
   T9020(optasm)       -2.7%
   T9233(normal)       -0.7%
   T9675(optasm)       -0.5%
   T9961(normal)       -2.9%
   WWRec(normal)       -1.2%

Metric Decrease:
    T12425
    T9020
    T9961

(cherry picked from commit 3d345c9680ab3d766ef43dd8389ccc1eaeca066c)

- - - - -
c0a3283a by Ben Gamari at 2020-08-13T18:22:40-04:00
gitlab-ci: Ensure that Hadrian jobs don't download artifacts

Previously the Hadrian jobs had the default dependencies, meaning that
they would download artifacts from all jobs of earlier stages. This is
unneccessary.

(cherry picked from commit 57aca6bba1c000f8542ce94e8b724b0334ff96d4)

- - - - -
e14ee26b by Ben Gamari at 2020-08-13T18:22:40-04:00
gitlab-ci: Bump bootstrap compiler to 8.8.4

Hopefully this will make the Windows jobs a bit more reliable.

(cherry picked from commit 0a815cea9fa11ce6ef22aec3525dd7a0df541daf)

- - - - -
cf9a6c17 by Simon Peyton Jones at 2020-08-13T18:22:40-04:00
This patch addresses the exponential blow-up in the simplifier.

Specifically:
  #13253 exponential inlining
  #10421 ditto
  #18140 strict constructors
  #18282 another nested-function call case

This patch makes one really significant changes: change the way that
mkDupableCont handles StrictArg.  The details are explained in
GHC.Core.Opt.Simplify Note [Duplicating StrictArg].

Specific changes

* In mkDupableCont, when making auxiliary bindings for the other arguments
  of a call, add extra plumbing so that we don't forget the demand on them.
  Otherwise we haev to wait for another round of strictness analysis. But
  actually all the info is to hand.  This change affects:
  - Make the strictness list in ArgInfo be [Demand] instead of [Bool],
    and rename it to ai_dmds.
  - Add as_dmd to ValArg
  - Simplify.makeTrivial takes a Demand
  - mkDupableContWithDmds takes a [Demand]

There are a number of other small changes

1. For Ids that are used at most once in each branch of a case, make
   the occurrence analyser record the total number of syntactic
   occurrences.  Previously we recorded just OneBranch or
   MultipleBranches.

   I thought this was going to be useful, but I ended up barely
   using it; see Note [Note [Suppress exponential blowup] in
   GHC.Core.Opt.Simplify.Utils

   Actual changes:
     * See the occ_n_br field of OneOcc.
     * postInlineUnconditionally

2. I found a small perf buglet in SetLevels; see the new
   function GHC.Core.Opt.SetLevels.hasFreeJoin

3. Remove the sc_cci field of StrictArg.  I found I could get
   its information from the sc_fun field instead.  Less to get
   wrong!

4. In ArgInfo, arrange that ai_dmds and ai_discs have a simpler
   invariant: they line up with the value arguments beyond ai_args
   This allowed a bit of nice refactoring; see isStrictArgInfo,
   lazyArgcontext, strictArgContext

There is virtually no difference in nofib. (The runtime numbers
are bogus -- I tried a few manually.)

        Program           Size    Allocs   Runtime   Elapsed  TotalMem
--------------------------------------------------------------------------------
            fft          +0.0%     -2.0%    -48.3%    -49.4%      0.0%
     multiplier          +0.0%     -2.2%    -50.3%    -50.9%      0.0%
--------------------------------------------------------------------------------
            Min          -0.4%     -2.2%    -59.2%    -60.4%      0.0%
            Max          +0.0%     +0.1%     +3.3%     +4.9%      0.0%
 Geometric Mean          +0.0%     -0.0%    -33.2%    -34.3%     -0.0%

Test T18282 is an existing example of these deeply-nested strict calls.
We get a big decrease in compile time (-85%) because so much less
inlining takes place.

Metric Decrease:
    T18282

(cherry picked from commit 0bd60059b0edfee9e8f66c6817257bbb946656cd)

- - - - -
6ba13945 by Sergei Trofimovich at 2020-08-13T18:22:40-04:00
ghc/mk: don't build gmp packages for BIGNUM_BACKEND=native

Before this change make-based `BIGNUM_BACKEND=native` build was failing as:

```
x86_64-pc-linux-gnu-gcc: error: libraries/ghc-bignum/gmp/objs/*.o: No such file or directory
```

This happens because ghc.mk was pulling in gmp-dependent
ghc-bignum library unconditionally. The change avoid building
ghc-bignum.

Bug: https://gitlab.haskell.org/ghc/ghc/-/issues/18437
Signed-off-by: Sergei Trofimovich <slyfox at gentoo.org>
(cherry picked from commit 39c89862161bf488a6aca9372cbb67690f436ce7)

- - - - -
59226e20 by Felix Wiemuth at 2020-08-13T18:22:40-04:00
Fix typo

(cherry picked from commit b9a880fce484d0a87bb794b9d2d8a73e54819011)

- - - - -
9166d4d6 by Simon Peyton Jones at 2020-08-13T18:22:40-04:00
Kill off sc_mult and as_mult fields

They are readily derivable from other fields, so this is more
efficient, and less error prone.

Fixes #18494

(cherry picked from commit bbc5191640761ca9773abc898c077363b7beb4e7)

- - - - -
505a9d68 by John Ericson at 2020-08-13T18:22:40-04:00
For `-fkeep-going` do not duplicate dependency edge code

We now compute the deps for `-fkeep-going` the same way that the
original graph calculates them, so the edges are correct. Upsweep really
ought to take the graph rather than a topological sort so we are never
recalculating anything, but at least things are recaluclated
consistently now.

(cherry picked from commit 6c68a84254d70280e2dc73485f361787a3503850)

- - - - -
bd365c1d by Simon Peyton Jones at 2020-08-13T18:22:40-04:00
Add two bangs to improve perf of flattening

This tiny patch improves the compile time of flatten-heavy
programs by 1-2%, by adding two bangs.

Addresses (somewhat) #18502

This reduces allocation by
   T9872b   -1.1%
   T9872d   -3.3%

   T5321Fun -0.2%
   T5631    -0.2%
   T5837    +0.1%
   T6048    +0.1%

Metric Decrease:
    T9872b
    T9872d

(cherry picked from commit 9f71f69714255165d0fdc2790a588487ff9439dc)

- - - - -
6653e139 by Sylvain Henry at 2020-08-13T18:22:40-04:00
Fix minimal imports dump for boot files (fix #18497)

(cherry picked from commit 7c274cd530cc42a26028050b75d56b3437e06ec1)

- - - - -
2c86713b by Leon Schoorl at 2020-08-13T18:22:41-04:00
Fix GHC_STAGE definition generated by make

Fixes #18070

GHC_STAGE is the stage of the compiler we're building, it should be 1,2(,3?).
But make was generating 0 and 1.

Hadrian does this correctly using a similar `+ 1`:
https://gitlab.haskell.org/ghc/ghc/-/blob/eb8115a8c4cbc842b66798480fefc7ab64d31931/hadrian/src/Rules/Generate.hs#L245

(cherry picked from commit f2d1accf67cb6e1dab6b2c78fef4b64526c31a4a)

- - - - -
36d8cd6f by Niklas Hambüchen at 2020-08-13T18:22:41-04:00
hadrian: Fix running stage0/bin/ghc with wrong package DB. Fixes #17468.

In the invocation of `cabal configure`, `--ghc-pkg-option=--global-package-db`
was already given correctly to tell `stage0/bin/ghc-pkg` that it should use
the package DB in `stage1/`.

However, `ghc` needs to be given this information as well, not only `ghc-pkg`!
Until now that was not the case; the package DB in `stage0` was given to
`ghc` instead.
This was wrong, because there is no binary compatibility guarantee that says
that the `stage0` DB's `package.cache` (which is written by the
stage0 == system-provided ghc-pkg) can be deserialised by the `ghc-pkg`
from the source code tree.

As a result, when trying to add fields to `InstalledPackageInfo` that get
serialised into / deserialised from the `package.cache`, errors like

    _build/stage0/lib/package.conf.d/package.cache: GHC.PackageDb.readPackageDb: inappropriate type (Not a valid Unicode code point!)

would appear. This was because the `stage0/bin/ghc would try to
deserialise the newly added fields from
`_build/stage0/lib/package.conf.d/package.cache`, but they were not in there
because the system `ghc-pkg` doesn't know about them and thus didn't write them
there.
It would try to do that because any GHC by default tries to read the global
package db in `../lib/package.conf.d/package.cache`.
For `stage0/bin/ghc` that *can never work* as explained above, so we
must disable this default via `-no-global-package-db` and give it the
correct package DB explicitly.

This is the same problem as #16534, and the same fix as in MR !780
(but in another context; that one was for developers trying out the
`stage0/bin/ghc` == `_build/ghc-stage1` interactively, while this fix
is for a `cabal configure` invocation).

I also noticed that the fix for #16534 forgot to pass `-no-global-package-db`,
and have fixed that in this commit as well.
It only worked until now because nobody tried to add a new ghc-pkg `.conf`
field since the introduction of Hadrian.

(cherry picked from commit 947206f478d4eef641dfc58cb4c13471a23260c3)

- - - - -
01534bf9 by Krzysztof Gogolewski at 2020-08-13T18:22:48-04:00
Rename Core.Opt.Driver -> Core.Opt.Pipeline

Closes #18504.

(cherry picked from commit 5e12cd1733b581f48a5873b12971b6974778eabb)

- - - - -
20a45d0c by Ben Gamari at 2020-08-13T18:22:48-04:00
Revert "iserv: Don't pass --export-dynamic on FreeBSD"

This reverts commit 2290eb02cf95e9cfffcb15fc9c593d5ef79c75d9.

(cherry picked from commit 2bff2f87e43985e02bdde8c6fa39279df86cb617)

- - - - -
2911d640 by Ben Gamari at 2020-08-13T18:22:48-04:00
Refactor handling of object merging

Previously to merge a set of object files we would invoke the linker as
usual, adding -r to the command-line. However, this can result in
non-sensical command-lines which causes lld to balk (#17962).

To avoid this we introduce a new tool setting into GHC, -pgmlm, which is
the linker which we use to merge object files.

(cherry picked from commit 53ce0db5a06598c88c6b8cb32043b878e7083dd4)

- - - - -
cb3e202a by Ryan Scott at 2020-08-13T18:22:48-04:00
Make CodeQ and TExpQ levity polymorphic

The patch is quite straightforward. The only tricky part is that
`Language.Haskell.TH.Lib.Internal` now must be `Trustworthy` instead
of `Safe` due to the `GHC.Exts` import (in order to import `TYPE`).

Since `CodeQ` has yet to appear in any released version of
`template-haskell`, I didn't bother mentioning the change to `CodeQ`
in the `template-haskell` release notes.

Fixes #18521.

(cherry picked from commit fbcb886d503dd7aaebc4c40e59615068b3fd0bd7)

- - - - -
bd506bd6 by Vladislav Zavialov at 2020-08-13T18:22:48-04:00
Improve NegativeLiterals (#18022, GHC Proposal #344)

Before this patch, NegativeLiterals used to parse x-1 as x (-1).

This may not be what the user expects, and now it is fixed:
x-1 is parsed as (-) x 1.

We achieve this by the following requirement:

  * When lexing a negative literal,
    it must not be preceded by a 'closing token'.

This also applies to unboxed literals, e.g. -1#.

See GHC Proposal #229 for the definition of a closing token.

A nice consequence of this change is that -XNegativeLiterals becomes a
subset of -XLexicalNegation. In other words, enabling both of those
extensions has the same effect as enabling -XLexicalNegation alone.

(cherry picked from commit aee45d9ea8c6cf4ebad4d5c732748923c7865cbe)

- - - - -
bc186461 by Takenobu Tani at 2020-08-13T18:22:48-04:00
users-guide: Rename 8.12 to 9.0

GHC 8.12.1 has been renamed to GHC 9.0.1.

See also:
  https://mail.haskell.org/pipermail/ghc-devs/2020-July/019083.html

[skip ci]

(cherry picked from commit 9570c21295a2b4a1d1e40939869124f0b9b9bf91)

- - - - -
77653d5c by Ben Gamari at 2020-08-13T18:22:48-04:00
cmm: Clean up Notes a bit

(cherry picked from commit 5f03606319f745b10e9918c76a47426b293f0bf9)

- - - - -
47de152f by Ben Gamari at 2020-08-13T18:22:48-04:00
CmmLint: Check foreign call argument register invariant

As mentioned in Note [Register parameter passing] the arguments of
foreign calls cannot refer to caller-saved registers.

(cherry picked from commit 6402c1240d5bd768b8fe8b4368413932bedbe107)

- - - - -
e64ac078 by Ben Gamari at 2020-08-13T18:22:48-04:00
nativeGen: One approach to fix #18527

Previously the code generator could produce corrupt C call sequences due
to register overlap between MachOp lowerings and the platform's calling
convention. We fix this using a hack described in Note [Evaluate C-call
arguments before placing in destination registers].

(cherry picked from commit 15b36de030ecdd60897bc7a6a02bdeabd0825be4)

- - - - -
24c230ce by Ben Gamari at 2020-08-13T18:22:48-04:00
testsuite: Add test for #18527

(cherry picked from commit 3847ae0ccf67bddf73304a39f5320c3ba285aa48)

- - - - -
ee2ed876 by Ben Gamari at 2020-08-13T18:22:48-04:00
testsuite: Fix prog001

Previously it failed as the `ghc` package was not visible.

(cherry picked from commit dd51d53be42114c105b5ab15fcbdb387526b1c17)

- - - - -
b4c33250 by Alan Zimmerman at 2020-08-13T18:22:48-04:00
ApiAnnotations; tweaks for ghc-exactprint update

Remove unused ApiAnns, add one for linear arrow.

Include API Annotations for trailing comma in export list.

(cherry picked from commit e4f1b73ad9f292a6bbeb21fee44b0ba1a7f3c33b)

- - - - -
cb39cfdc by Ben Gamari at 2020-08-13T18:22:48-04:00
configure: Fix double-negation in ld merge-objects check

We want to only run the check if ld is gold.

Fixes the fix to #17962.

(cherry picked from commit 8a665db6174eaedbbae925c0ccb4c22b3f29bcaf)

- - - - -
b221b571 by Alex Biehl at 2020-08-13T18:22:48-04:00
Hardcode RTS includes to cope with unregistered builds

(cherry picked from commit ef2ae81a394df573510b12b7e11bba0c931249d8)

- - - - -
c15fb71b by Ben Gamari at 2020-08-13T18:22:48-04:00
testsuite: Specify metrics collected by T17516

Previously it collected everything, including "max bytes used". This is
problematic since the test makes no attempt to control for deviations in
GC timing, resulting in high variability. Fix this by only collecting
"bytes allocated".

(cherry picked from commit f1088b3f31ceddf918a319c97557fb1f08a9a387)

- - - - -
3bda53ad by Ben Gamari at 2020-08-13T20:44:39-04:00
testsuite: Allow baseline commit to be set explicitly

(cherry picked from commit bbde6ea0ce80a154735f1302251d073a56606c20)

- - - - -
ce32390c by Ben Gamari at 2020-08-15T12:19:32-04:00
gitlab-ci: Use MR base commit as performance baseline

(cherry picked from commit 4b91e5edf64363eff7d087731c2806464033447c)

Metric Decrease:
  T13056
  T18304
  T1969
  T9233

- - - - -
57fd3ff0 by Ben Gamari at 2020-08-16T12:18:11-04:00
Allow unsaturated runRW# applications

Previously we had a very aggressive Core Lint check which caught
unsaturated applications of runRW#. However, there is nothing
wrong with such applications and they may naturally arise in desugared
Core. For instance, the desugared Core of Data.Primitive.Array.runArray#
from the `primitive` package contains:

    case ($) (runRW# @_ @_) (\s -> ...) of ...

In this case it's almost certain that ($) will be inlined, turning the
application into a saturated application. However, even if this weren't
the case there isn't a problem: CorePrep (after deleting an unnecessary
case) can simply generate code in its usual way, resulting in a call to
the Haskell definition of runRW#.

Fixes #18291.

(cherry picked from commit 2f0bae734e2dc8737fbbb8465de7ded89c1121b6)

- - - - -
0af2db18 by Ben Gamari at 2020-08-16T12:18:19-04:00
testsuite: Add test for #18291

(cherry picked from commit 6c7785f8e17a43a2578366134f74fd1989077b73)

- - - - -
614ac76d by Ben Gamari at 2020-08-17T15:14:35-04:00
Clean up TBDs in changelog

(cherry picked from commit 4f334120c8e9cc4aefcbf11d99f169f648af9fde)

- - - - -
1a54d708 by Ben Gamari at 2020-08-17T15:14:35-04:00
Bump bytestring submodule

- - - - -
20e19811 by Ben Gamari at 2020-08-17T15:14:35-04:00
Bump binary submodule

- - - - -
8c7e8e1c by Ben Gamari at 2020-08-17T20:09:30+00:00
Bump Cabal submodule

- - - - -
93cfed07 by Alan Zimmerman at 2020-08-20T15:48:16+01:00
Include API Annotations for trailing comma in export list

- - - - -
3ccc80ee by Alan Zimmerman at 2020-08-20T15:48:16+01:00
Api Annotations : Adjust SrsSpans for prefix bang (!).

And prefix ~

- - - - -
f4ad068c by Alan Zimmerman at 2020-08-20T15:48:16+01:00
ApiAnnotations: Fix parser for new GHC 9.0 features

- - - - -


30 changed files:

- .gitlab-ci.yml
- .gitlab/ci.sh
- .gitlab/test-metrics.sh
- CODEOWNERS
- aclocal.m4
- compiler/GHC.hs
- compiler/GHC/Cmm/CLabel.hs
- compiler/GHC/Cmm/Lint.hs
- compiler/GHC/Cmm/MachOp.hs
- compiler/GHC/Cmm/Node.hs
- compiler/GHC/Cmm/Sink.hs
- compiler/GHC/CmmToAsm/X86/CodeGen.hs
- compiler/GHC/Core/Coercion.hs
- compiler/GHC/Core/DataCon.hs
- compiler/GHC/Core/Lint.hs
- compiler/GHC/Core/Opt/OccurAnal.hs
- compiler/GHC/Core/Opt/Driver.hs → compiler/GHC/Core/Opt/Pipeline.hs
- compiler/GHC/Core/Opt/SetLevels.hs
- compiler/GHC/Core/Opt/Simplify.hs
- compiler/GHC/Core/Opt/Simplify/Monad.hs
- compiler/GHC/Core/Opt/Simplify/Utils.hs
- compiler/GHC/Core/SimpleOpt.hs
- compiler/GHC/CoreToStg/Prep.hs
- compiler/GHC/Data/FastString.hs
- compiler/GHC/Data/StringBuffer.hs
- + compiler/GHC/Driver/Backend.hs
- compiler/GHC/Driver/CodeOutput.hs
- compiler/GHC/Driver/Main.hs
- compiler/GHC/Driver/Make.hs
- compiler/GHC/Driver/Pipeline.hs


The diff was not included because it is too large.


View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/d88bc94affafe24c3af7cb5f1fe095d1b9e676bf...f4ad068cf5784bcbb3eebe65d5fdcd81b9ea6540

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/d88bc94affafe24c3af7cb5f1fe095d1b9e676bf...f4ad068cf5784bcbb3eebe65d5fdcd81b9ea6540
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20200820/a4b43f38/attachment-0001.html>


More information about the ghc-commits mailing list