[Git][ghc/ghc][wip/marge_bot_batch_merge_job] 14 commits: Improve comments around injectivity checks

Wed May 29 02:54:43 UTC 2019

 Marge Bot pushed to branch wip/marge_bot_batch_merge_job at Glasgow Haskell Compiler / GHC

Commits:
9334467f by Richard Eisenberg at 2019-05-28T04:24:50Z
Improve comments around injectivity checks

- - - - -
e52a2bb1 by Krzysztof Gogolewski at 2019-05-29T02:54:24Z
Handle hs-boot files in -Wmissing-home-modules (#16551)

- - - - -
d8c58b13 by Alp Mestanogullari at 2019-05-29T02:54:26Z
testsuite: introduce 'static_stats' tests

They are a particular type of perf tests. This patch introduces a
'stats_files_dir' configuration field in the testsuite driver where all
haddock timing files (and possibly others in the future) are assumed to live.
We also change both the Make and Hadrian build systems to pass respectively
$(TOP)/testsuite/tests/perf/haddock/ and
<build root>/stage1/haddock-timing-files/ as the value of that new
configuration field, and to generate the timing files in those directories
in the first place while generating documentation with haddock.

This new test type can be seen as one dedicated to examining stats files that
are generated while building a GHC distribution. This also lets us get rid of
the 'extra_files' directives in the all.T entries for haddock.base,
haddock.Cabal and haddock.compiler.

- - - - -
3c002da4 by Kevin Buhr at 2019-05-29T02:54:27Z
Add test for old issue displaying unboxed tuples in error messages (#502)

- - - - -
f8941c98 by Krzysztof Gogolewski at 2019-05-29T02:54:27Z
Fix missing unboxed tuple RuntimeReps (#16565)

Unboxed tuples and sums take extra RuntimeRep arguments,
which must be manually passed in a few places.
This was not done in deSugar/Check.

This error was hidden because zipping functions in TyCoRep
ignored lists with mismatching length. This is now fixed;
the lengths are now checked by calling zipEqual.

As suggested in #16565, I moved checking for isTyVar and
isCoVar to zipTyEnv and zipCoEnv.

- - - - -
85cf791b by Nathan Collins at 2019-05-29T02:54:28Z
Don't lose parentheses in show SomeAsyncException
- - - - -
d6a8176a by Nathan Collins at 2019-05-29T02:54:29Z
Improve ThreadId Show instance

By making it include parens when a derived instance would. For example, this changes the (hypothetical) code `show (Just (ThreadId 3))` to produce `"Just (ThreadId 3)"` instead of the current `"Just ThreadId 3"`.
- - - - -
81999acc by Nathan Collins at 2019-05-29T02:54:29Z
Add missing import
- - - - -
50e4fb37 by Daniel Gröber at 2019-05-29T02:54:30Z
Add hPutStringBuffer utility

- - - - -
884ccec8 by Daniel Gröber at 2019-05-29T02:54:30Z
Allow using tagetContents for modules needing preprocessing

This allows GHC API clients, most notably tooling such as
Haskell-IDE-Engine, to pass unsaved files to GHC more easily.

Currently when targetContents is used but the module requires preprocessing
'preprocessFile' simply throws an error because the pipeline does not
support passing a buffer.

This change extends `runPipeline` to allow passing the input buffer into
the pipeline. Before proceeding with the actual pipeline loop the input
buffer is immediately written out to a new tempfile.

I briefly considered refactoring the pipeline at large to pass around
in-memory buffers instead of files, but this seems needlessly complicated
since no pipeline stages other than Hsc could really support this at the
moment.

- - - - -
c7c42de0 by Daniel Gröber at 2019-05-29T02:54:31Z
downsweep: Allow TargetFile not to exist when a buffer is given

Currently 'getRootSummary' will fail with an exception if a 'TargetFile' is
given but it does not exist even if an input buffer is passed along for
this target.

In this case it is not necessary for the file to exist since the buffer
will be used as input for the compilation pipeline instead of the file
anyways.

- - - - -
e97db80e by Ömer Sinan Ağacan at 2019-05-29T02:54:34Z
CNF.c: Move debug functions behind ifdef

- - - - -
f009fb02 by Vladislav Zavialov at 2019-05-29T02:54:35Z
tcMatchesFun s/rho/sigma #16692

- - - - -
0063a785 by Josh Meredith at 2019-05-29T02:54:36Z
Provide details in `plusSimplCount` errors

- - - - -

30 changed files:

- compiler/deSugar/Check.hs
- compiler/main/DriverPipeline.hs
- compiler/main/GhcMake.hs
- compiler/main/HscTypes.hs
- compiler/simplCore/CoreMonad.hs
- compiler/typecheck/FamInst.hs
- compiler/typecheck/TcMatches.hs
- compiler/typecheck/TcMatches.hs-boot
- compiler/typecheck/TcValidity.hs
- compiler/types/FamInstEnv.hs
- compiler/types/TyCoRep.hs
- compiler/types/TyCon.hs
- compiler/utils/StringBuffer.hs
- compiler/utils/Util.hs
- hadrian/src/Context.hs
- hadrian/src/Context/Path.hs
- hadrian/src/Rules/Documentation.hs
- hadrian/src/Settings/Builders/Haddock.hs
- hadrian/src/Settings/Builders/RunTest.hs
- libraries/base/GHC/Conc/Sync.hs
- libraries/base/GHC/IO/Exception.hs
- rts/sm/CNF.c
- rules/haddock.mk
- testsuite/driver/testglobals.py
- testsuite/driver/testlib.py
- testsuite/mk/test.mk
- + testsuite/tests/ghc-api/target-contents/TargetContents.hs
- + testsuite/tests/ghc-api/target-contents/TargetContents.stderr
- + testsuite/tests/ghc-api/target-contents/all.T
- testsuite/tests/perf/haddock/all.T

The diff was not included because it is too large.

View it on GitLab: https://gitlab.haskell.org/ghc/ghc/compare/0ccb300996aefb029f5f093f05ffde1ecbd70bf6...0063a7852b74c1b73f3f2f2bf34cdd1c7be337b0

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/compare/0ccb300996aefb029f5f093f05ffde1ecbd70bf6...0063a7852b74c1b73f3f2f2bf34cdd1c7be337b0
You're receiving this email because of your account on gitlab.haskell.org.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20190528/ab31448d/attachment.html>