[Git][ghc/ghc][wip/14548] 11 commits: Check for duplicate variables in associated default equations

Marge Bot gitlab at gitlab.haskell.org
Wed May 8 20:05:56 UTC 2019



 Marge Bot pushed to branch wip/14548 at Glasgow Haskell Compiler / GHC


Commits:
78a5c4ce by Ryan Scott at 2019-05-07T21:03:04Z
Check for duplicate variables in associated default equations

A follow-up to !696's, which attempted to clean up the error messages
for ill formed associated type family default equations. The previous
attempt, !696, forgot to account for the possibility of duplicate
kind variable arguments, as in the following example:

```hs
class C (a :: j) where
  type T (a :: j) (b :: k)
  type T (a :: k) (b :: k) = k
```

This patch addresses this shortcoming by adding an additional check
for this. Fixes #13971 (hopefully for good this time).

- - - - -
f58ea556 by Kevin Buhr at 2019-05-07T21:09:13Z
Add regression test for old typechecking issue #505

- - - - -
786e665b by Ryan Scott at 2019-05-08T05:55:45Z
Fix #16603 by documenting some important changes in changelogs

This addresses some glaring omissions from
`libraries/base/changelog.md` and
`docs/users_guide/8.8.1-notes.rst`, fixing #16603 in the process.

- - - - -
0eeb4cfa by Ryan Scott at 2019-05-08T06:01:54Z
Fix #16632 by using the correct SrcSpan in checkTyClHdr

`checkTyClHdr`'s case for `HsTyVar` was grabbing the wrong `SrcSpan`,
which lead to error messages pointing to the wrong location. Easily
fixed.

- - - - -
ed5f858b by Shayne Fletcher at 2019-05-08T19:29:01Z
Implement ImportQualifiedPost

- - - - -
d9bdff60 by Kevin Buhr at 2019-05-08T19:35:13Z
stg_floatToWord32zh: zero-extend the Word32 (#16617)

The primop stgFloatToWord32 was sign-extending the 32-bit word, resulting
in weird negative Word32s.  Zero-extend them instead.

Closes #16617.

- - - - -
9a3acac9 by Ömer Sinan Ağacan at 2019-05-08T19:41:17Z
Print PAP object address in stg_PAP_info entry code

Continuation to ce23451c

- - - - -
4c86187c by Richard Eisenberg at 2019-05-08T19:47:33Z
Regression test for #16627.

test: typecheck/should_fail/T16627

- - - - -
93f34bbd by John Ericson at 2019-05-08T19:53:40Z
Purge TargetPlatform_NAME and cTargetPlatformString

- - - - -
9d9af0ee by Kevin Buhr at 2019-05-08T19:59:46Z
Add regression test for old issue #507

- - - - -
396e01b4 by Vladislav Zavialov at 2019-05-08T20:05:52Z
Add a regression test for #14548

- - - - -


30 changed files:

- compiler/ghc.mk
- compiler/hsSyn/HsImpExp.hs
- compiler/main/DynFlags.hs
- compiler/main/HeaderInfo.hs
- compiler/main/HscStats.hs
- compiler/main/SysTools.hs
- compiler/parser/Lexer.x
- compiler/parser/Parser.y
- compiler/parser/RdrHsSyn.hs
- compiler/rename/RnNames.hs
- compiler/typecheck/TcRnDriver.hs
- compiler/typecheck/TcTyClsDecls.hs
- compiler/utils/Panic.hs
- docs/users_guide/8.8.1-notes.rst
- docs/users_guide/glasgow_exts.rst
- ghc/GHCi/UI.hs
- hadrian/src/Rules/Generate.hs
- includes/Cmm.h
- includes/ghc.mk
- libraries/base/cbits/CastFloatWord.cmm
- libraries/base/changelog.md
- libraries/ghc-boot-th/GHC/LanguageExtensions/Type.hs
- rts/Apply.cmm
- + testsuite/tests/codeGen/should_run/T16617.hs
- + testsuite/tests/codeGen/should_run/T16617.stdout
- testsuite/tests/codeGen/should_run/all.T
- testsuite/tests/driver/T4437.hs
- + testsuite/tests/ghci/should_run/T507.script
- + testsuite/tests/ghci/should_run/T507.stdout
- testsuite/tests/ghci/should_run/all.T


The diff was not included because it is too large.


View it on GitLab: https://gitlab.haskell.org/ghc/ghc/compare/48a6cf0fdc169ec3836345b08ef568b7d08996cf...396e01b472bba36530e7eb065b82d311f0da7880

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/compare/48a6cf0fdc169ec3836345b08ef568b7d08996cf...396e01b472bba36530e7eb065b82d311f0da7880
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20190508/81bd3d4a/attachment.html>


More information about the ghc-commits mailing list