[commit: ghc] wip/revert-atomic-writes: Revert "compiler: Write .o files atomically. See #14533" (3533d49)

git at git.haskell.org git at git.haskell.org
Sun Mar 3 19:56:14 UTC 2019


Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/revert-atomic-writes
Link       : http://ghc.haskell.org/trac/ghc/changeset/3533d4984794bf32cc3ab25c622bd4c0df9e6c25/ghc

>---------------------------------------------------------------

commit 3533d4984794bf32cc3ab25c622bd4c0df9e6c25
Author: Ben Gamari <ben at smart-cactus.org>
Date:   Sun Mar 3 00:16:08 2019 -0500

    Revert "compiler: Write .o files atomically. See #14533"
    
    This reverts commit 0e2d300a59b1b5c167d2e7d99a448c8663ba6d7d.


>---------------------------------------------------------------

3533d4984794bf32cc3ab25c622bd4c0df9e6c25
 compiler/main/DriverPipeline.hs | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/compiler/main/DriverPipeline.hs b/compiler/main/DriverPipeline.hs
index 3f59ed3..5fe2362 100644
--- a/compiler/main/DriverPipeline.hs
+++ b/compiler/main/DriverPipeline.hs
@@ -1375,12 +1375,7 @@ runPhase (RealPhase (As with_cpp)) input_fn dflags
                           ])
 
         liftIO $ debugTraceMsg dflags 4 (text "Running the assembler")
-
-        -- Atomic write by writing to temp file and then renaming
-        let temp_output_fn = output_fn <.> "tmp"
-        runAssembler input_fn temp_output_fn
-        liftIO $ renameFile temp_output_fn output_fn
-
+        runAssembler input_fn output_fn
         return (RealPhase next_phase, output_fn)
 
 



More information about the ghc-commits mailing list