[commit: ghc] wip/heapprof001-fragile: Fix parsing of expected performance changes for tests with non-alpha characters. (b1c7ffa)

git at git.haskell.org git at git.haskell.org
Sat Mar 2 14:52:04 UTC 2019


Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/heapprof001-fragile
Link       : http://ghc.haskell.org/trac/ghc/changeset/b1c7ffafc64c5e04fe59e1c38fe86693de3498aa/ghc

>---------------------------------------------------------------

commit b1c7ffafc64c5e04fe59e1c38fe86693de3498aa
Author: David Eichmann <EichmannD at gmail.com>
Date:   Wed Feb 27 18:35:15 2019 +0000

    Fix parsing of expected performance changes for tests with non-alpha characters.
    
    Python's split() function is used to split on all white space.


>---------------------------------------------------------------

b1c7ffafc64c5e04fe59e1c38fe86693de3498aa
 testsuite/driver/perf_notes.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testsuite/driver/perf_notes.py b/testsuite/driver/perf_notes.py
index 2b48353..9362e46 100644
--- a/testsuite/driver/perf_notes.py
+++ b/testsuite/driver/perf_notes.py
@@ -140,7 +140,7 @@ def parse_allowed_perf_changes(commitMsg):
     matches = re.findall(exp, commitMsg, re.M)
     changes = {}
     for (direction, metrics_str, opts_str, tests_str) in matches:
-        tests = re.findall(r"(\w+)", tests_str)
+        tests = tests_str.split()
         for test in tests:
             changes.setdefault(test, []).append({
                 'direction': direction,



More information about the ghc-commits mailing list