[Git][ghc/ghc][wip/junit-fixes] 8 commits: ghci: Don't rely on resolution of System.IO to base module

Ben Gamari gitlab at gitlab.haskell.org
Sun Jun 23 17:33:06 UTC 2019



Ben Gamari pushed to branch wip/junit-fixes at Glasgow Haskell Compiler / GHC


Commits:
655c6e26 by Ben Gamari at 2019-06-22T14:06:05Z
ghci: Don't rely on resolution of System.IO to base module

Previously we would hackily evaluate a textual code snippet to compute
actions to disable I/O buffering and flush the stdout/stderr handles.
This broke in a number of ways (#15336, #16563).

Instead we now ship a module (`GHC.GHCi.Helpers`) with `base` containing
the needed actions. We can then easily refer to these via `Orig` names.

- - - - -
8f8fc31b by Ben Gamari at 2019-06-22T14:06:05Z
testsuite: Add test for #16563

- - - - -
22e721c1 by Ben Gamari at 2019-06-22T14:06:05Z
testsuite: Mark T5611 as broken in ghci way

As described in #16845.

- - - - -
b0d6bf2a by Ben Gamari at 2019-06-22T14:06:05Z
rts: Reset STATIC_LINK field of reverted CAFs

When we revert a CAF we must reset the STATIC_LINK field lest the GC
might ignore the CAF (e.g. as it carries the STATIC_FLAG_LIST flag) and
will consequently overlook references to object code that we are trying
to unload. This would result in the reachable object code being
unloaded. See Note [CAF lists] and Note [STATIC_LINK fields].

This fixes #16842.

Idea-due-to: Phuong Trinh <lolotp at fb.com>

- - - - -
1f2fff89 by Ben Gamari at 2019-06-22T14:06:05Z
testsuite: Add caf_crash testcase

- - - - -
aa9062e2 by Ben Gamari at 2019-06-23T17:33:00Z
testsuite: A major revamp of the driver

This tries to put the testsuite driver into a slightly more maintainable
condition:

* Add type annotations where easily done
* Use pathlib.Path instead of str paths
* Make it pass the mypy typechecker

- - - - -
6934d2a5 by Ben Gamari at 2019-06-23T17:33:00Z
testsuite: Fix a few issues in JUnit output

 * Make it pass mypy
 * Fix a typo in test name field
 * Report more stderr output
 * Report stdout output

- - - - -
797f934d by Ben Gamari at 2019-06-23T17:33:00Z
gitlab-ci: Add testsuite typechecking lint

- - - - -


30 changed files:

- .gitlab-ci.yml
- compiler/prelude/PrelNames.hs
- ghc/GHCi/UI/Monad.hs
- + libraries/base/GHC/GHCi/Helpers.hs
- libraries/base/base.cabal
- rts/sm/GCAux.c
- testsuite/driver/junit.py
- + testsuite/driver/my_typing.py
- testsuite/driver/perf_notes.py
- testsuite/driver/runtests.py
- testsuite/driver/testglobals.py
- testsuite/driver/testlib.py
- testsuite/driver/testutil.py
- testsuite/tests/concurrent/should_run/all.T
- testsuite/tests/ghci.debugger/scripts/break006.stdout
- testsuite/tests/ghci.debugger/scripts/break013.stdout
- testsuite/tests/ghci.debugger/scripts/hist001.stdout
- testsuite/tests/ghci.debugger/scripts/hist002.stdout
- + testsuite/tests/ghci/caf_crash/A.hs
- + testsuite/tests/ghci/caf_crash/B.hs
- + testsuite/tests/ghci/caf_crash/D.hs
- + testsuite/tests/ghci/caf_crash/all.T
- + testsuite/tests/ghci/caf_crash/caf_crash.script
- + testsuite/tests/ghci/caf_crash/caf_crash.stdout
- + testsuite/tests/ghci/scripts/T16563.script
- + testsuite/tests/ghci/scripts/T16563.stdout
- testsuite/tests/ghci/scripts/T4175.stdout
- testsuite/tests/ghci/scripts/T7627.stdout
- testsuite/tests/ghci/scripts/T8469.stdout
- testsuite/tests/ghci/scripts/all.T


The diff was not included because it is too large.


View it on GitLab: https://gitlab.haskell.org/ghc/ghc/compare/3486a0ffe69cc113707d6e098b1b3f6a0f60140d...797f934d486766c84a99b805e7bbf7470fbe665f

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/compare/3486a0ffe69cc113707d6e098b1b3f6a0f60140d...797f934d486766c84a99b805e7bbf7470fbe665f
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20190623/3f04cd88/attachment.html>


More information about the ghc-commits mailing list