[Git][ghc/ghc][wip/marge_bot_batch_merge_job] 10 commits: Properly trim IdInfos of DFunIds and PatSyns in TidyPgm

Wed Jun 19 18:43:36 UTC 2019

 Marge Bot pushed to branch wip/marge_bot_batch_merge_job at Glasgow Haskell Compiler / GHC

Commits:
e66a86ca by Ömer Sinan Ağacan at 2019-06-19T18:43:28Z
Properly trim IdInfos of DFunIds and PatSyns in TidyPgm

Not doing this right caused #16608. We now properly trim IdInfos of
DFunIds and PatSyns.

Some further refactoring done by SPJ.

Two regression tests T16608_1 and T16608_2 added.

Fixes #16608

- - - - -
25b13a47 by Roland Senn at 2019-06-19T18:43:30Z
Fix #1620: ModBreaks.modBreaks_array not initialised

After a :cd command and after setting some package flags,
GHCi unloads all loaded modules by resetting the list of targets.

This patch deletes eventually defined debugger breakpoints, before GHCi resets the target list.

The common code is factored out into the new function clearAllTargets.

- - - - -
c0a981aa by Simon Peyton Jones at 2019-06-19T18:43:31Z
Fix two places that failed the substitution invariant

The substition invariant relies on keeping the in-scope
set in sync, and we weren't always doing so, which means that
a DEBUG compiler crashes sometimes with an assertion failure

This patch fixes a couple more cases.  Still not validate
clean (with -DEEBUG) but closer!

- - - - -
c7a8e460 by Simon Peyton Jones at 2019-06-19T18:43:31Z
Fix typechecking of partial type signatures

Partial type sigs had grown hair.  tcHsParialSigType was
doing lots of unnecessary work, and tcInstSig was cloning it
unnecessarily -- and the result didn't even work: #16728.

This patch cleans it all up, described by TcHsType
  Note [Checking parital type signatures]

I basically just deleted code... but very carefully!

Some refactoring along the way

* Distinguish more explicintly between "anonymous" wildcards "_"
  and "named" wildcards "_a".  I changed the names of a number
  of functions to make this distinction much more apparent.

The patch also revealed that the code in `TcExpr`
that implements the special typing rule for `($)` was wrong.
It called `getRuntimeRep` in a situation where where was no
particular reason to suppose that the thing had kind `TYPE r`.

This caused a crash in typecheck/should_run/T10846.

The fix was easy, and actually simplifies the code in `TcExpr`
quite a bit.  Hooray.

- - - - -
b7ae79e6 by Simon Peyton Jones at 2019-06-19T18:43:31Z
Comments and tiny refactor

* Added Note [Quantified varaibles in partial type signatures]
  in TcRnTypes

* Kill dVarSetElemsWellScoped; it was only called in
  one function, quantifyTyVars.  I inlined it because it
  was only scopedSort . dVarSetElems

* Kill Type.tyCoVarsOfBindersWellScoped, never called.

- - - - -
b70640c0 by John Ericson at 2019-06-19T18:43:32Z
Move 'Platform' to ghc-boot

ghc-pkg needs to be aware of platforms so it can figure out which
subdire within the user package db to use. This is admittedly
roundabout, but maybe Cabal could use the same notion of a platform as
GHC to good affect too.

- - - - -
904235ed by John Ericson at 2019-06-19T18:43:32Z
Add 'stringEncodeArch' and 'stringEncodeOS' to GHC.Platform

- - - - -
2e581f36 by John Ericson at 2019-06-19T18:43:32Z
ghc-pkg needs settings file to un-hardcode target platform

This matches GHC itself getting the target platform from there.

- - - - -
4da83fe9 by Ben Gamari at 2019-06-19T18:43:33Z
users-guide: Fix a variety of broken links and syntax

- - - - -
4161ed66 by Ben Gamari at 2019-06-19T18:43:33Z
users-guide: Update -Wsafe description for #16689

We no longer emit a warning when a safe module is explicitly declared as
such.

- - - - -

30 changed files:

- compiler/basicTypes/Literal.hs
- compiler/basicTypes/PatSyn.hs
- compiler/cmm/CLabel.hs
- compiler/cmm/CmmBuildInfoTables.hs
- compiler/cmm/CmmCallConv.hs
- compiler/cmm/CmmInfo.hs
- compiler/cmm/CmmOpt.hs
- compiler/cmm/CmmParse.y
- compiler/cmm/CmmPipeline.hs
- compiler/cmm/CmmProcPoint.hs
- compiler/cmm/CmmSink.hs
- compiler/cmm/PprC.hs
- compiler/cmm/SMRep.hs
- compiler/codeGen/CodeGen/Platform.hs
- compiler/codeGen/StgCmmCon.hs
- compiler/codeGen/StgCmmPrim.hs
- compiler/coreSyn/CorePrep.hs
- compiler/coreSyn/CoreTidy.hs
- compiler/coreSyn/CoreUtils.hs
- compiler/deSugar/DsForeign.hs
- compiler/ghc.cabal.in
- compiler/ghci/ByteCodeAsm.hs
- compiler/ghci/ByteCodeGen.hs
- compiler/ghci/Linker.hs
- compiler/hieFile/HieBin.hs
- compiler/iface/BinIface.hs
- compiler/llvmGen/LlvmCodeGen/Base.hs
- compiler/llvmGen/LlvmCodeGen/CodeGen.hs
- compiler/llvmGen/LlvmCodeGen/Data.hs
- compiler/llvmGen/LlvmMangler.hs

The diff was not included because it is too large.

View it on GitLab: https://gitlab.haskell.org/ghc/ghc/compare/8eba833787507a1a005c625769b2d5e778c5555c...4161ed6697fbb2ce0ce6410e84f30688fa99943a

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/compare/8eba833787507a1a005c625769b2d5e778c5555c...4161ed6697fbb2ce0ce6410e84f30688fa99943a
You're receiving this email because of your account on gitlab.haskell.org.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20190619/dcbf9e49/attachment-0001.html>