[Git][ghc/ghc][wip/gc/shortcutting] 40 commits: rts: Implement concurrent collection in the nonmoving collector

Ben Gamari gitlab at gitlab.haskell.org
Wed Jun 19 15:28:51 UTC 2019 


Ben Gamari pushed to branch wip/gc/shortcutting at Glasgow Haskell Compiler / GHC


Commits:
395ab8d5 by Ben Gamari at 2019-06-19T15:23:46Z
rts: Implement concurrent collection in the nonmoving collector

This extends the non-moving collector to allow concurrent collection.

The full design of the collector implemented here is described in detail
in a technical note

    B. Gamari. "A Concurrent Garbage Collector For the Glasgow Haskell
    Compiler" (2018)

This extension involves the introduction of a capability-local
remembered set, known as the /update remembered set/, which tracks
objects which may no longer be visible to the collector due to mutation.
To maintain this remembered set we introduce a write barrier on
mutations which is enabled while a concurrent mark is underway.

The update remembered set representation is similar to that of the
nonmoving mark queue, being a chunked array of `MarkEntry`s. Each
`Capability` maintains a single accumulator chunk, which it flushed
when it (a) is filled, or (b) when the nonmoving collector enters its
post-mark synchronization phase.

While the write barrier touches a significant amount of code it is
conceptually straightforward: the mutator must ensure that the referee
of any pointer it overwrites is added to the update remembered set.
However, there are a few details:

 * In the case of objects with a dirty flag (e.g. `MVar`s) we can
   exploit the fact that only the *first* mutation requires a write
   barrier.

 * Weak references, as usual, complicate things. In particular, we must
   ensure that the referee of a weak object is marked if dereferenced by
   the mutator. For this we (unfortunately) must introduce a read
   barrier, as described in Note [Concurrent read barrier on deRefWeak#]
   (in `NonMovingMark.c`).

 * Stable names are also a bit tricky as described in Note [Sweeping
   stable names in the concurrent collector] (`NonMovingSweep.c`).

We take quite some pains to ensure that the high thread count often seen
in parallel Haskell applications doesn't affect pause times. To this end
we allow thread stacks to be marked either by the thread itself (when it
is executed or stack-underflows) or the concurrent mark thread (if the
thread owning the stack is never scheduled). There is a non-trivial
handshake to ensure that this happens without racing which is described
in Note [StgStack dirtiness flags and concurrent marking].

Co-Authored-by: Ömer Sinan Ağacan <omer at well-typed.com>

- - - - -
59894c90 by Ben Gamari at 2019-06-19T15:23:46Z
Nonmoving: Disable memory inventory with concurrent collection

- - - - -
3dba35e3 by Ben Gamari at 2019-06-19T15:24:09Z
rts: Tracing support for nonmoving collection events

This introduces a few events to mark key points in the nonmoving
garbage collection cycle. These include:

 * `EVENT_CONC_MARK_BEGIN`, denoting the beginning of a round of
   marking. This may happen more than once in a single major collection
   since we the major collector iterates until it hits a fixed point.

 * `EVENT_CONC_MARK_END`, denoting the end of a round of marking.

 * `EVENT_CONC_SYNC_BEGIN`, denoting the beginning of the post-mark
   synchronization phase

 * `EVENT_CONC_UPD_REM_SET_FLUSH`, indicating that a capability has
   flushed its update remembered set.

 * `EVENT_CONC_SYNC_END`, denoting that all mutators have flushed their
   update remembered sets.

 * `EVENT_CONC_SWEEP_BEGIN`, denoting the beginning of the sweep portion
   of the major collection.

 * `EVENT_CONC_SWEEP_END`, denoting the end of the sweep portion of the
   major collection.

- - - - -
a48300c5 by Ben Gamari at 2019-06-19T15:24:09Z
rts: Introduce non-moving heap census

This introduces a simple census of the non-moving heap (not to be
confused with the heap census used by the heap profiler). This
collects basic heap usage information (number of allocated and free
blocks) which is useful when characterising fragmentation of the
nonmoving heap.

- - - - -
55e50440 by Ben Gamari at 2019-06-19T15:24:09Z
rts/Eventlog: More descriptive error message

- - - - -
138f4055 by Ben Gamari at 2019-06-19T15:24:09Z
Allow census without live word count

Otherwise the census is unsafe when mutators are running due to
concurrent mutation.

- - - - -
c6db05b2 by Ben Gamari at 2019-06-19T15:24:09Z
NonmovingCensus: Emit samples to eventlog

- - - - -
9e2afe6c by Ben Gamari at 2019-06-19T15:24:09Z
rts: Add GetMyThreadCPUTime helper

- - - - -
6cf2d090 by Ben Gamari at 2019-06-19T15:24:09Z
rts/Stats: Track time usage of nonmoving collector

- - - - -
f9a609b8 by Ben Gamari at 2019-06-19T15:24:16Z
Nonmoving: Allow aging and refactor static objects logic

This commit does two things:

 * Allow aging of objects during the preparatory minor GC
 * Refactor handling of static objects to avoid the use of a hashtable

- - - - -
2fadc5bb by Ben Gamari at 2019-06-19T15:24:16Z
Disable aging when doing deadlock detection GC

- - - - -
bbb0532f by Ben Gamari at 2019-06-19T15:24:16Z
More comments for aging

- - - - -
91b7397a by Ben Gamari at 2019-06-19T15:24:43Z
NonMoving: Eliminate integer division in nonmovingBlockCount

Perf showed that the this single div was capturing up to 10% of samples
in nonmovingMark. However, the overwhelming majority of cases is looking
at small block sizes. These cases we can easily compute explicitly,
allowing the compiler to turn the division into a significantly more
efficient division-by-constant.

While the increase in source code looks scary, this all optimises down
to very nice looking assembler. At this point the only remaining
hotspots in nonmovingBlockCount are due to memory access.

- - - - -
69255fd3 by Ben Gamari at 2019-06-19T15:24:43Z
Allocate mark queues in larger block groups

- - - - -
0fa4699e by Ben Gamari at 2019-06-19T15:24:43Z
NonMovingMark: Optimize representation of mark queue

This shortens MarkQueueEntry by 30% (one word)

- - - - -
ce01e27c by Ben Gamari at 2019-06-19T15:24:43Z
NonMoving: Optimize bitmap search during allocation

Use memchr instead of a open-coded loop. This is nearly twice as fast in
a synthetic benchmark.

- - - - -
0f1b2545 by Ben Gamari at 2019-06-19T15:24:43Z
rts: Add prefetch macros

- - - - -
068c0031 by Ben Gamari at 2019-06-19T15:24:43Z
NonMoving: Prefetch when clearing bitmaps

Ensure that the bitmap of the segmentt that we will clear next is in
cache by the time we reach it.

- - - - -
6d0a1ba1 by Ben Gamari at 2019-06-19T15:24:43Z
NonMoving: Inline nonmovingClearAllBitmaps

- - - - -
681ee157 by Ben Gamari at 2019-06-19T15:24:43Z
NonMoving: Fuse sweep preparation into mark prep

- - - - -
0a2681ce by Ben Gamari at 2019-06-19T15:24:43Z
NonMoving: Pre-fetch during mark

This improved overall runtime on nofib's constraints test by nearly 10%.

- - - - -
3e43b8ef by Ben Gamari at 2019-06-19T15:24:43Z
NonMoving: Prefetch segment header

- - - - -
67215485 by Ben Gamari at 2019-06-19T15:24:43Z
NonMoving: Optimise allocator cache behavior

Previously we would look at the segment header to determine the block
size despite the fact that we already had the block size at hand.

- - - - -
a1a4c13a by Ben Gamari at 2019-06-19T15:24:43Z
NonMovingMark: Eliminate redundant check_in_nonmoving_heaps

- - - - -
c7ecb8a1 by Ben Gamari at 2019-06-19T15:24:44Z
NonMoving: Don't do major GC if one is already running

Previously we would perform a preparatory moving collection, resulting
in many things being added to the mark queue. When we finished with this
we would realize in nonmovingCollect that there was already a collection
running, in which case we would simply not run the nonmoving collector.

However, it was very easy to end up in a "treadmilling" situation: all
subsequent GC following the first failed major GC would be scheduled as
major GCs. Consequently we would continuously feed the concurrent
collector with more mark queue entries and it would never finish.

This patch aborts the major collection far earlier, meaning that we
avoid adding nonmoving objects to the mark queue and allowing the
concurrent collector to finish.

- - - - -
b1c0e777 by Ben Gamari at 2019-06-19T15:24:44Z
Nonmoving: Ensure write barrier vanishes in non-threaded RTS

- - - - -
69900691 by Ben Gamari at 2019-06-19T15:26:14Z
testsuite: Add nonmoving_thr way

- - - - -
8da04fa3 by Ben Gamari at 2019-06-19T15:26:14Z
testsuite: Add nonmoving_thr_ghc way

This uses the nonmoving collector when compiling the testcases.

- - - - -
1e59c6cb by Ben Gamari at 2019-06-19T15:26:14Z
testsuite: Don't run T15892 in nonmoving ways

The nonmoving GC doesn't support `+RTS -G1`, which this test insists on.

- - - - -
bcff1d84 by Ben Gamari at 2019-06-19T15:26:14Z
testsuite: Nonmoving collector doesn't support -G1

- - - - -
6327adf2 by Ben Gamari at 2019-06-19T15:26:14Z
testsuite: Ensure that threaded tests are run in nonmoving_thr

- - - - -
d7690aef by Ben Gamari at 2019-06-19T15:26:14Z
testsuite: bug1010 requires -c, which isn't supported by nonmoving

- - - - -
1d0c58bc by Ben Gamari at 2019-06-19T15:26:14Z
testsuite: Skip T15892 in nonmoving_thr_ghc

- - - - -
17a5c359 by Ben Gamari at 2019-06-19T15:26:14Z
ghc-heap: Skip heap_all test with debugged RTS

The debugged RTS initializes the heap with 0xaa, which breaks the
(admittedly rather fragile) assumption that uninitialized fields are set
to 0x00:
```
Wrong exit code for heap_all(nonmoving)(expected 0 , actual 1 )
Stderr ( heap_all ):
heap_all: user error (assertClosuresEq: Closures do not match
Expected: FunClosure {info = StgInfoTable {entry = Nothing, ptrs = 0, nptrs = 1, tipe = FUN_0_1, srtlen = 0, code = Nothing}, ptrArgs = [], dataArgs = [0]}
Actual:   FunClosure {info = StgInfoTable {entry = Nothing, ptrs = 0, nptrs = 1, tipe = FUN_0_1, srtlen = 1032832, code = Nothing}, ptrArgs = [], dataArgs = [12297829382473034410]}

CallStack (from HasCallStack):
  assertClosuresEq, called at heap_all.hs:230:9 in main:Main
)
```

- - - - -
fba07d85 by Ben Gamari at 2019-06-19T15:26:14Z
Skip ghc_heap_all test in nonmoving ways

- - - - -
5f6cb8ed by Ben Gamari at 2019-06-19T15:26:14Z
testsuite: Don't run T9630 in nonmoving ways

The nonmoving collector doesn't support -G1

- - - - -
d60bdf28 by Ben Gamari at 2019-06-19T15:26:15Z
testsuite: Don't run T7160 in nonmoving_thr ways

The nonmoving way finalizes things in a different order.

- - - - -
d5a98d86 by Ben Gamari at 2019-06-19T15:26:46Z
Merge branches 'wip/gc/optimize' and 'wip/gc/test' into wip/gc/everything

- - - - -
5a8b84f5 by Ömer Sinan Ağacan at 2019-06-19T15:27:16Z
NonMoving: Implement indirection shortcutting

This allows indirection chains residing in the non-moving heap to be
shorted-out.

- - - - -
02d28819 by Ömer Sinan Ağacan at 2019-06-19T15:27:16Z
NonMoving: Implement selector optimisation

- - - - -


30 changed files:

- compiler/cmm/CLabel.hs
- compiler/codeGen/StgCmmBind.hs
- compiler/codeGen/StgCmmPrim.hs
- compiler/codeGen/StgCmmUtils.hs
- includes/Cmm.h
- includes/Rts.h
- includes/RtsAPI.h
- includes/rts/EventLogFormat.h
- includes/rts/Flags.h
- + includes/rts/NonMoving.h
- includes/rts/storage/ClosureMacros.h
- includes/rts/storage/GC.h
- includes/rts/storage/TSO.h
- includes/stg/MiscClosures.h
- libraries/base/GHC/RTS/Flags.hsc
- libraries/base/GHC/Stats.hsc
- libraries/ghc-heap/tests/all.T
- rts/Apply.cmm
- rts/Capability.c
- rts/Capability.h
- rts/Exception.cmm
- rts/GetTime.h
- rts/Messages.c
- rts/PrimOps.cmm
- rts/RaiseAsync.c
- rts/RtsFlags.c
- rts/RtsStartup.c
- rts/RtsSymbols.c
- rts/STM.c
- rts/Schedule.c


The diff was not included because it is too large.


View it on GitLab: https://gitlab.haskell.org/ghc/ghc/compare/acd93693107bdd703e992a2b04b27fdeb89df942...02d28819f65f8219c57871e7be2bd13cdba5fef9

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/compare/acd93693107bdd703e992a2b04b27fdeb89df942...02d28819f65f8219c57871e7be2bd13cdba5fef9
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20190619/feda4010/attachment-0001.html>

More information about the ghc-commits mailing list