[Git][ghc/ghc][wip/fix-windows] linker: Disable code unloading

[Ben Gamari]

Ben Gamari pushed to branch wip/fix-windows at Glasgow Haskell Compiler / GHC


Commits:
e35a3da3 by Ben Gamari at 2019-06-18T18:55:45Z
linker: Disable code unloading

As noted in #16841, there are currently a variety of bugs in the
unloading logic. These only affect Windows since code unloading is
disabled on Linux, where we build with `GhcDynamic=YES` by default.

In the interest of getting the tree green on Windows disable code
unloading until the issues are resolved.

- - - - -


1 changed file:

- compiler/ghci/Linker.hs


Changes:

=====================================
compiler/ghci/Linker.hs
=====================================
@@ -1124,7 +1124,8 @@ unload_wkr hsc_env keep_linkables pls at PersistentLinkerState{..}  = do
         -- dynamic linker.  Doing so introduces extra complexity for
         -- not much benefit.
       | otherwise
-      = mapM_ (unloadObj hsc_env) [f | DotO f <- linkableUnlinked lnk]
+      = return () -- Disabled for now due to instability; see #16841.
+      -- = mapM_ (unloadObj hsc_env) [f | DotO f <- linkableUnlinked lnk]
                 -- The components of a BCO linkable may contain
                 -- dot-o files.  Which is very confusing.
                 --



View it on GitLab: https://gitlab.haskell.org/ghc/ghc/commit/e35a3da368f3eb6fa8e62927384707063ac55c91

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/commit/e35a3da368f3eb6fa8e62927384707063ac55c91
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20190618/21c691a7/attachment-0001.html>