[Git][ghc/ghc][wip/marge_bot_batch_merge_job] 13 commits: gitlab-ci: Lint testsuite for framework failures

Marge Bot gitlab at gitlab.haskell.org
Sat Jun 15 03:41:43 UTC 2019



 Marge Bot pushed to branch wip/marge_bot_batch_merge_job at Glasgow Haskell Compiler / GHC


Commits:
503e830c by Ben Gamari at 2019-06-15T03:10:08Z
gitlab-ci: Lint testsuite for framework failures

This introduces a new lint job checking for framework failures and
listing broken tests.

- - - - -
b5ea9323 by Ben Gamari at 2019-06-15T03:10:08Z
lint: Only apply --interactive lint to testsuite .T files

- - - - -
5c97211c by Ben Gamari at 2019-06-15T03:10:08Z
gitlab-ci: Lint the linters

- - - - -
257165b4 by Alp Mestanogullari at 2019-06-15T03:10:46Z
Remove duplicates from 'ghc --info' output

- - - - -
15be31b0 by Ben Gamari at 2019-06-15T03:41:33Z
Bump unix submodule

Skips `executeFile001` test in `threaded2` way. Fixes #16814.

- - - - -
f4d0f023 by Ben Gamari at 2019-06-15T03:41:33Z
make: Clean includes/settings file

Now since this is generated by the build system we should ensure that it
is properly cleaned.

[skip ci]

- - - - -
3093de5d by Ben Gamari at 2019-06-15T03:41:33Z
Disable optimisation when building Cabal lib for stage0

This disables optimisation when building Cabal for Hadrian and
stage0 `ghc-cabal`. Cabal is performance critical in neither case nor
will any performance difference here be visible to the end-user.

See #16817.

- - - - -
01d68c9d by Ben Gamari at 2019-06-15T03:41:33Z
Disable optimisation when building Cabal in development flavours

This updates the make and Hadrian build flavours targetting developers
to disable optimisation when building the Cabal library. Cabal tends to
tickle some very bad compiler performance cases (e.g. #16577) so
disabling optimisation here makes a sizeable impact on overall build
time.

See #16817.

- - - - -
b1fef394 by Ben Gamari at 2019-06-15T03:41:34Z
testsuite: Introduce concurrent_ways set

Previously we just tested for the threaded2 when determining whether to
skip tests which are fragile under concurrent execution. However, this
isn't the only way which is concurrent.

- - - - -
d4c16e27 by Ben Gamari at 2019-06-15T03:41:34Z
testsuite: Skip hDuplicateTo001 in concurrent ways

As noted in #16819, this operation is racy under concurrent execution.

- - - - -
2073cddd by Aiken Cairncross at 2019-06-15T03:41:35Z
Fix typo in error message

- - - - -
5b11ffe2 by Ben Gamari at 2019-06-15T03:41:35Z
testsuite: Add assertions that way lists are in fact lists

Previously there were a few cases where operations like `omit_ways`
were incorrectly passed a single way (e.g. `omit_ways('threaded2')`).
This won't work as the author expected.

- - - - -
ec0d61d1 by Ryan Scott at 2019-06-15T03:41:37Z
Synchronize ClsInst.doTyConApp with TcTypeable validity checks (#15862)

Issue #15862 demonstrated examples of type constructors on which
`TcTypeable.tyConIsTypeable` would return `False`, but the `Typeable`
constraint solver in `ClsInst` (in particular, `doTyConApp`) would
try to generate `Typeable` evidence for anyway, resulting in
disaster. This incongruity was caused by the fact that `doTyConApp`
was using a weaker validity check than `tyConIsTypeable` to determine
if a type constructor warrants `Typeable` evidence or not. The
solution, perhaps unsurprisingly, is to use `tyConIsTypeable` in
`doTyConApp` instead.

To avoid import cycles between `ClsInst` and `TcTypeable`, I factored
out `tyConIsTypeable` into its own module, `TcTypeableValidity`.

Fixes #15862.

- - - - -


30 changed files:

- .gitlab-ci.yml
- .gitlab/linters/check-makefiles.py
- .gitlab/linters/linter.py
- compiler/deSugar/Check.hs
- compiler/ghc.cabal.in
- compiler/main/DynFlags.hs
- compiler/typecheck/ClsInst.hs
- compiler/typecheck/TcTypeable.hs
- + compiler/typecheck/TcTypeableValidity.hs
- ghc.mk
- hadrian/cabal.project
- hadrian/src/Settings/Flavours/Development.hs
- libraries/base/tests/IO/all.T
- libraries/base/tests/Numeric/all.T
- libraries/base/tests/all.T
- libraries/unix
- mk/flavours/devel1.mk
- mk/flavours/devel2.mk
- mk/flavours/validate.mk
- testsuite/config/ghc
- testsuite/driver/runtests.py
- testsuite/driver/testlib.py
- testsuite/mk/test.mk
- testsuite/tests/codeGen/should_compile/all.T
- testsuite/tests/concurrent/should_run/all.T
- testsuite/tests/dependent/should_compile/all.T
- testsuite/tests/numeric/should_run/all.T
- testsuite/tests/primops/should_run/all.T
- testsuite/tests/quasiquotation/all.T
- testsuite/tests/roles/should_compile/all.T


The diff was not included because it is too large.


View it on GitLab: https://gitlab.haskell.org/ghc/ghc/compare/5d880cd86324751f435348c8a48573c2e177cf85...ec0d61d146a201306ea1c9c6ae0946ee2c7ecf72

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/compare/5d880cd86324751f435348c8a48573c2e177cf85...ec0d61d146a201306ea1c9c6ae0946ee2c7ecf72
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20190614/8264b736/attachment-0001.html>


More information about the ghc-commits mailing list