[Git][ghc/ghc][wip/marge_bot_batch_merge_job] 9 commits: Warn about unused packages

Marge Bot gitlab at gitlab.haskell.org
Tue Jun 11 16:09:57 UTC 2019



 Marge Bot pushed to branch wip/marge_bot_batch_merge_job at Glasgow Haskell Compiler / GHC


Commits:
e2e82e7a by Yuras Shumovich at 2019-06-11T16:09:40Z
Warn about unused packages

Reviewers: bgamari, simonpj

Reviewed By: simonpj

Subscribers: hvr, simonpj, mpickering, rwbarton, carter

GHC Trac Issues: #15838

Differential Revision: https://phabricator.haskell.org/D5285

- - - - -
09c1c9bb by Alp Mestanogullari at 2019-06-11T16:09:42Z
Refine the GHCI macro into HAVE[_{INTERNAL, EXTERNAL}]_INTERPRETER

As discussed in #16331, the GHCI macro, defined through 'ghci' flags
in ghc.cabal.in, ghc-bin.cabal.in and ghci.cabal.in, is supposed to indicate
whether GHC is built with support for an internal interpreter, that runs in
the same process. It is however overloaded in a few places to mean
"there is an interpreter available", regardless of whether it's an internal
or external interpreter.

For the sake of clarity and with the hope of more easily being able to
build stage 1 GHCs with external interpreter support, this patch splits
the previous GHCI macro into 3 different ones:

- HAVE_INTERNAL_INTERPRETER: GHC is built with an internal interpreter
- HAVE_EXTERNAL_INTERPRETER: GHC is built with support for external interpreters
- HAVE_INTERPRETER: HAVE_INTERNAL_INTERPRETER || HAVE_EXTERNAL_INTERPRETER

- - - - -
d9d03b1a by Alec Theriault at 2019-06-11T16:09:44Z
Make `haddock_testsuite` respect `--test-accept`

Suppose you've made changes that affect the output of `haddockHtmlTest`
so that the following is failing:

    ./hadrian/build.sh -c --only=haddockHtmlTest test

Then, the following will accept new output for Haddock's test cases.

    ./hadrian/build.sh -c --only=haddockHtmlTest test --test-accept

You still do need to make sure those new changes (which show up in
Haddock's tree) get committed though.

Fixes #16694

- - - - -
d3475c61 by Alp Mestanogullari at 2019-06-11T16:09:45Z
rts/RtsFlags.c: mention that -prof too enables support for +RTS -l

- - - - -
60c9be3d by Alp Mestanogullari at 2019-06-11T16:09:47Z
Hadrian: teach the RTS that PROFILING implies TRACING

As discussed in #16744, both the Make and Hadrian build systems
have special code to always pass -eventlog whenever -prof or -debug
are passed. However, there is some similar logic in the RTS itself only
for defining TRACING when the DEBUG macro is defined, but no such logic
is implemented to define TRACING when the PROFILING macro is defined.
This patch adds such a logic and therefore fixes #16744.

- - - - -
0667d9de by Ben Gamari at 2019-06-11T16:09:47Z
rts/linker: Mmap into low memory on AArch64

This extends mmapForLinker to use the same low-memory mapping
strategy used on x86_64 on AArch64. See #16784.

- - - - -
575332f9 by Ben Gamari at 2019-06-11T16:09:47Z
rts/linker: Use mmapForLinker to map PLT

The PLT needs to be located within a close distance of
the code calling it under the small memory model.

Fixes #16784.

- - - - -
437629b6 by Ömer Sinan Ağacan at 2019-06-11T16:09:49Z
Fix an error message in CheckUnload.c:searchHeapBlocks

- - - - -
e25ff26d by Alp Mestanogullari at 2019-06-11T16:09:50Z
testsuite/mk/boilerplate.mk: rename 'ghc-config-mk' to 'ghc_config_mk'

Make/shell variable names which contain dashes can cause problems under
some conditions. The 'ghc-config-mk' variable from testsuite/mk/boilerplate.mk
that I made overridable (by Hadrian) in ba0aed2e was working as expected when
our Hadrian/Linux job was based off the deb8 Docker image, but broke when
I switched the job to use our deb9-based image, in 3d97bad6. The exact
circumstances/tool versions that trigger this problem are unknown, but
changing the variable's name to 'ghc_config_mk' lets us work around the issue.

This fixes the annth_compunits and annth_make test failures that showed up
when we switched the Hadrian/Linux job to use the deb9 environment.

- - - - -


30 changed files:

- compiler/ghc.cabal.in
- compiler/ghci/GHCi.hs
- compiler/main/DynFlags.hs
- compiler/main/DynamicLoading.hs
- compiler/main/GhcMake.hs
- compiler/rename/RnExpr.hs
- compiler/simplCore/SimplCore.hs
- compiler/typecheck/TcAnnotations.hs
- compiler/typecheck/TcPluginM.hs
- compiler/utils/Util.hs
- docs/users_guide/8.8.1-notes.rst
- docs/users_guide/phases.rst
- docs/users_guide/using-warnings.rst
- ghc/Main.hs
- ghc/ghc-bin.cabal.in
- hadrian/src/Rules/Test.hs
- hadrian/src/Settings/Packages.hs
- includes/rts/Config.h
- libraries/ghci/GHCi/BreakArray.hs
- libraries/ghci/GHCi/InfoTable.hsc
- libraries/ghci/ghci.cabal.in
- rts/CheckUnload.c
- rts/Linker.c
- rts/RtsFlags.c
- rts/linker/Elf.c
- testsuite/mk/boilerplate.mk
- testsuite/tests/codeGen/should_compile/jmp_tbl.hs
- testsuite/tests/haddock/haddock_testsuite/Makefile
- testsuite/tests/haddock/haddock_testsuite/all.T
- + testsuite/tests/warnings/should_compile/UnusedPackages.hs


The diff was not included because it is too large.


View it on GitLab: https://gitlab.haskell.org/ghc/ghc/compare/13d8adec0022b018696a26b65df775a99e641701...e25ff26d89a0b89103d8905ef126dea0973dd78b

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/compare/13d8adec0022b018696a26b65df775a99e641701...e25ff26d89a0b89103d8905ef126dea0973dd78b
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20190611/568a9d5d/attachment.html>


More information about the ghc-commits mailing list