[commit: ghc] wip/T16217: check-api-annotations checks for annotation preceding its span (45d1f3a)

Tue Jan 22 21:40:24 UTC 2019

Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/T16217
Link       : http://ghc.haskell.org/trac/ghc/changeset/45d1f3ac653da24d2eb3d2fc99481898e4dbc8a0/ghc

>---------------------------------------------------------------

commit 45d1f3ac653da24d2eb3d2fc99481898e4dbc8a0
Author: Alan Zimmerman <alan.zimm at gmail.com>
Date:   Tue Jan 22 23:29:25 2019 +0200

    check-api-annotations checks for annotation preceding its span

    For an API annotation to be useful, it must not occur before the span
    it is enclosed in.

    So, for check-api-annotation output, a line such as

    ((Test16212.hs:3:22-36,AnnOpenP), [Test16212.hs:3:21]),

    should be flagged as an error, as the AnnOpenP location of 3:21
    precedes its enclosing span of 3:22-26.

    This patch does this.

    Closes #16217

>---------------------------------------------------------------

45d1f3ac653da24d2eb3d2fc99481898e4dbc8a0
 testsuite/tests/ghc-api/annotations/Makefile       |  4 ++
 testsuite/tests/ghc-api/annotations/T10255.stdout  |  7 +++-
 testsuite/tests/ghc-api/annotations/T10268.stdout  |  7 +++-
 testsuite/tests/ghc-api/annotations/T10269.stdout  |  7 +++-
 testsuite/tests/ghc-api/annotations/T10276.stdout  |  7 +++-
 testsuite/tests/ghc-api/annotations/T10278.stdout  |  7 +++-
 testsuite/tests/ghc-api/annotations/T10280.stdout  |  7 +++-
 testsuite/tests/ghc-api/annotations/T10307.stdout  |  7 +++-
 testsuite/tests/ghc-api/annotations/T10309.stdout  |  7 +++-
 testsuite/tests/ghc-api/annotations/T10312.stdout  |  7 +++-
 testsuite/tests/ghc-api/annotations/T10354.stdout  |  7 +++-
 testsuite/tests/ghc-api/annotations/T10357.stdout  |  7 +++-
 testsuite/tests/ghc-api/annotations/T10358.stdout  |  7 +++-
 testsuite/tests/ghc-api/annotations/T10396.stdout  |  7 +++-
 testsuite/tests/ghc-api/annotations/T10399.stdout  |  7 +++-
 testsuite/tests/ghc-api/annotations/T10598.stdout  |  7 +++-
 testsuite/tests/ghc-api/annotations/T11018.stdout  |  8 +++-
 testsuite/tests/ghc-api/annotations/T11321.stdout  |  7 +++-
 testsuite/tests/ghc-api/annotations/T11332.stdout  |  7 +++-
 testsuite/tests/ghc-api/annotations/T12417.stdout  |  7 +++-
 testsuite/tests/ghc-api/annotations/T13163.stdout  |  7 +++-
 testsuite/tests/ghc-api/annotations/T15303.stdout  |  7 +++-
 testsuite/tests/ghc-api/annotations/T16212.stdout  | 49 ++++++++++++++++++++++
 testsuite/tests/ghc-api/annotations/Test16212.hs   | 11 +++++
 testsuite/tests/ghc-api/annotations/all.T          |  6 ++-
 .../tests/ghc-api/annotations/boolFormula.stdout   |  7 +++-
 .../tests/ghc-api/annotations/bundle-export.stdout |  7 +++-
 .../tests/ghc-api/annotations/exampleTest.stdout   |  7 +++-
 .../tests/ghc-api/annotations/load-main.stdout     |  7 +++-
 utils/check-api-annotations/Main.hs                | 22 +++++++---
 30 files changed, 237 insertions(+), 31 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 45d1f3ac653da24d2eb3d2fc99481898e4dbc8a0