[commit: ghc] wip/hs-expr-todo: Remove TODO in HsExpr (7efe413)

git at git.haskell.org git at git.haskell.org
Fri Jan 18 16:36:26 UTC 2019


Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/hs-expr-todo
Link       : http://ghc.haskell.org/trac/ghc/changeset/7efe4135f3ba04531fb2871937b9a2cff70100df/ghc

>---------------------------------------------------------------

commit 7efe4135f3ba04531fb2871937b9a2cff70100df
Author: Matthew Pickering <matthewtpickering at gmail.com>
Date:   Fri Jan 18 11:36:12 2019 -0500

    Remove TODO in HsExpr
    
    It is correct to be `GhcTc` as the data type is for expressions which are inside splices
    so they can be delayed until desugaring.


>---------------------------------------------------------------

7efe4135f3ba04531fb2871937b9a2cff70100df
 compiler/hsSyn/HsExpr.hs | 1 -
 1 file changed, 1 deletion(-)

diff --git a/compiler/hsSyn/HsExpr.hs b/compiler/hsSyn/HsExpr.hs
index 41bbdb2..bae29b0 100644
--- a/compiler/hsSyn/HsExpr.hs
+++ b/compiler/hsSyn/HsExpr.hs
@@ -2486,7 +2486,6 @@ data UntypedSpliceFlavour
 
 -- | Pending Type-checker Splice
 data PendingTcSplice
-  -- AZ:TODO: The hard-coded GhcTc feels wrong.
   = PendingTcSplice SplicePointName (LHsExpr GhcTc)
 
 {-



More information about the ghc-commits mailing list