[commit: ghc] wip/ghc-8.8-az: API Annotations: AnnAt disconnected for TYPEAPP (91ba643)

git at git.haskell.org git at git.haskell.org
Thu Feb 28 02:15:02 UTC 2019


Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/ghc-8.8-az
Link       : http://ghc.haskell.org/trac/ghc/changeset/91ba643c1bbdc2c10504a66674f9bd83fec5151d/ghc

>---------------------------------------------------------------

commit 91ba643c1bbdc2c10504a66674f9bd83fec5151d
Author: Alan Zimmerman <alan.zimm at gmail.com>
Date:   Wed Jan 30 16:20:52 2019 +0200

    API Annotations: AnnAt disconnected for TYPEAPP
    
    For the code
    
        type family F1 (a :: k) (f :: k -> Type) :: Type where
          F1 @Peano a f = T @Peano f a
    
    the API annotation for the first @ is not attached to a SourceSpan in
    the ParsedSource
    
    Closes #16236
    
    (cherry picked from commit cbfc9fcaa33c3b341830962906543dfca1dfedd7)


>---------------------------------------------------------------

91ba643c1bbdc2c10504a66674f9bd83fec5151d
 compiler/deSugar/DsMeta.hs                         |  6 +-
 compiler/hieFile/HieAst.hs                         |  4 +-
 compiler/hsSyn/Convert.hs                          |  9 ++-
 compiler/hsSyn/HsTypes.hs                          | 19 ++---
 compiler/parser/Parser.y                           |  2 +-
 compiler/parser/RdrHsSyn.hs                        | 69 +++++++++++-------
 compiler/rename/RnTypes.hs                         | 10 +--
 compiler/typecheck/TcExpr.hs                       | 24 +++---
 compiler/typecheck/TcHsType.hs                     | 11 +--
 testsuite/tests/ghc-api/annotations/Makefile       |  4 +
 testsuite/tests/ghc-api/annotations/T16236.stdout  | 85 ++++++++++++++++++++++
 .../annotations/Test16236.hs}                      |  3 +-
 testsuite/tests/ghc-api/annotations/all.T          |  2 +
 .../parser/should_compile/DumpParsedAst.stderr     |  3 +-
 .../parser/should_compile/DumpRenamedAst.stderr    |  3 +-
 utils/haddock                                      |  2 +-
 16 files changed, 183 insertions(+), 73 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 91ba643c1bbdc2c10504a66674f9bd83fec5151d


More information about the ghc-commits mailing list