[commit: ghc] wip/ghc-8.8-merges: Use sigPrec in more places in Convert and HsUtils (46ff73d)
git at git.haskell.org
git at git.haskell.org
Thu Feb 21 15:11:16 UTC 2019
Repository : ssh://git@git.haskell.org/ghc
On branch : wip/ghc-8.8-merges
Link : http://ghc.haskell.org/trac/ghc/changeset/46ff73df2bd12f270f447ab070d6a9b20cbab6fa/ghc
>---------------------------------------------------------------
commit 46ff73df2bd12f270f447ab070d6a9b20cbab6fa
Author: Ryan Scott <ryan.gl.scott at gmail.com>
Date: Mon Jan 14 21:45:17 2019 -0500
Use sigPrec in more places in Convert and HsUtils
Trac #16183 was caused by TH conversion (in `Convert`) not properly
inserting parentheses around occurrences of explicit signatures where
appropriate, such as in applications, function types, and type family
equations. Solution: use `parenthesizeHsType sigPrec` in these
places. While I was in town, I also updated `nlHsFunTy` to do the
same thing.
(cherry picked from commit b1e569a54085bf1093b4f858f8c7c739e3be769b)
>---------------------------------------------------------------
46ff73df2bd12f270f447ab070d6a9b20cbab6fa
compiler/hsSyn/Convert.hs | 67 +++++++++++++++++++------------------
compiler/hsSyn/HsUtils.hs | 8 +----
testsuite/tests/th/T12045TH1.stderr | 4 +--
testsuite/tests/th/T16183.hs | 11 ++++++
testsuite/tests/th/T16183.stderr | 12 +++++++
testsuite/tests/th/all.T | 1 +
6 files changed, 62 insertions(+), 41 deletions(-)
Diff suppressed because of size. To see it, use:
git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 46ff73df2bd12f270f447ab070d6a9b20cbab6fa
More information about the ghc-commits
mailing list