[commit: ghc] wip/ci-i386, wip/linters, wip/ww-noinline: Get rid of tcm_smart from TyCoMapper (1f1b9e3)

git at git.haskell.org git at git.haskell.org
Tue Feb 19 14:13:20 UTC 2019


Repository : ssh://git@git.haskell.org/ghc

On branches: wip/ci-i386,wip/linters,wip/ww-noinline
Link       : http://ghc.haskell.org/trac/ghc/changeset/1f1b9e356a873ec7da84cdac2a7850ecb2b32ea9/ghc

>---------------------------------------------------------------

commit 1f1b9e356a873ec7da84cdac2a7850ecb2b32ea9
Author: Simon Peyton Jones <simonpj at microsoft.com>
Date:   Fri Feb 15 09:56:06 2019 +0000

    Get rid of tcm_smart from TyCoMapper
    
    Following a succession of refactorings of the type checker,
    culminating in the patch
           Make a smart mkAppTyM
    we have got rid of mkNakedAppTy etc.  And that in turn
    meant that the tcm_smart field of the generic TyCoMapper
    (in Type.hs) was entirely unused.  It was always set to True.
    
    So this patch just gets rid of it completely.  Less code,
    less complexity, and more efficient because fewer higher-order
    function calls.  Everyone wins.
    
    No change in behaviour; this does not cure any bugs!


>---------------------------------------------------------------

1f1b9e356a873ec7da84cdac2a7850ecb2b32ea9
 compiler/typecheck/TcHsSyn.hs  |  9 +++---
 compiler/typecheck/TcHsType.hs |  3 +-
 compiler/typecheck/TcMType.hs  | 18 ++++++------
 compiler/types/Type.hs         | 64 ++++++++++++++++--------------------------
 4 files changed, 39 insertions(+), 55 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 1f1b9e356a873ec7da84cdac2a7850ecb2b32ea9


More information about the ghc-commits mailing list