[commit: ghc] wip/T16212-fixed, wip/sgraf-no-exnstr: API Annotations: Parens not attached correctly for ClassDecl (4bf35da)

git at git.haskell.org git at git.haskell.org
Fri Feb 1 05:54:56 UTC 2019


Repository : ssh://git@git.haskell.org/ghc

On branches: wip/T16212-fixed,wip/sgraf-no-exnstr
Link       : http://ghc.haskell.org/trac/ghc/changeset/4bf35da4fccd2a21153a1c19bfa80006e99e02a1/ghc

>---------------------------------------------------------------

commit 4bf35da4fccd2a21153a1c19bfa80006e99e02a1
Author: Alan Zimmerman <alan.zimm at gmail.com>
Date:   Thu Jan 24 10:14:55 2019 +0200

    API Annotations: Parens not attached correctly for ClassDecl
    
    The parens around the kinded tyvars should be attached to the class
    declaration as a whole, they are attached to the tyvar instead,
    outside the span.
    
    An annotation must always be within or after the span it is contained
    in.
    
    Closes #16212


>---------------------------------------------------------------

4bf35da4fccd2a21153a1c19bfa80006e99e02a1
 compiler/parser/RdrHsSyn.hs                       | 41 ++++++++++++-----------
 testsuite/tests/ghc-api/annotations/T11018.stdout | 11 +++---
 testsuite/tests/ghc-api/annotations/T16212.stdout | 35 ++++++++++++++-----
 testsuite/tests/ghc-api/annotations/Test16212.hs  |  2 ++
 testsuite/tests/ghc-api/annotations/all.T         |  4 +--
 utils/hsc2hs                                      |  2 +-
 6 files changed, 57 insertions(+), 38 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 4bf35da4fccd2a21153a1c19bfa80006e99e02a1


More information about the ghc-commits mailing list