[commit: ghc] master: Remove redundant slop zeroing (29f1c55)

git at git.haskell.org git at git.haskell.org
Fri Sep 21 07:08:37 UTC 2018


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/29f1c556dd563f563c3c0522823fa66f171ff023/ghc

>---------------------------------------------------------------

commit 29f1c556dd563f563c3c0522823fa66f171ff023
Author: Ömer Sinan Ağacan <omeragacan at gmail.com>
Date:   Fri Sep 21 10:08:18 2018 +0300

    Remove redundant slop zeroing
    
    OVERWRITE_INFO already does zero slopping by calling OVERWRITING_CLOSURE


>---------------------------------------------------------------

29f1c556dd563f563c3c0522823fa66f171ff023
 rts/Threads.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/rts/Threads.c b/rts/Threads.c
index 78c5b6c..9776353 100644
--- a/rts/Threads.c
+++ b/rts/Threads.c
@@ -371,12 +371,6 @@ wakeBlockingQueue(Capability *cap, StgBlockingQueue *bq)
 
     // overwrite the BQ with an indirection so it will be
     // collected at the next GC.
-#if defined(DEBUG) && !defined(THREADED_RTS)
-    // XXX FILL_SLOP, but not if THREADED_RTS because in that case
-    // another thread might be looking at this BLOCKING_QUEUE and
-    // checking the owner field at the same time.
-    bq->bh = 0; bq->queue = 0; bq->owner = 0;
-#endif
     OVERWRITE_INFO(bq, &stg_IND_info);
 }
 



More information about the ghc-commits mailing list