[commit: ghc] ghc-8.6: Don't shortcut SRTs for static functions (#15544) (28356f2)

git at git.haskell.org git at git.haskell.org
Wed Sep 19 18:26:17 UTC 2018


Repository : ssh://git@git.haskell.org/ghc

On branch  : ghc-8.6
Link       : http://ghc.haskell.org/trac/ghc/changeset/28356f217fe4d314bd5a4f0316b5bced755cbb2f/ghc

>---------------------------------------------------------------

commit 28356f217fe4d314bd5a4f0316b5bced755cbb2f
Author: Simon Marlow <marlowsd at gmail.com>
Date:   Tue Sep 18 11:47:56 2018 -0400

    Don't shortcut SRTs for static functions (#15544)
    
    Shortcutting the SRT for a static function can lead to resurrecting a
    static object at runtime, which violates assumptions in the GC. See
    comments for details.
    
    Test Plan:
    - manual testing (in progress)
    - validate
    
    Reviewers: osa1, bgamari, erikd
    
    Reviewed By: bgamari
    
    Subscribers: rwbarton, carter
    
    GHC Trac Issues: #15544
    
    Differential Revision: https://phabricator.haskell.org/D5145
    
    (cherry picked from commit a324dfdf3b505ea30d134dc8183d7b4bb441ced4)


>---------------------------------------------------------------

28356f217fe4d314bd5a4f0316b5bced755cbb2f
 compiler/cmm/CmmBuildInfoTables.hs | 152 +++++++++++++++++++++++++++++++------
 1 file changed, 130 insertions(+), 22 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 28356f217fe4d314bd5a4f0316b5bced755cbb2f


More information about the ghc-commits mailing list