[commit: ghc] master: Don't shortcut SRTs for static functions (#15544) (1971e99)
git at git.haskell.org
git at git.haskell.org
Tue Sep 18 18:17:20 UTC 2018
Repository : ssh://git@git.haskell.org/ghc
On branch : master
Link : http://ghc.haskell.org/trac/ghc/changeset/1971e9995b7c4acf550093f15e17dfdad47caaf9/ghc
>---------------------------------------------------------------
commit 1971e9995b7c4acf550093f15e17dfdad47caaf9
Author: Simon Marlow <marlowsd at gmail.com>
Date: Tue Sep 18 11:47:56 2018 -0400
Don't shortcut SRTs for static functions (#15544)
Shortcutting the SRT for a static function can lead to resurrecting a
static object at runtime, which violates assumptions in the GC. See
comments for details.
Test Plan:
- manual testing (in progress)
- validate
Reviewers: osa1, bgamari, erikd
Reviewed By: bgamari
Subscribers: rwbarton, carter
GHC Trac Issues: #15544
Differential Revision: https://phabricator.haskell.org/D5145
>---------------------------------------------------------------
1971e9995b7c4acf550093f15e17dfdad47caaf9
compiler/cmm/CmmBuildInfoTables.hs | 152 +++++++++++++++++++++++++++++++------
1 file changed, 130 insertions(+), 22 deletions(-)
Diff suppressed because of size. To see it, use:
git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 1971e9995b7c4acf550093f15e17dfdad47caaf9
More information about the ghc-commits
mailing list