[commit: ghc] master: Comment out CONSTANT_FOLDED in GHC.Natural (2f2308e)

git at git.haskell.org git at git.haskell.org
Sun Oct 28 17:41:21 UTC 2018


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/2f2308e26579959d6c217150e1033c2faedc0bb5/ghc

>---------------------------------------------------------------

commit 2f2308e26579959d6c217150e1033c2faedc0bb5
Author: Christiaan Baaij <christiaan.baaij at gmail.com>
Date:   Sun Oct 28 12:29:23 2018 -0400

    Comment out CONSTANT_FOLDED in GHC.Natural
    
    Summary:
    Although these functions were marked as CONSTANT_FOLDED, they did
    not have a corresponding builtinRule in PrelRules. The idea was
    probably to add them eventually, but this hasn't manifested so
    far.
    
    The plan is to eventually add builtin rules for these functions
    over Natural, so as a reminder we simply comment out the
    CONSTANT_FOLDED  annotation instead of removing it completely.
    
    Reviewers: hvr, bgamari
    
    Reviewed By: bgamari
    
    Subscribers: rwbarton, carter
    
    Differential Revision: https://phabricator.haskell.org/D5267


>---------------------------------------------------------------

2f2308e26579959d6c217150e1033c2faedc0bb5
 libraries/base/GHC/Natural.hs                      | 55 ++++++++++++----------
 .../tests/numeric/should_compile/T14465.stdout     | 15 ++++--
 2 files changed, 40 insertions(+), 30 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 2f2308e26579959d6c217150e1033c2faedc0bb5


More information about the ghc-commits mailing list