[commit: ghc] master: Fix T15729 in master (46f2906)
git at git.haskell.org
git at git.haskell.org
Wed Oct 17 19:08:14 UTC 2018
Repository : ssh://git@git.haskell.org/ghc
On branch : master
Link : http://ghc.haskell.org/trac/ghc/changeset/46f2906d1c6e1fb732a90882487479a2ebf19ca1/ghc
>---------------------------------------------------------------
commit 46f2906d1c6e1fb732a90882487479a2ebf19ca1
Author: Zejun Wu <watashi at fb.com>
Date: Wed Oct 17 15:07:07 2018 -0400
Fix T15729 in master
Summary:
It failed when running ./validate on master
T15729 is added by me in D5219 recently,
it failed when GHCi is dynamicly linked:
```
Stderr ( T15729 ):
/bin/ld.gold: error: bss.o: requires unsupported dynamic reloc 11;
recompile with -fPIC
collect2: error: ld returned 1 exit status
`gcc' failed in phase `Linker'. (Exit code: 1)
```
Test Plan: Both tests pass now.
Reviewers: simonmar, bgamari
Reviewed By: bgamari
Subscribers: rwbarton, carter
Differential Revision: https://phabricator.haskell.org/D5235
>---------------------------------------------------------------
46f2906d1c6e1fb732a90882487479a2ebf19ca1
testsuite/tests/ghci/linking/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testsuite/tests/ghci/linking/Makefile b/testsuite/tests/ghci/linking/Makefile
index 3ecc3c3..bfbcf24 100644
--- a/testsuite/tests/ghci/linking/Makefile
+++ b/testsuite/tests/ghci/linking/Makefile
@@ -137,5 +137,5 @@ T14708:
.PHONY: T15729
T15729:
- "$(TEST_HC)" -c T15729.c -o bss.o
+ "$(TEST_HC)" -fPIC -c T15729.c -o bss.o
echo "main" | "$(TEST_HC)" $(TEST_HC_OPTS_INTERACTIVE) bss.o T15729.hs
More information about the ghc-commits
mailing list