[commit: ghc] master: Enable -Wcompat=error in the testsuite (165d3d5)
git at git.haskell.org
git at git.haskell.org
Tue Oct 16 00:00:24 UTC 2018
Repository : ssh://git@git.haskell.org/ghc
On branch : master
Link : http://ghc.haskell.org/trac/ghc/changeset/165d3d5ddaecc7dbe7f5ac051834a7619463efb0/ghc
>---------------------------------------------------------------
commit 165d3d5ddaecc7dbe7f5ac051834a7619463efb0
Author: Vladislav Zavialov <vlad.z.4096 at gmail.com>
Date: Mon Oct 15 13:52:12 2018 -0400
Enable -Wcompat=error in the testsuite
Enabling -Werror=compat in the testsuite allows us to easily see the
impact that a new warning has on code. It also means that in the period
between adding the warning and making the actual breaking change, all
new test cases that are being added to the testsuite will be
forwards-compatible. This is good because it will make the actual
breaking change contain less irrelevant testsuite updates.
Things that -Wcompat warns about are things that are going to break in
the future, so we can be proactive and keep our testsuite
forwards-compatible.
This patch consists of two main changes:
* Add `TEST_HC_OPTS += -Werror=compat` to the testsuite configuration.
* Fix all broken test cases.
Test Plan: Validate
Reviewers: hvr, goldfire, bgamari, simonpj, RyanGlScott
Reviewed By: goldfire, RyanGlScott
Subscribers: rwbarton, carter
GHC Trac Issues: #15278
Differential Revision: https://phabricator.haskell.org/D5200
>---------------------------------------------------------------
165d3d5ddaecc7dbe7f5ac051834a7619463efb0
libraries/base/tests/CatPairs.hs | 6 +-
testsuite/mk/test.mk | 3 +
testsuite/tests/deSugar/should_compile/T10767.hs | 3 +-
testsuite/tests/deSugar/should_compile/T12944.hs | 4 +-
testsuite/tests/deSugar/should_run/dsrun010.hs | 1 +
testsuite/tests/dependent/should_compile/Dep1.hs | 2 +-
testsuite/tests/dependent/should_compile/Dep3.hs | 8 +-
.../dependent/should_compile/KindEqualities.hs | 6 +-
.../dependent/should_compile/KindEqualities2.hs | 4 +-
.../tests/dependent/should_compile/KindLevels.hs | 8 +-
.../tests/dependent/should_compile/RaeJobTalk.hs | 8 +-
testsuite/tests/dependent/should_compile/T11311.hs | 2 +-
testsuite/tests/dependent/should_compile/T11635.hs | 2 +-
testsuite/tests/dependent/should_compile/T15264.hs | 2 +-
testsuite/tests/dependent/should_compile/T15346.hs | 2 +-
testsuite/tests/dependent/should_compile/T9632.hs | 4 +-
.../tests/dependent/should_compile/mkGADTVars.hs | 4 +-
testsuite/tests/dependent/should_run/T11311.hs | 2 +-
testsuite/tests/deriving/should_compile/T11416.hs | 4 +-
testsuite/tests/deriving/should_compile/T11732c.hs | 6 +-
testsuite/tests/deriving/should_compile/T11833.hs | 6 +-
.../tests/deriving/should_compile/T12144_1.hs | 4 +-
testsuite/tests/deriving/should_compile/T13297.hs | 4 +-
testsuite/tests/deriving/should_compile/T13758.hs | 3 +
testsuite/tests/deriving/should_compile/T14933.hs | 4 +-
testsuite/tests/deriving/should_compile/T8165.hs | 6 +-
testsuite/tests/deriving/should_compile/T8678.hs | 4 +-
testsuite/tests/deriving/should_compile/T9359.hs | 4 +-
.../should_compile/deriving-via-standalone.hs | 9 +-
testsuite/tests/determinism/determ004/determ004.hs | 29 +--
testsuite/tests/driver/T13803/E.hs | 4 +-
testsuite/tests/gadt/Gadt23_AST.hs | 4 +-
testsuite/tests/gadt/Session.hs | 4 +-
testsuite/tests/gadt/T14320.hs | 8 +-
testsuite/tests/gadt/T9380.hs | 5 +-
testsuite/tests/gadt/gadt20.hs | 6 +-
testsuite/tests/gadt/gadt22.hs | 3 +-
testsuite/tests/gadt/gadt8.hs | 4 +-
testsuite/tests/gadt/josef.hs | 4 +-
testsuite/tests/gadt/karl1.hs | 4 +-
testsuite/tests/gadt/karl2.hs | 6 +-
testsuite/tests/generics/T10604/T10604_deriving.hs | 5 +-
testsuite/tests/generics/T8479.hs | 7 +-
testsuite/tests/generics/T9563.hs | 3 +-
testsuite/tests/ghci/scripts/GhciKinds.hs | 4 +-
testsuite/tests/ghci/scripts/T12550.script | 1 +
testsuite/tests/ghci/scripts/T4175.hs | 4 +-
testsuite/tests/ghci/scripts/T4175.stdout | 10 +-
testsuite/tests/ghci/scripts/T5417.stdout | 2 +-
testsuite/tests/ghci/scripts/T5417a.hs | 4 +-
testsuite/tests/ghci/scripts/T6018ghcifail.script | 4 +-
testsuite/tests/ghci/scripts/T9293.stdout | 20 ++
testsuite/tests/ghci/scripts/TypeAppData.script | 4 +-
testsuite/tests/ghci/scripts/TypeAppData.stdout | 1 -
testsuite/tests/ghci/scripts/ghci024.stdout | 5 +
testsuite/tests/ghci/scripts/ghci050.script | 3 +-
testsuite/tests/ghci/scripts/ghci050.stderr | 11 +-
testsuite/tests/ghci/scripts/ghci057.stdout | 20 ++
.../indexed-types/should_compile/ATLoop_help.hs | 4 +-
.../tests/indexed-types/should_compile/Class1.hs | 4 +-
.../tests/indexed-types/should_compile/GADT12.hs | 6 +-
.../tests/indexed-types/should_compile/GADT13.hs | 4 +-
.../indexed-types/should_compile/Ind2_help.hs | 4 +-
.../should_compile/InstContextNorm.hs | 4 +-
.../tests/indexed-types/should_compile/Kind.hs | 4 +-
.../indexed-types/should_compile/OversatDecomp.hs | 6 +-
.../tests/indexed-types/should_compile/Refl.hs | 4 +-
.../tests/indexed-types/should_compile/Refl2.hs | 4 +-
.../tests/indexed-types/should_compile/Roman1.hs | 11 +-
.../tests/indexed-types/should_compile/Simple1.hs | 8 +-
.../tests/indexed-types/should_compile/Simple16.hs | 4 +-
.../tests/indexed-types/should_compile/Simple19.hs | 4 +-
.../tests/indexed-types/should_compile/Simple24.hs | 4 +-
.../tests/indexed-types/should_compile/Simple3.hs | 4 +-
.../tests/indexed-types/should_compile/Simple4.hs | 4 +-
.../tests/indexed-types/should_compile/Simple5.hs | 4 +-
.../tests/indexed-types/should_compile/Simple6.hs | 3 +-
.../tests/indexed-types/should_compile/Simple7.hs | 4 +-
.../tests/indexed-types/should_compile/Simple9.hs | 4 +-
.../tests/indexed-types/should_compile/Sock.hs | 8 +-
.../tests/indexed-types/should_compile/T10139.hs | 7 +-
.../tests/indexed-types/should_compile/T10318.hs | 4 +-
.../tests/indexed-types/should_compile/T10753.hs | 3 +-
.../tests/indexed-types/should_compile/T10931.hs | 8 +-
.../tests/indexed-types/should_compile/T11361.hs | 4 +-
.../tests/indexed-types/should_compile/T11581.hs | 4 +-
.../tests/indexed-types/should_compile/T12526.hs | 6 +-
.../tests/indexed-types/should_compile/T13662.hs | 4 +-
.../tests/indexed-types/should_compile/T14131.hs | 10 +-
.../tests/indexed-types/should_compile/T2291.hs | 6 +-
.../tests/indexed-types/should_compile/T2448.hs | 4 +-
.../tests/indexed-types/should_compile/T2715.hs | 8 +-
.../tests/indexed-types/should_compile/T2767.hs | 6 +-
.../tests/indexed-types/should_compile/T2850.hs | 4 +-
.../tests/indexed-types/should_compile/T2944.hs | 4 +-
.../tests/indexed-types/should_compile/T3220.hs | 4 +-
.../tests/indexed-types/should_compile/T3590.hs | 4 +-
.../tests/indexed-types/should_compile/T3787.hs | 5 +-
.../tests/indexed-types/should_compile/T3851.hs | 6 +-
.../tests/indexed-types/should_compile/T4120.hs | 3 +-
.../tests/indexed-types/should_compile/T4160.hs | 9 +-
.../tests/indexed-types/should_compile/T4185.hs | 4 +-
.../tests/indexed-types/should_compile/T4200.hs | 4 +-
.../tests/indexed-types/should_compile/T4356.hs | 4 +-
.../tests/indexed-types/should_compile/T4484.hs | 8 +-
.../tests/indexed-types/should_compile/T5591b.hs | 4 +-
.../tests/indexed-types/should_compile/T7082.hs | 4 +-
.../tests/indexed-types/should_compile/T7280.hs | 6 +-
.../tests/indexed-types/should_compile/T7282.hs | 4 +-
.../tests/indexed-types/should_compile/T7474.hs | 6 +-
.../tests/indexed-types/should_compile/T7489.hs | 4 +-
.../tests/indexed-types/should_compile/T8913.hs | 4 +-
.../tests/indexed-types/should_compile/T8978.hs | 4 +-
.../tests/indexed-types/should_compile/T9316.hs | 10 +-
.../tests/indexed-types/should_compile/T9840.hs | 5 +-
.../indexed-types/should_compile/T9840.hs-boot | 6 +-
.../tests/indexed-types/should_compile/ind1.hs | 4 +-
.../should_compile/red-black-delete.hs | 3 +-
.../indexed-types/should_fail/ClosedFam3.hs-boot | 4 +-
.../indexed-types/should_fail/ClosedFam3.stderr | 6 +-
.../indexed-types/should_fail/NonLinearSigErr.hs | 4 +-
testsuite/tests/indexed-types/should_fail/OverA.hs | 6 +-
.../should_fail/OverDirectThisModA.hs | 6 +-
.../should_fail/OverIndirectThisModA.hs | 6 +-
.../indexed-types/should_fail/SimpleFail10.hs | 4 +-
.../tests/indexed-types/should_fail/SimpleFail4.hs | 4 +-
.../indexed-types/should_fail/SimpleFail4.stderr | 2 +-
.../tests/indexed-types/should_fail/T7354b.hs | 4 +-
testsuite/tests/indexed-types/should_fail/T8227.hs | 3 +-
.../tests/indexed-types/should_fail/T8227.stderr | 8 +-
.../tests/indexed-types/should_fail/T8227a.hs | 4 +-
.../tests/indexed-types/should_fail/T9580a.hs | 4 +-
.../tests/indexed-types/should_run/GMapAssoc.hs | 4 +-
.../tests/indexed-types/should_run/GMapTop.hs | 3 +-
.../tests/indexed-types/should_run/T11465a.hs | 2 +-
testsuite/tests/monadfail/MonadFailWarnings.hs | 2 +-
.../tests/monadfail/MonadFailWarningsDisabled.hs | 1 +
.../MonadFailWarningsWithRebindableSyntax.hs | 2 +-
.../tests/parser/should_compile/DumpRenamedAst.hs | 8 +-
.../parser/should_compile/DumpRenamedAst.stderr | 257 ++++++++++++---------
testsuite/tests/parser/should_compile/T10379.hs | 1 +
testsuite/tests/parser/should_compile/T13747.hs | 6 +-
testsuite/tests/parser/should_compile/read026.hs | 2 +
testsuite/tests/parser/should_compile/read050.hs | 4 +-
testsuite/tests/parser/should_compile/read051.hs | 4 +-
.../tests/partial-sigs/should_compile/T13482.hs | 4 +-
.../partial-sigs/should_compile/T13482.stderr | 18 +-
.../should_compile/TypeFamilyInstanceLHS.hs | 4 +-
.../should_compile/TypeFamilyInstanceLHS.stderr | 4 +-
testsuite/tests/patsyn/should_compile/T10997_1a.hs | 6 +-
testsuite/tests/patsyn/should_compile/T12968.hs | 3 +-
testsuite/tests/patsyn/should_compile/T8966.hs | 4 +-
testsuite/tests/patsyn/should_compile/T8968-1.hs | 4 +-
testsuite/tests/patsyn/should_compile/T8968-2.hs | 4 +-
testsuite/tests/perf/compiler/T5030.hs | 3 +-
testsuite/tests/perf/compiler/T5837.hs | 4 +-
.../tests/pmcheck/should_compile/EmptyCase002.hs | 8 +-
.../pmcheck/should_compile/EmptyCase002.stderr | 9 +-
.../tests/pmcheck/should_compile/EmptyCase003.hs | 16 +-
.../pmcheck/should_compile/EmptyCase003.stderr | 7 +-
.../tests/pmcheck/should_compile/EmptyCase004.hs | 6 +-
.../pmcheck/should_compile/EmptyCase004.stderr | 15 +-
.../tests/pmcheck/should_compile/EmptyCase006.hs | 4 +-
.../pmcheck/should_compile/EmptyCase006.stderr | 5 +-
.../tests/pmcheck/should_compile/EmptyCase007.hs | 4 +-
.../pmcheck/should_compile/EmptyCase007.stderr | 13 +-
.../tests/pmcheck/should_compile/EmptyCase008.hs | 4 +-
.../pmcheck/should_compile/EmptyCase008.stderr | 9 +-
.../tests/pmcheck/should_compile/EmptyCase009.hs | 6 +-
.../pmcheck/should_compile/EmptyCase009.stderr | 7 +-
.../tests/pmcheck/should_compile/EmptyCase010.hs | 10 +-
.../pmcheck/should_compile/EmptyCase010.stderr | 17 +-
testsuite/tests/pmcheck/should_compile/T8970.hs | 8 +-
testsuite/tests/polykinds/Freeman.hs | 40 ++--
testsuite/tests/polykinds/PolyInstances.hs | 4 +-
testsuite/tests/polykinds/PolyKinds01.hs | 4 +-
testsuite/tests/polykinds/PolyKinds09.hs | 12 +-
testsuite/tests/polykinds/RedBlack.hs | 6 +-
testsuite/tests/polykinds/T10670.hs | 3 +-
testsuite/tests/polykinds/T11362.hs | 8 +-
testsuite/tests/polykinds/T11480a.hs | 8 +-
testsuite/tests/polykinds/T11821.hs | 7 +-
testsuite/tests/polykinds/T14172a.hs | 5 +-
testsuite/tests/polykinds/T14723.hs | 2 +-
testsuite/tests/polykinds/T14873.hs | 2 +-
testsuite/tests/polykinds/T5862.hs | 4 +-
testsuite/tests/polykinds/T5937.hs | 4 +-
testsuite/tests/polykinds/T5938.hs | 4 +-
testsuite/tests/polykinds/T6002.hs | 10 +-
testsuite/tests/polykinds/T6049.hs | 8 +-
testsuite/tests/polykinds/T6068.hs | 8 +-
testsuite/tests/polykinds/T6081.hs | 4 +-
testsuite/tests/polykinds/T6093.hs | 6 +-
testsuite/tests/polykinds/T6118.hs | 5 +-
testsuite/tests/polykinds/T6137.hs | 16 +-
testsuite/tests/polykinds/T7053a.hs | 4 +-
testsuite/tests/polykinds/T7176.hs | 2 +-
testsuite/tests/polykinds/T7332.hs | 3 +-
testsuite/tests/polykinds/T7347.hs | 4 +-
testsuite/tests/polykinds/T7404.hs | 4 +-
testsuite/tests/polykinds/T7438a.hs | 4 +-
testsuite/tests/polykinds/T7481.hs | 5 +-
testsuite/tests/polykinds/T7601.hs | 4 +-
testsuite/tests/polykinds/T7908.hs | 14 +-
testsuite/tests/polykinds/T7916.hs | 7 +-
testsuite/tests/polykinds/T7973.hs | 4 +-
testsuite/tests/polykinds/T9200.hs | 4 +-
testsuite/tests/polykinds/T9574.hs | 14 +-
testsuite/tests/polykinds/T9725.hs | 10 +-
testsuite/tests/polykinds/T9750.hs | 3 +-
testsuite/tests/rebindable/rebindable2.hs | 1 +
testsuite/tests/rebindable/rebindable3.hs | 1 +
testsuite/tests/rebindable/rebindable4.hs | 1 +
testsuite/tests/rebindable/rebindable5.hs | 1 +
testsuite/tests/rename/should_compile/T15149A.hs | 4 +-
testsuite/tests/roles/should_compile/Roles1.hs | 4 +-
testsuite/tests/simplCore/should_compile/T11562.hs | 7 +-
testsuite/tests/simplCore/should_compile/T11644.hs | 4 +-
testsuite/tests/simplCore/should_compile/T13410.hs | 9 +-
.../tests/simplCore/should_compile/T14270a.hs | 2 +-
testsuite/tests/simplCore/should_compile/T15186.hs | 3 +-
.../tests/simplCore/should_compile/T15517a.hs | 19 +-
testsuite/tests/simplCore/should_compile/T5303.hs | 15 +-
testsuite/tests/simplCore/should_compile/T7785.hs | 4 +-
.../tests/simplCore/should_compile/simpl011.hs | 4 +-
testsuite/tests/simplCore/should_run/T3591.hs | 9 +-
testsuite/tests/th/T10828.hs | 13 +-
testsuite/tests/th/T10891.hs | 7 +-
testsuite/tests/th/T11463.hs | 8 +-
testsuite/tests/th/T11484.hs | 4 +-
testsuite/tests/th/T12646.hs | 9 +-
testsuite/tests/th/T13123.hs | 16 +-
testsuite/tests/th/T13782.hs | 3 +-
testsuite/tests/th/T14817.hs | 6 +-
testsuite/tests/th/T14817.stderr | 10 +-
testsuite/tests/th/T3920.hs | 9 +-
testsuite/tests/th/T5452.hs | 8 +-
testsuite/tests/th/T5882.hs | 7 +-
testsuite/tests/th/T5886a.hs | 5 +-
testsuite/tests/th/T8031.hs | 2 +-
testsuite/tests/th/T8953.hs | 27 +--
testsuite/tests/th/T9199.hs | 4 +-
testsuite/tests/th/T9692.hs | 7 +-
testsuite/tests/th/TH_RichKinds.hs | 11 +-
testsuite/tests/th/TH_tf1.hs | 4 +-
testsuite/tests/typecheck/should_compile/T10195.hs | 4 +-
testsuite/tests/typecheck/should_compile/T10432.hs | 4 +-
testsuite/tests/typecheck/should_compile/T10564.hs | 8 +-
testsuite/tests/typecheck/should_compile/T10592.hs | 3 +-
testsuite/tests/typecheck/should_compile/T11401.hs | 8 +-
testsuite/tests/typecheck/should_compile/T11811.hs | 2 +-
testsuite/tests/typecheck/should_compile/T12797.hs | 3 +-
testsuite/tests/typecheck/should_compile/T12911.hs | 2 +-
testsuite/tests/typecheck/should_compile/T13333.hs | 2 +-
.../tests/typecheck/should_compile/T13585a.hs | 5 +-
testsuite/tests/typecheck/should_compile/T13881.hs | 2 +-
testsuite/tests/typecheck/should_compile/T1470.hs | 4 +-
testsuite/tests/typecheck/should_compile/T14732.hs | 5 +-
testsuite/tests/typecheck/should_compile/T14763.hs | 4 +-
testsuite/tests/typecheck/should_compile/T15368.hs | 4 +-
.../tests/typecheck/should_compile/T15368.stderr | 18 +-
testsuite/tests/typecheck/should_compile/T15370.hs | 2 +-
testsuite/tests/typecheck/should_compile/T4310.hs | 4 +-
testsuite/tests/typecheck/should_compile/T4952.hs | 3 +-
testsuite/tests/typecheck/should_compile/T5595.hs | 4 +-
testsuite/tests/typecheck/should_compile/T5655.hs | 4 +-
testsuite/tests/typecheck/should_compile/T6011.hs | 4 +-
testsuite/tests/typecheck/should_compile/T6018.hs | 10 +-
.../tests/typecheck/should_compile/T6018.hs-boot | 5 +-
.../tests/typecheck/should_compile/T6018.stderr | 8 +-
testsuite/tests/typecheck/should_compile/T6018a.hs | 3 +-
testsuite/tests/typecheck/should_compile/T7196.hs | 8 +-
testsuite/tests/typecheck/should_compile/T7875.hs | 4 +-
testsuite/tests/typecheck/should_compile/T7891.hs | 4 +-
testsuite/tests/typecheck/should_compile/T7903.hs | 4 +-
.../tests/typecheck/should_compile/T7903.stderr | 4 +-
.../tests/typecheck/should_compile/Tc245_A.hs | 6 +-
.../tests/typecheck/should_compile/Tc251_Help.hs | 4 +-
testsuite/tests/typecheck/should_compile/Vta1.hs | 8 +-
testsuite/tests/typecheck/should_compile/tc190.hs | 4 +-
testsuite/tests/typecheck/should_compile/tc247.hs | 8 +-
testsuite/tests/typecheck/should_compile/tc250.hs | 4 +-
testsuite/tests/typecheck/should_compile/tc252.hs | 4 +-
testsuite/tests/typecheck/should_compile/tc253.hs | 4 +-
testsuite/tests/typecheck/should_compile/tc255.hs | 4 +-
testsuite/tests/typecheck/should_compile/tc256.hs | 4 +-
testsuite/tests/typecheck/should_compile/tc257.hs | 6 +-
.../tests/typecheck/should_fail/ContextStack2.hs | 4 +-
.../tests/typecheck/should_fail/T6018Afail.hs | 4 +-
.../tests/typecheck/should_fail/T6018Bfail.hs | 4 +-
testsuite/tests/typecheck/should_fail/T6018fail.hs | 6 +-
.../tests/typecheck/should_fail/T6018fail.stderr | 120 +++++-----
testsuite/tests/typecheck/should_fail/tcfail188.hs | 8 +-
testsuite/tests/typecheck/should_run/T3500a.hs | 4 +-
testsuite/tests/typecheck/should_run/T9858c.hs | 4 +-
testsuite/tests/typecheck/should_run/TypeOf.hs | 1 +
testsuite/tests/typecheck/should_run/TypeRep.hs | 2 +
.../tests/warnings/should_compile/StarBinder.hs | 1 +
.../warnings/should_compile/StarBinder.stderr | 4 +-
.../tests/wcompat-warnings/WCompatWarningsNotOn.hs | 5 -
.../tests/wcompat-warnings/WCompatWarningsOn.hs | 2 +-
testsuite/tests/wcompat-warnings/all.T | 1 -
302 files changed, 1273 insertions(+), 790 deletions(-)
Diff suppressed because of size. To see it, use:
git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 165d3d5ddaecc7dbe7f5ac051834a7619463efb0
More information about the ghc-commits
mailing list