[commit: ghc] master: rts: Stop tracing environment variables (fixes #15371) (68a747c)
git at git.haskell.org
git at git.haskell.org
Sun Oct 14 20:05:21 UTC 2018
Repository : ssh://git@git.haskell.org/ghc
On branch : master
Link : http://ghc.haskell.org/trac/ghc/changeset/68a747c702d2432cc90d2a79a6aba0e67ac3e2c0/ghc
>---------------------------------------------------------------
commit 68a747c702d2432cc90d2a79a6aba0e67ac3e2c0
Author: Mitsutoshi Aoe <maoe at foldr.in>
Date: Sun Oct 14 20:23:21 2018 +0200
rts: Stop tracing environment variables (fixes #15371)
Summary:
This tracing may cause a security issue as some external tools
out there expects user to set credentials in environment variables.
Reviewers: bgamari, erikd, simonmar, monoidal
Reviewed By: monoidal
Subscribers: tdammers, rwbarton, carter
GHC Trac Issues: #15371
Differential Revision: https://phabricator.haskell.org/D5187
>---------------------------------------------------------------
68a747c702d2432cc90d2a79a6aba0e67ac3e2c0
rts/Trace.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/rts/Trace.c b/rts/Trace.c
index 5b485c4..5abd1d9 100644
--- a/rts/Trace.c
+++ b/rts/Trace.c
@@ -478,16 +478,6 @@ void traceOSProcessInfo_(void) {
argc, argv);
}
}
- {
- int envc = 0; char **envv;
- getProgEnvv(&envc, &envv);
- if (envc != 0) {
- postCapsetVecEvent(EVENT_PROGRAM_ENV,
- CAPSET_OSPROCESS_DEFAULT,
- envc, envv);
- }
- freeProgEnvv(envc, envv);
- }
}
}
More information about the ghc-commits
mailing list