[commit: ghc] master: Simplify 'ExtBits' in the lexer (d2fbc33)

git at git.haskell.org git at git.haskell.org
Thu Nov 22 21:09:15 UTC 2018


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/d2fbc33c4ff3074126ab71654af8bbf8a46e4e11/ghc

>---------------------------------------------------------------

commit d2fbc33c4ff3074126ab71654af8bbf8a46e4e11
Author: Alec Theriault <alec.theriault at gmail.com>
Date:   Thu Nov 22 14:40:08 2018 -0500

    Simplify 'ExtBits' in the lexer
    
    The main change is to export 'ExtBits' instead of defining/exporting a
    bunch of boilerplate functions that test for a particular 'ExtBits'.
    In the process, I also
    
      * cleaned up an unneeded special case for 'ITstatic'
      * made 'UsePosPrags' another variant of 'ExtBits'
      * made the logic in 'reservedSymsFM' match that of 'reservedWordsFM'
    
    Test Plan: make test
    
    Reviewers: bgamari, alanz
    
    Subscribers: sjakobi, rwbarton, mpickering, carter
    
    Differential Revision: https://phabricator.haskell.org/D5332


>---------------------------------------------------------------

d2fbc33c4ff3074126ab71654af8bbf8a46e4e11
 compiler/parser/Lexer.x     | 498 +++++++++++++++++++-------------------------
 compiler/parser/Parser.y    |  14 +-
 compiler/parser/RdrHsSyn.hs |  32 +--
 3 files changed, 238 insertions(+), 306 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc d2fbc33c4ff3074126ab71654af8bbf8a46e4e11


More information about the ghc-commits mailing list