[commit: ghc] master: Tidy up error suppression (f49f90b)

[git at git.haskell.org]

Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/f49f90bb84b12515366de9b8184644b5c3798901/ghc

>---------------------------------------------------------------

commit f49f90bb84b12515366de9b8184644b5c3798901
Author: Simon Peyton Jones <simonpj at microsoft.com>
Date:   Tue May 15 11:36:28 2018 +0100

    Tidy up error suppression
    
    Trac #15152 showed that when a flag turned an error into a warning, we
    were still (alas) suppressing subequent errors; includign their
    essential addTcEvBind.  That led (rightly) to a Lint error.
    
    This patch fixes it, and incidentally tidies up an ad-hoc special
    case of out-of-scope variables (see the old binding for
    'out_of_scope_killer' in 'tryReporters').
    
    No test, because the problem was only shown up when turning
    inaccessible code into a warning.


>---------------------------------------------------------------

f49f90bb84b12515366de9b8184644b5c3798901
 compiler/typecheck/TcErrors.hs                     | 56 +++++++++++++---------
 .../tests/partial-sigs/should_fail/T14584.stderr   | 11 +++++
 .../tests/partial-sigs/should_fail/T14584a.stderr  | 13 +++++
 3 files changed, 57 insertions(+), 23 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc f49f90bb84b12515366de9b8184644b5c3798901