[commit: ghc] master: Fix scoped type variables in TH for several constructs (a3986d7)

git at git.haskell.org git at git.haskell.org
Mon Mar 26 00:13:02 UTC 2018


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/a3986d7fa59d96a77ac0f25bcf1dcf96b8746994/ghc

>---------------------------------------------------------------

commit a3986d7fa59d96a77ac0f25bcf1dcf96b8746994
Author: HE, Tao <sighingnow at gmail.com>
Date:   Sun Mar 25 15:34:45 2018 -0400

    Fix scoped type variables in TH for several constructs
    
    Namely class methods, default signatures and pattern synonyms.
    
    When scoped type variables occur inside class default methods,
    default signatures and pattern synonyms, avoid re-create explicit
    type variables when represent the type signatures.
    
    This patch should fix Trac#14885.
    
    Signed-off-by: HE, Tao <sighingnow at gmail.com>
    
    Test Plan: make test TEST="T14885a T14885b T14885c"
    
    Reviewers: goldfire, bgamari, simonpj, RyanGlScott
    
    Reviewed By: simonpj, RyanGlScott
    
    Subscribers: rwbarton, thomie, carter
    
    GHC Trac Issues: #14885
    
    Differential Revision: https://phabricator.haskell.org/D4469


>---------------------------------------------------------------

a3986d7fa59d96a77ac0f25bcf1dcf96b8746994
 compiler/deSugar/DsMeta.hs       | 197 ++++++++++++++++++++++++---------------
 docs/users_guide/8.6.1-notes.rst |   3 +
 testsuite/tests/th/T14885a.hs    |  18 ++++
 testsuite/tests/th/T14885b.hs    |  16 ++++
 testsuite/tests/th/T14885c.hs    |  14 +++
 testsuite/tests/th/T7064.stdout  |   4 +-
 testsuite/tests/th/all.T         |   3 +
 7 files changed, 177 insertions(+), 78 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc a3986d7fa59d96a77ac0f25bcf1dcf96b8746994


More information about the ghc-commits mailing list