[commit: ghc] master: Allow top level ticked string literals (5bc195a)

git at git.haskell.org git at git.haskell.org
Tue Mar 6 13:57:11 UTC 2018


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/5bc195a2caddc5c29cf24e9c731dd8d5050f2c66/ghc

>---------------------------------------------------------------

commit 5bc195a2caddc5c29cf24e9c731dd8d5050f2c66
Author: Bartosz Nitka <niteria at gmail.com>
Date:   Fri Mar 2 05:33:07 2018 -0800

    Allow top level ticked string literals
    
    This reverts f5b275a239d2554c4da0b7621211642bf3b10650
    and changes the places that looked for `Lit (MachStr _))`
    to use `exprIsMbTickedLitString_maybe` to unwrap ticks as
    necessary.
    Also updated relevant comments.
    
    Test Plan:
    I added 3 new tests that previously reproduced.
    GHC HEAD now builds with -g
    
    Reviewers: simonpj, simonmar, bgamari, hvr, goldfire
    
    Subscribers: rwbarton, thomie, carter
    
    GHC Trac Issues: #14779
    
    Differential Revision: https://phabricator.haskell.org/D4470


>---------------------------------------------------------------

5bc195a2caddc5c29cf24e9c731dd8d5050f2c66
 compiler/coreSyn/CoreLint.hs                       |  6 +-
 compiler/coreSyn/CoreSyn.hs                        | 10 +--
 compiler/coreSyn/CoreUtils.hs                      | 29 ++++++--
 compiler/ghci/ByteCodeGen.hs                       |  4 +-
 compiler/simplCore/CSE.hs                          |  4 +-
 compiler/simplCore/FloatOut.hs                     | 32 ++++-----
 compiler/simplCore/SimplEnv.hs                     |  4 +-
 compiler/simplCore/Simplify.hs                     |  8 +--
 compiler/stgSyn/CoreToStg.hs                       |  7 +-
 .../tests/simplCore/should_compile/T14779a.hs      | 34 +++++++++
 .../tests/simplCore/should_compile/T14779b.hs      | 83 ++++++++++++++++++++++
 testsuite/tests/simplCore/should_compile/all.T     |  6 ++
 testsuite/tests/simplCore/should_run/T14868.hs     |  2 +
 testsuite/tests/simplCore/should_run/T14868.stdout |  1 +
 testsuite/tests/simplCore/should_run/all.T         |  3 +
 15 files changed, 183 insertions(+), 50 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 5bc195a2caddc5c29cf24e9c731dd8d5050f2c66


More information about the ghc-commits mailing list