[commit: ghc] master: Remove unnecessary call to checkReductionDepth (d5459a3)

git at git.haskell.org git at git.haskell.org
Fri Jun 22 12:11:42 UTC 2018


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/d5459a3356e84226e779706eda2d733960d6e54e/ghc

>---------------------------------------------------------------

commit d5459a3356e84226e779706eda2d733960d6e54e
Author: Simon Peyton Jones <simonpj at microsoft.com>
Date:   Fri Jun 22 11:30:10 2018 +0100

    Remove unnecessary call to checkReductionDepth
    
    We call checkReductionDepth in chooseInstance, so there's no
    need to call it in selectNextWorkItem too


>---------------------------------------------------------------

d5459a3356e84226e779706eda2d733960d6e54e
 compiler/typecheck/TcSMonad.hs | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/compiler/typecheck/TcSMonad.hs b/compiler/typecheck/TcSMonad.hs
index 965bf5f..9aafbf3 100644
--- a/compiler/typecheck/TcSMonad.hs
+++ b/compiler/typecheck/TcSMonad.hs
@@ -367,7 +367,8 @@ selectNextWorkItem
        ; case selectWorkItem wl of {
            Nothing -> return Nothing ;
            Just (ct, new_wl) ->
-    do { checkReductionDepth (ctLoc ct) (ctPred ct)
+    do { -- checkReductionDepth (ctLoc ct) (ctPred ct)
+         -- This is done by TcInteract.chooseInstance
        ; wrapTcS (TcM.writeTcRef wl_var new_wl)
        ; return (Just ct) } } }
 



More information about the ghc-commits mailing list