[commit: ghc] master: Handle DuplicateRecordFields correctly in filterImports (fixes #14487) (ccd8ce4)
git at git.haskell.org
git at git.haskell.org
Sun Jun 17 15:18:03 UTC 2018
Repository : ssh://git@git.haskell.org/ghc
On branch : master
Link : http://ghc.haskell.org/trac/ghc/changeset/ccd8ce405db89142932daea3fdace8814b110798/ghc
>---------------------------------------------------------------
commit ccd8ce405db89142932daea3fdace8814b110798
Author: Adam Gundry <adam at well-typed.com>
Date: Sun Jun 17 10:47:57 2018 -0400
Handle DuplicateRecordFields correctly in filterImports (fixes #14487)
filterImports needed a small adjustment to correctly handle record field
definitions arising from modules with DuplicateRecordFields enabled.
Previously hiding fields was not possible with DuplicateRecordFields enabled.
Test Plan: new test rename/should_compile/T14487
Reviewers: bgamari
Subscribers: simonpj, rwbarton, thomie, carter
GHC Trac Issues: #14487
Differential Revision: https://phabricator.haskell.org/D4805
>---------------------------------------------------------------
ccd8ce405db89142932daea3fdace8814b110798
compiler/basicTypes/Avail.hs | 18 +++++++++++++++
compiler/rename/RnNames.hs | 7 +++---
compiler/typecheck/TcRnExports.hs | 27 ++++++++++------------
.../should_fail/DuplicateExports.hs | 9 ++++++++
.../should_fail/DuplicateExports.stderr | 3 +++
.../tests/overloadedrecflds/should_fail/all.T | 1 +
testsuite/tests/rename/should_compile/T14487.hs | 7 ++++++
testsuite/tests/rename/should_compile/T14487A.hs | 7 ++++++
testsuite/tests/rename/should_compile/all.T | 1 +
9 files changed, 62 insertions(+), 18 deletions(-)
Diff suppressed because of size. To see it, use:
git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc ccd8ce405db89142932daea3fdace8814b110798
More information about the ghc-commits
mailing list