[commit: ghc] master: No Unicode in Parser.y (78f5344)

git at git.haskell.org git at git.haskell.org
Fri Jun 15 18:58:43 UTC 2018


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/78f5344e856d8b908209d93f685230ae617e53a2/ghc

>---------------------------------------------------------------

commit 78f5344e856d8b908209d93f685230ae617e53a2
Author: Vladislav Zavialov <vlad.z.4096 at gmail.com>
Date:   Fri Jun 15 13:45:03 2018 -0400

    No Unicode in Parser.y
    
    Unicode characters in Parser.y cause build failures
    on systems where the locale does not support Unicode.
    
    See https://mail.haskell.org/pipermail/ghc-devs/2018-June/015874.html
    
    Test Plan: ./validate
    
    Reviewers: bgamari
    
    Reviewed By: bgamari
    
    Subscribers: rwbarton, thomie, mpickering, carter
    
    Differential Revision: https://phabricator.haskell.org/D4850


>---------------------------------------------------------------

78f5344e856d8b908209d93f685230ae617e53a2
 compiler/parser/Parser.y | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/compiler/parser/Parser.y b/compiler/parser/Parser.y
index c1ee8a4..d4caf76 100644
--- a/compiler/parser/Parser.y
+++ b/compiler/parser/Parser.y
@@ -3368,7 +3368,7 @@ special_id
 special_sym :: { Located FastString }
 special_sym : '!'       {% ams (sL1 $1 (fsLit "!")) [mj AnnBang $1] }
             | '.'       { sL1 $1 (fsLit ".") }
-            | '*'       { sL1 $1 (fsLit (if isUnicode $1 then "★" else "*")) }
+            | '*'       { sL1 $1 (fsLit (if isUnicode $1 then "\x2605" else "*")) }
 
 -----------------------------------------------------------------------------
 -- Data constructors



More information about the ghc-commits mailing list