[commit: ghc] master: Fix unparseable pretty-printing of promoted data cons (767536c)
git at git.haskell.org
git at git.haskell.org
Fri Jun 8 00:07:13 UTC 2018
Repository : ssh://git@git.haskell.org/ghc
On branch : master
Link : http://ghc.haskell.org/trac/ghc/changeset/767536ccf95d8352d146b6544857b28d9c42937e/ghc
>---------------------------------------------------------------
commit 767536ccf95d8352d146b6544857b28d9c42937e
Author: Andreas Herrmann <andreash87 at gmx.ch>
Date: Thu Jun 7 13:24:52 2018 -0400
Fix unparseable pretty-printing of promoted data cons
Previously we would print code which would not round-trip:
```
> :set -XDataKinds
> :set -XPolyKinds
> data Proxy k = Proxy
> _ :: Proxy '[ 'True ]
error:
Found hole: _ :: Proxy '['True]
> _ :: Proxy '['True]
error:
Invalid type signature: _ :: ...
Should be of form <variable> :: <type>
```
Test Plan: Validate with T14343
Reviewers: RyanGlScott, goldfire, bgamari, tdammers
Reviewed By: RyanGlScott, bgamari
Subscribers: tdammers, rwbarton, thomie, carter
GHC Trac Issues: #14343
Differential Revision: https://phabricator.haskell.org/D4746
>---------------------------------------------------------------
767536ccf95d8352d146b6544857b28d9c42937e
compiler/iface/IfaceType.hs | 18 ++++++++--
testsuite/tests/perf/compiler/T13035.stderr | 2 +-
testsuite/tests/perf/compiler/T9872b.stderr | 32 +++++++++---------
testsuite/tests/printer/Makefile | 8 +++++
testsuite/tests/printer/T14343.hs | 12 +++++++
testsuite/tests/printer/T14343.stderr | 36 ++++++++++++++++++++
testsuite/tests/printer/T14343b.hs | 12 +++++++
testsuite/tests/printer/T14343b.stderr | 39 ++++++++++++++++++++++
testsuite/tests/printer/all.T | 2 ++
.../tests/typecheck/should_fail/T15067.stderr | 10 +++---
testsuite/tests/unboxedsums/T12711.stdout | 2 +-
11 files changed, 147 insertions(+), 26 deletions(-)
Diff suppressed because of size. To see it, use:
git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 767536ccf95d8352d146b6544857b28d9c42937e
More information about the ghc-commits
mailing list